cmccabe commented on a change in pull request #9032:
URL: https://github.com/apache/kafka/pull/9032#discussion_r474416243



##########
File path: 
clients/src/main/java/org/apache/kafka/clients/admin/DescribeUserScramCredentialsResult.java
##########
@@ -0,0 +1,50 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ *    http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.kafka.clients.admin;
+
+import org.apache.kafka.common.KafkaFuture;
+import org.apache.kafka.common.annotation.InterfaceStability;
+
+import java.util.List;
+import java.util.Objects;
+
+/**
+ * The result of the {@link Admin#describeUserScramCredentials()} call.
+ *
+ * The API of this class is evolving, see {@link Admin} for details.
+ */
+@InterfaceStability.Evolving
+public class DescribeUserScramCredentialsResult {
+    private final KafkaFuture<List<UserScramCredentialsDescriptionResult>> 
future;
+
+    /**
+     *
+     * @param future the required future representing the result of the call
+     */
+    public 
DescribeUserScramCredentialsResult(KafkaFuture<List<UserScramCredentialsDescriptionResult>>
 future) {
+        this.future = Objects.requireNonNull(future);
+    }
+
+    /**
+     *
+     * @return the future representing the result of the call
+     */
+    public KafkaFuture<List<UserScramCredentialsDescriptionResult>> future() {

Review comment:
       Based on our offline discussion, I thought we were going to have three 
methods here:
   ```
   KafkaFuture<Map<String, UserScramCredentialsDescription>> all()
   ```
   Returns all the users that were listed, or throws an exception if there was 
an error describing any of them.
   
   ```
   KafkaFuture<List<String>> users();
   ```
   Returns the names of all the users that were described, whether the 
describing was successful or not.
   
   ```
   KafkaFuture<UserScramCredentialDescription> description(String userName);
   ```
   Returns a future describing userName, or RESOURCE_NOT_FOUND if the user was 
not listed or not found.  




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to