[GitHub] [kafka] mjsax commented on a change in pull request #9156: KAFKA-10077: Filter downstream of state-store results in spurious tombstones

Thu, 20 Aug 2020 18:13:21 -0700 


mjsax commented on a change in pull request #9156:
URL: https://github.com/apache/kafka/pull/9156#discussion_r474353504



##########
File path: 
streams/src/main/java/org/apache/kafka/streams/kstream/internals/KTableImpl.java
##########
@@ -203,6 +203,10 @@ public String queryableStoreName() {
             processorSupplier,
             tableNode,
             builder);
+
+        kTable.enableSendingOldValues();

Review comment:
       Don't we need to call `this.enableSendingOldValues()` as "this" is the 
upstream KTable the filter is applied to? Why do we need to enable sending old 
values on the result of the filter() ?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to