Re: [PR] [WIP] KAFKA-18185: remove internal.leave.group.on.close config [kafka]

2025-04-10 Thread via GitHub
frankvicky commented on PR #19400: URL: https://github.com/apache/kafka/pull/19400#issuecomment-2791810133 Hi @ableegoldman Please take a look when you have a free moment. I have some questions since I'm not familiar with the stream module. Please bear with me if the code looks like

Re: [PR] [WIP] KAFKA-18185: remove internal.leave.group.on.close config [kafka]

2025-04-10 Thread via GitHub
frankvicky commented on code in PR #19400: URL: https://github.com/apache/kafka/pull/19400#discussion_r2036675899 ## streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java: ## @@ -1205,45 +1200,9 @@ private Optional removeStreamThread(final long timeoutMs) throws Time

Re: [PR] KAFKA-19118: Enable KIP-1071 in InternalTopicIntegrationTest [kafka]

2025-04-10 Thread via GitHub
lucasbru commented on code in PR #19425: URL: https://github.com/apache/kafka/pull/19425#discussion_r2037278831 ## streams/integration-tests/src/test/java/org/apache/kafka/streams/integration/utils/EmbeddedKafkaCluster.java: ## @@ -140,6 +140,19 @@ public EmbeddedKafkaCluster(fi

Re: [PR] KAFKA-19118: Enable KIP-1071 in InternalTopicIntegrationTest [kafka]

2025-04-10 Thread via GitHub
lucasbru commented on PR #19425: URL: https://github.com/apache/kafka/pull/19425#issuecomment-2792673278 Thanks for the comments @FrankYang0529, addressed! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[PR] MINOR: Consolidated message formatter for share group records [kafka]

2025-04-10 Thread via GitHub
AndrewJSchofield opened a new pull request, #19435: URL: https://github.com/apache/kafka/pull/19435 Create a single formatter for use with `kafka-console-consumer.sh` that formats all record types for share groups on the `__consumer_offsets` topic. -- This is an automated message from the

[jira] [Created] (KAFKA-19125) Implement Large message reference-based Serializer

2025-04-10 Thread Omnia Ibrahim (Jira)
Omnia Ibrahim created KAFKA-19125: - Summary: Implement Large message reference-based Serializer Key: KAFKA-19125 URL: https://issues.apache.org/jira/browse/KAFKA-19125 Project: Kafka Issue Ty

[PR] KAFKA-19019: Add remote storage fetch for share groups [kafka]

2025-04-10 Thread via GitHub
adixitconfluent opened a new pull request, #19437: URL: https://github.com/apache/kafka/pull/19437 ### What This PR adds the support for remote storage fetch for share groups. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[jira] [Updated] (KAFKA-19126) Duplicate offsets written to log for different messages

2025-04-10 Thread Adrian C. (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian C. updated KAFKA-19126: -- Description: We have observed during normal operations that messages/batches can be written to disk w

Re: [PR] (WIP) KAFKA-18891: KIP-877 add support for RemoteLogMetadataManager and RemoteStorageManager [kafka]

2025-04-10 Thread via GitHub
m1a2st commented on code in PR #19286: URL: https://github.com/apache/kafka/pull/19286#discussion_r2037585875 ## server/src/test/java/org/apache/kafka/server/MonitorablePluginsIntegrationTest.java: ## @@ -0,0 +1,116 @@ +/* + * Licensed to the Apache Software Foundation (ASF) und

[jira] [Assigned] (KAFKA-19110) Add missing unit test for Streams-consumer integration

2025-04-10 Thread PoAn Yang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19110?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] PoAn Yang reassigned KAFKA-19110: - Assignee: PoAn Yang (was: Bruno Cadonna) > Add missing unit test for Streams-consumer integrat

Re: [PR] KAFKA-19124: Use consumer background event queue for Streams events [kafka]

2025-04-10 Thread via GitHub
cadonna commented on code in PR #19421: URL: https://github.com/apache/kafka/pull/19421#discussion_r2037577517 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java: ## @@ -180,6 +186,25 @@ public class AsyncKafkaConsumer implements Consum

Re: [PR] KAFKA-18170: Add create and write timestamp fields in share snapshot [1/N] [kafka]

2025-04-10 Thread via GitHub
smjn commented on PR #19432: URL: https://github.com/apache/kafka/pull/19432#issuecomment-2792255361 @AndrewJSchofield thanks for pointing out, fixed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] KAFKA-19057: Stabilize KIP-932 RPCs for AK 4.1 [kafka]

2025-04-10 Thread via GitHub
apoorvmittal10 commented on code in PR #19378: URL: https://github.com/apache/kafka/pull/19378#discussion_r2037272992 ## clients/src/main/java/org/apache/kafka/common/requests/AlterShareGroupOffsetsRequest.java: ## @@ -41,7 +41,7 @@ public static class Builder extends AbstractR

Re: [PR] [WIP]KAFKA-19080 The constraint on segment.ms is not enforced at topic level [kafka]

2025-04-10 Thread via GitHub
chia7712 commented on PR #19371: URL: https://github.com/apache/kafka/pull/19371#issuecomment-2792577675 for example: ```java this.internalSegmentSize = getString(TopicConfig.INTERNAL_SEGMENT_BYTES_CONFIG); ... public long segmentSize() { i

Re: [PR] KAFKA-19124: Use consumer background event queue for Streams events [kafka]

2025-04-10 Thread via GitHub
cadonna commented on code in PR #19421: URL: https://github.com/apache/kafka/pull/19421#discussion_r2037412696 ## streams/integration-tests/src/test/java/org/apache/kafka/streams/integration/SmokeTestDriverIntegrationTest.java: ## @@ -120,6 +120,8 @@ SmokeTestDriver.Verification

Re: [PR] KAFKA-19124: Use consumer background event queue for Streams events [kafka]

2025-04-10 Thread via GitHub
cadonna commented on code in PR #19421: URL: https://github.com/apache/kafka/pull/19421#discussion_r2037425707 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java: ## @@ -1476,17 +1473,12 @@ private ConsumerRecords pollRequests(final Duration

[jira] [Commented] (KAFKA-18288) Add support kafka-streams-groups.sh --describe

2025-04-10 Thread Alieh Saeedi (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17943230#comment-17943230 ] Alieh Saeedi commented on KAFKA-18288: -- AK PR: https://github.com/apache/kafka/pull

[jira] [Assigned] (KAFKA-19127) Integration Test for Admin API-Driven Group-Level Streams Group Configuration Changes

2025-04-10 Thread Alieh Saeedi (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19127?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alieh Saeedi reassigned KAFKA-19127: Assignee: Alieh Saeedi > Integration Test for Admin API-Driven Group-Level Streams Group

[jira] [Created] (KAFKA-19127) Integration Test for Admin API-Driven Group-Level Streams Group Configuration Changes

2025-04-10 Thread Alieh Saeedi (Jira)
Alieh Saeedi created KAFKA-19127: Summary: Integration Test for Admin API-Driven Group-Level Streams Group Configuration Changes Key: KAFKA-19127 URL: https://issues.apache.org/jira/browse/KAFKA-19127

[jira] [Updated] (KAFKA-19126) Duplicate offsets written to log for different messages

2025-04-10 Thread Adrian C. (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian C. updated KAFKA-19126: -- Attachment: log-dump-sample.txt > Duplicate offsets written to log for different messages > --

[PR] KAFKA-19127: Integration test for altering and describing streams group configs [kafka]

2025-04-10 Thread via GitHub
aliehsaeedii opened a new pull request, #19436: URL: https://github.com/apache/kafka/pull/19436 This PR introduces integration tests for verifying - altering configs - `describe` output for a streams group. -- This is an automated message from the Apache Git Service. To resp

[jira] [Resolved] (KAFKA-18935) Ensure brokers do not return null records in FetchResponse

2025-04-10 Thread TengYao Chi (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18935?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] TengYao Chi resolved KAFKA-18935. - Resolution: Fixed > Ensure brokers do not return null records in FetchResponse > ---

[jira] [Updated] (KAFKA-18935) Ensure brokers do not return null records in FetchResponse

2025-04-10 Thread TengYao Chi (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18935?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] TengYao Chi updated KAFKA-18935: Fix Version/s: 4.1.0 > Ensure brokers do not return null records in FetchResponse > --

Re: [PR] MINOR update the README docker image version [kafka]

2025-04-10 Thread via GitHub
frankvicky merged PR #19278: URL: https://github.com/apache/kafka/pull/19278 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apac

Re: [PR] (WIP) KAFKA-18891: KIP-877 add support for RemoteLogMetadataManager and RemoteStorageManager [kafka]

2025-04-10 Thread via GitHub
Yunyung commented on code in PR #19286: URL: https://github.com/apache/kafka/pull/19286#discussion_r2037631639 ## server/src/test/java/org/apache/kafka/server/MonitorablePluginsIntegrationTest.java: ## @@ -0,0 +1,116 @@ +/* + * Licensed to the Apache Software Foundation (ASF) un

[jira] [Updated] (KAFKA-18920) The kcontrollers do not set kraft.version in ApiVersionsResponse

2025-04-10 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-18920?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] José Armando García Sancio updated KAFKA-18920: --- Fix Version/s: 3.9.1 > The kcontrollers do not set kraft.version in

[PR] KAFKA-19121: Move AddPartitionsToTxnConfig and TransactionStateManagerConfig out of KafkaConfig [kafka]

2025-04-10 Thread via GitHub
FrankYang0529 opened a new pull request, #19439: URL: https://github.com/apache/kafka/pull/19439 Both AddPartitionsToTxnConfig and TransactionStateManagerConfig are static configs and they don't have specific config check. We can move them out of KafkaConfig to simplify KafkaConfig. -- T

[jira] [Updated] (KAFKA-18147) kraft version of standalone KIP-853. controller should be 1 not 0

2025-04-10 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-18147?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] José Armando García Sancio updated KAFKA-18147: --- Fix Version/s: (was: 3.9.1) > kraft version of standalone KIP-85

[jira] [Resolved] (KAFKA-18147) kraft version of standalone KIP-853. controller should be 1 not 0

2025-04-10 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-18147?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] José Armando García Sancio resolved KAFKA-18147. Resolution: Duplicate > kraft version of standalone KIP-853. contr

[jira] [Commented] (KAFKA-18602) Incorrect FinalizedVersionLevel reported for dynamic KRaft quorum.

2025-04-10 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-18602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17943272#comment-17943272 ] José Armando García Sancio commented on KAFKA-18602: Hi [~abasilbr]

Re: [PR] KAFKA-19030: Remove metricNamePrefix from RequestChannel [kafka]

2025-04-10 Thread via GitHub
Parkerhiphop commented on code in PR #19374: URL: https://github.com/apache/kafka/pull/19374#discussion_r2035827481 ## core/src/main/scala/kafka/network/SocketServer.scala: ## @@ -97,7 +97,7 @@ class SocketServer( private val memoryPool = if (config.queuedMaxBytes > 0) new S

Re: [PR] KAFKA-19057: Stabilize KIP-932 RPCs for AK 4.1 [kafka]

2025-04-10 Thread via GitHub
AndrewJSchofield commented on code in PR #19378: URL: https://github.com/apache/kafka/pull/19378#discussion_r2037776176 ## clients/src/main/java/org/apache/kafka/common/requests/AlterShareGroupOffsetsRequest.java: ## @@ -41,7 +41,7 @@ public static class Builder extends Abstrac

Re: [PR] KAFKA-18602: Incorrect FinalizedVersionLevel reported for dynamic KRaft quorum [kafka]

2025-04-10 Thread via GitHub
FrankYang0529 commented on PR #18685: URL: https://github.com/apache/kafka/pull/18685#issuecomment-2794262999 Close the PR since the issue is fixed by https://github.com/apache/kafka/pull/19127. -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] KAFKA-18170: Add create and write timestamp fields in share snapshot [1/N] [kafka]

2025-04-10 Thread via GitHub
AndrewJSchofield commented on PR #19432: URL: https://github.com/apache/kafka/pull/19432#issuecomment-2792252728 @smjn Looks like the test failures are related. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[jira] [Commented] (KAFKA-18602) Incorrect FinalizedVersionLevel reported for dynamic KRaft quorum.

2025-04-10 Thread PoAn Yang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17943278#comment-17943278 ] PoAn Yang commented on KAFKA-18602: --- Yes, I think we can close this. Thanks. > Incorr

[jira] [Assigned] (KAFKA-17541) Improve handling of delivery count

2025-04-10 Thread Apoorv Mittal (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17541?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Apoorv Mittal reassigned KAFKA-17541: - Assignee: (was: Lan Ding) > Improve handling of delivery count > --

[jira] [Assigned] (KAFKA-17541) Improve handling of delivery count

2025-04-10 Thread Apoorv Mittal (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17541?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Apoorv Mittal reassigned KAFKA-17541: - Assignee: Lan Ding > Improve handling of delivery count > -

Re: [PR] KAFKA-18602: Incorrect FinalizedVersionLevel reported for dynamic KRaft quorum [kafka]

2025-04-10 Thread via GitHub
FrankYang0529 closed pull request #18685: KAFKA-18602: Incorrect FinalizedVersionLevel reported for dynamic KRaft quorum URL: https://github.com/apache/kafka/pull/18685 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] (WIP) KAFKA-18891: KIP-877 add support for RemoteLogMetadataManager and RemoteStorageManager [kafka]

2025-04-10 Thread via GitHub
Yunyung commented on code in PR #19286: URL: https://github.com/apache/kafka/pull/19286#discussion_r2037634583 ## core/src/main/scala/kafka/server/BrokerServer.scala: ## @@ -473,22 +473,7 @@ class BrokerServer( config.numIoThreads, s"${DataPlaneAcceptor.MetricPrefix}Re

[jira] [Created] (KAFKA-19126) Duplicate offsets written to log for different messages

2025-04-10 Thread Adrian C. (Jira)
Adrian C. created KAFKA-19126: - Summary: Duplicate offsets written to log for different messages Key: KAFKA-19126 URL: https://issues.apache.org/jira/browse/KAFKA-19126 Project: Kafka Issue Type:

[jira] [Updated] (KAFKA-19126) Duplicate offsets written to log for different messages

2025-04-10 Thread Adrian C. (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian C. updated KAFKA-19126: -- Attachment: follower-error.log > Duplicate offsets written to log for different messages > ---

Re: [PR] KAFKA-19124: Use consumer background event queue for Streams events [kafka]

2025-04-10 Thread via GitHub
cadonna commented on PR #19421: URL: https://github.com/apache/kafka/pull/19421#issuecomment-2794033244 @lucasbru The PR is ready for re-review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

Re: [PR] KAFKA-19118: Enable KIP-1071 in InternalTopicIntegrationTest [kafka]

2025-04-10 Thread via GitHub
lucasbru merged PR #19425: URL: https://github.com/apache/kafka/pull/19425 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] KAFKA-18935: Ensure brokers do not return null records in FetchResponse [kafka]

2025-04-10 Thread via GitHub
frankvicky merged PR #19167: URL: https://github.com/apache/kafka/pull/19167 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apac

[PR] KAFKA-19118: Enable KIP-1071 in StandbyTaskCreationIntegrationTest [kafka]

2025-04-10 Thread via GitHub
lucasbru opened a new pull request, #19438: URL: https://github.com/apache/kafka/pull/19438 Enable KIP-1071 parameter in `StandbyTaskCreationIntegrationTest`. Required a fix: In `ChangelogTopic.setup`, we actually need to return both the source-topic (optimized) and the non-source-top

Re: [PR] KAFKA-18170: Add create and write timestamp fields in share snapshot [1/N] [kafka]

2025-04-10 Thread via GitHub
AndrewJSchofield merged PR #19432: URL: https://github.com/apache/kafka/pull/19432 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafk

Re: [PR] KAFKA-19057: Stabilize KIP-932 RPCs for AK 4.1 [kafka]

2025-04-10 Thread via GitHub
AndrewJSchofield commented on code in PR #19378: URL: https://github.com/apache/kafka/pull/19378#discussion_r2037371932 ## clients/src/main/resources/common/message/ShareAcknowledgeRequest.json: ## @@ -18,34 +18,33 @@ "type": "request", "listeners": ["broker"], "name":

Re: [PR] KAFKA-19124: Use consumer background event queue for Streams events [kafka]

2025-04-10 Thread via GitHub
cadonna commented on code in PR #19421: URL: https://github.com/apache/kafka/pull/19421#discussion_r2037419003 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java: ## @@ -1108,7 +1090,20 @@ private void subscribeConsumer() { if (topol

Re: [PR] KAFKA-14485: Move LogCleaner to storage module [kafka]

2025-04-10 Thread via GitHub
junrao commented on code in PR #19387: URL: https://github.com/apache/kafka/pull/19387#discussion_r2037829585 ## storage/src/main/java/org/apache/kafka/storage/internals/log/Cleaner.java: ## @@ -0,0 +1,762 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

Re: [PR] KAFKA-19057: Stabilize KIP-932 RPCs for AK 4.1 [kafka]

2025-04-10 Thread via GitHub
apoorvmittal10 commented on code in PR #19378: URL: https://github.com/apache/kafka/pull/19378#discussion_r2037882487 ## clients/src/main/resources/common/message/ShareAcknowledgeResponse.json: ## @@ -17,7 +17,10 @@ "apiKey": 79, "type": "response", "name": "ShareAcknow

[PR] KAFKA-18170: Add create and write timestamp fields in share snapshot [1/N] [kafka]

2025-04-10 Thread via GitHub
smjn opened a new pull request, #19432: URL: https://github.com/apache/kafka/pull/19432 * We wish to track the time of creation of the `ShareSnapshot` records so that automated jobs could force their creation if a share partition has gone cold (no updates for a specified time interval).

Re: [PR] KAFKA-19115: Utilize initialized topics info to verify delete share group offsets [kafka]

2025-04-10 Thread via GitHub
smjn commented on code in PR #19431: URL: https://github.com/apache/kafka/pull/19431#discussion_r2036832379 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorService.java: ## @@ -1248,29 +1248,118 @@ private CompletableFuture> persisterDelete

Re: [PR] KAFKA-19115: Utilize initialized topics info to verify delete share group offsets [kafka]

2025-04-10 Thread via GitHub
smjn commented on code in PR #19431: URL: https://github.com/apache/kafka/pull/19431#discussion_r2036833556 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorService.java: ## @@ -1248,29 +1248,118 @@ private CompletableFuture> persisterDelete

Re: [PR] KAFKA-18892: KIP-877 Add support for ClientQuotaCallback [kafka]

2025-04-10 Thread via GitHub
mimaison commented on code in PR #19068: URL: https://github.com/apache/kafka/pull/19068#discussion_r2032881917 ## core/src/main/java/kafka/server/QuotaFactory.java: ## @@ -113,22 +116,43 @@ public void shutdown() { } } -public static QuotaManagers instantiat

Re: [PR] KAFKA-19124: Use consumer background event queue for Streams events [kafka]

2025-04-10 Thread via GitHub
cadonna commented on PR #19421: URL: https://github.com/apache/kafka/pull/19421#issuecomment-2792233359 Call for review: @aliehsaeedii -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

Re: [PR] KAFKA-19124: Use consumer background event queue for Streams events [kafka]

2025-04-10 Thread via GitHub
lucasbru commented on code in PR #19421: URL: https://github.com/apache/kafka/pull/19421#discussion_r2037145316 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java: ## @@ -180,6 +186,25 @@ public class AsyncKafkaConsumer implements Consu

Re: [PR] KAFKA-19124: Use consumer background event queue for Streams events [kafka]

2025-04-10 Thread via GitHub
lucasbru commented on code in PR #19421: URL: https://github.com/apache/kafka/pull/19421#discussion_r2037149394 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/StreamsRebalanceListener.java: ## @@ -22,7 +22,7 @@ /** * Callbacks for handling Streams group

Re: [PR] MINOR: Add note that streams groups are in early access [kafka]

2025-04-10 Thread via GitHub
lucasbru merged PR #19434: URL: https://github.com/apache/kafka/pull/19434 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] KAFKA-19118: Enable KIP-1071 in InternalTopicIntegrationTest [kafka]

2025-04-10 Thread via GitHub
FrankYang0529 commented on code in PR #19425: URL: https://github.com/apache/kafka/pull/19425#discussion_r2037183291 ## streams/integration-tests/src/test/java/org/apache/kafka/streams/integration/utils/EmbeddedKafkaCluster.java: ## @@ -140,6 +140,19 @@ public EmbeddedKafkaClust

Re: [PR] KAFKA-19119: Move ApiVersionManager/SimpleApiVersionManager to server [kafka]

2025-04-10 Thread via GitHub
FrankYang0529 commented on PR #19426: URL: https://github.com/apache/kafka/pull/19426#issuecomment-2792534955 The failed case `DefaultApiVersionManagerTest#testApiScope` can be fixed like: ```scala @ParameterizedTest @EnumSource(classOf[ListenerType]) def testApiScope(a

Re: [PR] KAFKA-18170: Add create and write timestamp fields in share snapshot [1/N] [kafka]

2025-04-10 Thread via GitHub
AndrewJSchofield commented on code in PR #19432: URL: https://github.com/apache/kafka/pull/19432#discussion_r2037227861 ## share-coordinator/src/main/java/org/apache/kafka/coordinator/share/ShareGroupOffset.java: ## @@ -81,42 +98,63 @@ private static PersisterStateBatch toPersi

Re: [PR] KAFKA-18983 Ensure all README.md(s) are mentioned by the root README.md [kafka]

2025-04-10 Thread via GitHub
frankvicky commented on code in PR #19420: URL: https://github.com/apache/kafka/pull/19420#discussion_r2036739225 ## docker/README.md: ## @@ -27,11 +27,11 @@ Building image and running tests using github actions - This is the recommended way to build, test and get a CVE report

Re: [PR] KAFKA-16729: Support isolation level for share consumer [kafka]

2025-04-10 Thread via GitHub
AndrewJSchofield merged PR #19261: URL: https://github.com/apache/kafka/pull/19261 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafk

[jira] [Resolved] (KAFKA-16729) Support for read-committed isolation level

2025-04-10 Thread Andrew Schofield (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16729?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Schofield resolved KAFKA-16729. -- Fix Version/s: 4.1.0 Resolution: Fixed > Support for read-committed isolation l

Re: [PR] KAFKA-19115: Utilize initialized topics info to verify delete share group offsets [kafka]

2025-04-10 Thread via GitHub
smjn commented on code in PR #19431: URL: https://github.com/apache/kafka/pull/19431#discussion_r2036837458 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorService.java: ## @@ -1248,29 +1248,118 @@ private CompletableFuture> persisterDelete

Re: [PR] KAFKA-19115: Utilize initialized topics info to verify delete share group offsets [kafka]

2025-04-10 Thread via GitHub
smjn commented on code in PR #19431: URL: https://github.com/apache/kafka/pull/19431#discussion_r2036835235 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorService.java: ## @@ -1248,29 +1248,118 @@ private CompletableFuture> persisterDelete

Re: [PR] KAFKA-19115: Utilize initialized topics info to verify delete share group offsets [kafka]

2025-04-10 Thread via GitHub
smjn commented on code in PR #19431: URL: https://github.com/apache/kafka/pull/19431#discussion_r2036832379 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorService.java: ## @@ -1248,29 +1248,118 @@ private CompletableFuture> persisterDelete

Re: [PR] KAFKA-19115: Utilize initialized topics info to verify delete share group offsets [kafka]

2025-04-10 Thread via GitHub
smjn commented on code in PR #19431: URL: https://github.com/apache/kafka/pull/19431#discussion_r2036835235 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorService.java: ## @@ -1248,29 +1248,118 @@ private CompletableFuture> persisterDelete

Re: [PR] KAFKA-18983 Ensure all README.md(s) are mentioned by the root README.md [kafka]

2025-04-10 Thread via GitHub
johnny94 commented on code in PR #19420: URL: https://github.com/apache/kafka/pull/19420#discussion_r2036843945 ## docker/README.md: ## @@ -27,11 +27,11 @@ Building image and running tests using github actions - This is the recommended way to build, test and get a CVE report fo

[jira] [Resolved] (KAFKA-18287) Add support for kafka-streams-groups.sh --list

2025-04-10 Thread Alieh Saeedi (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18287?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alieh Saeedi resolved KAFKA-18287. -- Resolution: Fixed https://github.com/apache/kafka/pull/19422 > Add support for kafka-streams-

[PR] KAFKA-18288: Add support kafka-streams-groups.sh --describe [kafka]

2025-04-10 Thread via GitHub
aliehsaeedii opened a new pull request, #19433: URL: https://github.com/apache/kafka/pull/19433 Implement `--describe` and its options: (`--state`, -`-offset`, `--members` and the combination of them with `--verbose`) as described in `KIP-1071`. -- This is an automated message from th

[jira] (KAFKA-18287) Add support for kafka-streams-groups.sh --list

2025-04-10 Thread Alieh Saeedi (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18287 ] Alieh Saeedi deleted comment on KAFKA-18287: -- was (Author: JIRAUSER298811): https://github.com/apache/kafka/pull/19422 > Add support for kafka-streams-groups.sh --list > ---

Re: [PR] MINOR: Small cleanups in server's tests [kafka]

2025-04-10 Thread via GitHub
mimaison commented on code in PR #19395: URL: https://github.com/apache/kafka/pull/19395#discussion_r2032004110 ## server/src/test/java/org/apache/kafka/network/SocketServerConfigsTest.java: ## @@ -22,8 +22,8 @@ import org.junit.jupiter.api.Test; -import java.util.Arrays;

Re: [PR] KAFKA-19037: Integrate consumer-side code with Streams [kafka]

2025-04-10 Thread via GitHub
cadonna merged PR #19377: URL: https://github.com/apache/kafka/pull/19377 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

Re: [PR] KAFKA-19057: Stabilize KIP-932 RPCs for AK 4.1 [kafka]

2025-04-10 Thread via GitHub
apoorvmittal10 commented on code in PR #19378: URL: https://github.com/apache/kafka/pull/19378#discussion_r2037943935 ## clients/src/main/resources/common/message/ShareAcknowledgeResponse.json: ## @@ -17,7 +17,10 @@ "apiKey": 79, "type": "response", "name": "ShareAcknow

[jira] [Updated] (KAFKA-19108) Consider improving the UI when describing static voters

2025-04-10 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-19108?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] José Armando García Sancio updated KAFKA-19108: --- Priority: Minor (was: Major) > Consider improving the UI when descr

Re: [PR] KAFKA-18894: Add KIP-877 support for ConfigProvider [kafka]

2025-04-10 Thread via GitHub
m1a2st commented on code in PR #19397: URL: https://github.com/apache/kafka/pull/19397#discussion_r2033053426 ## connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorMakerConfig.java: ## @@ -269,18 +270,19 @@ List configProviders() { Map transform(Map props) {

Re: [PR] KAFKA-10551: Add topic id support to produce request and response [kafka]

2025-04-10 Thread via GitHub
OmniaGM commented on code in PR #15968: URL: https://github.com/apache/kafka/pull/15968#discussion_r2035281152 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -390,57 +390,72 @@ class KafkaApis(val requestChannel: RequestChannel, } } -val unauthorize

Re: [PR] KAFKA-19093: Change the "Handler on Broker" to "Handler on Controller" for controller server [kafka]

2025-04-10 Thread via GitHub
chia7712 commented on code in PR #19384: URL: https://github.com/apache/kafka/pull/19384#discussion_r2032855809 ## core/src/main/scala/kafka/server/KafkaRequestHandler.scala: ## @@ -208,7 +208,7 @@ class KafkaRequestHandlerPool( /* a meter to track the average free capacity o

Re: [PR] KAFKA-19057: Stabilize KIP-932 RPCs for AK 4.1 [kafka]

2025-04-10 Thread via GitHub
apoorvmittal10 commented on code in PR #19378: URL: https://github.com/apache/kafka/pull/19378#discussion_r2037973763 ## clients/src/main/resources/common/message/ShareAcknowledgeResponse.json: ## @@ -17,7 +17,10 @@ "apiKey": 79, "type": "response", "name": "ShareAcknow

[jira] [Created] (KAFKA-19117) Client Throttling Log messages should be of log level - WARN

2025-04-10 Thread Ravi Kalasapur (Jira)
Ravi Kalasapur created KAFKA-19117: -- Summary: Client Throttling Log messages should be of log level - WARN Key: KAFKA-19117 URL: https://issues.apache.org/jira/browse/KAFKA-19117 Project: Kafka

Re: [PR] KAFKA-19057: Stabilize KIP-932 RPCs for AK 4.1 [kafka]

2025-04-10 Thread via GitHub
apoorvmittal10 commented on code in PR #19378: URL: https://github.com/apache/kafka/pull/19378#discussion_r2037943935 ## clients/src/main/resources/common/message/ShareAcknowledgeResponse.json: ## @@ -17,7 +17,10 @@ "apiKey": 79, "type": "response", "name": "ShareAcknow

Re: [PR] KAFKA-19057: Stabilize KIP-932 RPCs for AK 4.1 [kafka]

2025-04-10 Thread via GitHub
apoorvmittal10 commented on code in PR #19378: URL: https://github.com/apache/kafka/pull/19378#discussion_r2037944799 ## clients/src/main/resources/common/message/ShareFetchRequest.json: ## @@ -48,6 +47,8 @@ "about": "The partitions to fetch.", "fields": [ { "n

Re: [PR] KAFKA-19115: Utilize initialized topics info to verify delete share group offsets [kafka]

2025-04-10 Thread via GitHub
smjn commented on code in PR #19431: URL: https://github.com/apache/kafka/pull/19431#discussion_r2036832379 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorService.java: ## @@ -1248,29 +1248,118 @@ private CompletableFuture> persisterDelete

Re: [PR] KAFKA-19057: Stabilize KIP-932 RPCs for AK 4.1 [kafka]

2025-04-10 Thread via GitHub
apoorvmittal10 commented on code in PR #19378: URL: https://github.com/apache/kafka/pull/19378#discussion_r2037892822 ## clients/src/main/resources/common/message/ShareFetchRequest.json: ## @@ -48,6 +47,8 @@ "about": "The partitions to fetch.", "fields": [ { "n

[jira] [Assigned] (KAFKA-19121) Move AddPartitionsToTxnConfig, TransactionStateManagerConfig, and QuorumConfig out of KafkaConfig

2025-04-10 Thread PoAn Yang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19121?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] PoAn Yang reassigned KAFKA-19121: - Assignee: PoAn Yang (was: Chia-Ping Tsai) > Move AddPartitionsToTxnConfig, TransactionStateMan

Re: [PR] MINOR: Rename RemoteLogStorageManager variable to RemoteStorageManager [kafka]

2025-04-10 Thread via GitHub
chia7712 merged PR #19401: URL: https://github.com/apache/kafka/pull/19401 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[jira] [Created] (KAFKA-19108) Consider improving the UI when describing static voters

2025-04-10 Thread Jira
José Armando García Sancio created KAFKA-19108: -- Summary: Consider improving the UI when describing static voters Key: KAFKA-19108 URL: https://issues.apache.org/jira/browse/KAFKA-19108 Pr

Re: [PR] KAFKA-14485: Move LogCleaner to storage module [kafka]

2025-04-10 Thread via GitHub
wernerdv commented on code in PR #19387: URL: https://github.com/apache/kafka/pull/19387#discussion_r2032560885 ## storage/src/main/java/org/apache/kafka/storage/internals/log/CleanedTransactionMetadata.java: ## @@ -0,0 +1,160 @@ +/* + * Licensed to the Apache Software Foundatio

Re: [PR] KAFKA-18891: KIP-877 add support for RemoteLogMetadataManager and RemoteStorageManager [kafka]

2025-04-10 Thread via GitHub
TaiJuWu commented on code in PR #19286: URL: https://github.com/apache/kafka/pull/19286#discussion_r2037597964 ## server/src/test/java/org/apache/kafka/server/MonitorablePluginsIntegrationTest.java: ## @@ -0,0 +1,116 @@ +/* + * Licensed to the Apache Software Foundation (ASF) un

Re: [PR] KAFKA-19057: Stabilize KIP-932 RPCs for AK 4.1 [kafka]

2025-04-10 Thread via GitHub
AndrewJSchofield commented on code in PR #19378: URL: https://github.com/apache/kafka/pull/19378#discussion_r2037929838 ## clients/src/main/resources/common/message/ShareFetchRequest.json: ## @@ -48,6 +47,8 @@ "about": "The partitions to fetch.", "fields": [ {

Re: [PR] KAFKA-17541:[1/2] Improve handling of delivery count [kafka]

2025-04-10 Thread via GitHub
AndrewJSchofield commented on PR #19430: URL: https://github.com/apache/kafka/pull/19430#issuecomment-2794085366 @DL1231 Looks like a compile failure. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] KAFKA-19057: Stabilize KIP-932 RPCs for AK 4.1 [kafka]

2025-04-10 Thread via GitHub
AndrewJSchofield commented on code in PR #19378: URL: https://github.com/apache/kafka/pull/19378#discussion_r2037938413 ## clients/src/main/resources/common/message/ShareAcknowledgeResponse.json: ## @@ -17,7 +17,10 @@ "apiKey": 79, "type": "response", "name": "ShareAckn

[jira] [Created] (KAFKA-19111) Remove ModernGroup#computeSubscriptionMetadata unused parameter

2025-04-10 Thread Jira
黃竣陽 created KAFKA-19111: --- Summary: Remove ModernGroup#computeSubscriptionMetadata unused parameter Key: KAFKA-19111 URL: https://issues.apache.org/jira/browse/KAFKA-19111 Project: Kafka Issue Type: Im

Re: [PR] KAFKA-14485: Move LogCleaner to storage module [kafka]

2025-04-10 Thread via GitHub
wernerdv commented on code in PR #19387: URL: https://github.com/apache/kafka/pull/19387#discussion_r2034777548 ## storage/src/main/java/org/apache/kafka/storage/internals/log/Cleaner.java: ## @@ -0,0 +1,762 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one o

Re: [PR] [WIP]KAFKA-19080 The constraint on segment.ms is not enforced at topic level [kafka]

2025-04-10 Thread via GitHub
junrao commented on PR #19371: URL: https://github.com/apache/kafka/pull/19371#issuecomment-2787910437 @m1a2st : Perhaps we could somehow allow the tests to set a small `segment.bytes`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on t

Re: [PR] KAFKA-10551: Add topic id support to produce request and response [kafka]

2025-04-10 Thread via GitHub
junrao commented on code in PR #15968: URL: https://github.com/apache/kafka/pull/15968#discussion_r2032049630 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -108,7 +108,7 @@ class KafkaApis(val requestChannel: RequestChannel, val groupConfigManager:

Re: [PR] KAFKA-18888: Add KIP-877 support to Authorizer [kafka]

2025-04-10 Thread via GitHub
mimaison commented on code in PR #19050: URL: https://github.com/apache/kafka/pull/19050#discussion_r2031382775 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -3284,7 +3285,7 @@ private boolean maybeUpdateRegularExpressions

Re: [PR] KAFKA-16894: Define feature to enable share groups [kafka]

2025-04-10 Thread via GitHub
junrao commented on code in PR #19293: URL: https://github.com/apache/kafka/pull/19293#discussion_r2037984758 ## core/src/test/scala/unit/kafka/server/AbstractApiVersionsRequestTest.scala: ## @@ -85,6 +85,9 @@ abstract class AbstractApiVersionsRequestTest(cluster: ClusterInstan

[jira] [Updated] (KAFKA-19126) Duplicate offsets written to log for different messages

2025-04-10 Thread Adrian C. (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian C. updated KAFKA-19126: -- Description: We have observed during normal operations that messages/batches can be written to disk w

  1   2   >