AndrewJSchofield commented on code in PR #19378: URL: https://github.com/apache/kafka/pull/19378#discussion_r2037938413
########## clients/src/main/resources/common/message/ShareAcknowledgeResponse.json: ########## @@ -17,7 +17,10 @@ "apiKey": 79, "type": "response", "name": "ShareAcknowledgeResponse", - "validVersions": "0", + // Version 0 was used for early access of KIP-932 in Apache Kafka 4.0 but removed in Apacke Kafka 4.1. + // + // Version 1 is the initial stable version (KIP-932). + "validVersions": "1", "flexibleVersions": "0+", Review Comment: I think it's permissible for flexible versions to be broader than valid versions (see `EvolutionVerifierTest`). I can do some more digging, but it doesn't seem wrong to me at this point. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
