AndrewJSchofield commented on code in PR #19378: URL: https://github.com/apache/kafka/pull/19378#discussion_r2037371932
########## clients/src/main/resources/common/message/ShareAcknowledgeRequest.json: ########## @@ -18,34 +18,33 @@ "type": "request", "listeners": ["broker"], "name": "ShareAcknowledgeRequest", - "validVersions": "0", - "flexibleVersions": "0+", - // The ShareAcknowledgeRequest API is added as part of KIP-932 and is still under - // development. Hence, the API is not exposed by default by brokers unless - // explicitly enabled. - "latestVersionUnstable": true, + // Version 0 was used for early access of KIP-932 in Apache Kafka 4.0 but removed in Apacke Kafka 4.1. + // + // Version 1 is the initial stable version (KIP-932). + "validVersions": "1", Review Comment: I just went for a clean break at "1" rather than trying to document the original "0" versions as well. For ShareFetchRequest in particular, things have move a bit between 4.0 and 4.1. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
