AndrewJSchofield commented on code in PR #19432:
URL: https://github.com/apache/kafka/pull/19432#discussion_r2037227861
##########
share-coordinator/src/main/java/org/apache/kafka/coordinator/share/ShareGroupOffset.java:
##########
@@ -81,42 +98,63 @@ private static PersisterStateBatch
toPersisterOffsetsStateBatch(ShareUpdateValue
}
public static ShareGroupOffset fromRecord(ShareSnapshotValue record) {
- return new ShareGroupOffset(record.snapshotEpoch(),
record.stateEpoch(), record.leaderEpoch(), record.startOffset(),
record.stateBatches().stream()
-
.map(ShareGroupOffset::toPersisterOffsetsStateBatch).collect(Collectors.toList()));
+ return new ShareGroupOffset(
+ record.snapshotEpoch(),
+ record.stateEpoch(),
+ record.leaderEpoch(),
+ record.startOffset(),
+ record.stateBatches().stream()
+ .map(ShareGroupOffset::toPersisterOffsetsStateBatch)
+ .toList(),
+ record.createTimestamp(),
+ record.writeTimestamp()
+ );
}
public static ShareGroupOffset fromRecord(ShareUpdateValue record) {
- return new ShareGroupOffset(record.snapshotEpoch(), -1,
record.leaderEpoch(), record.startOffset(), record.stateBatches().stream()
-
.map(ShareGroupOffset::toPersisterOffsetsStateBatch).collect(Collectors.toList()));
+ return new ShareGroupOffset(
+ record.snapshotEpoch(),
+ -1, record.leaderEpoch(),
Review Comment:
nit: I think the `-1,` probably ought to be by itself on a line to match the
rest of the formatting.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
