apoorvmittal10 commented on code in PR #19378: URL: https://github.com/apache/kafka/pull/19378#discussion_r2037882487
########## clients/src/main/resources/common/message/ShareAcknowledgeResponse.json: ########## @@ -17,7 +17,10 @@ "apiKey": 79, "type": "response", "name": "ShareAcknowledgeResponse", - "validVersions": "0", + // Version 0 was used for early access of KIP-932 in Apache Kafka 4.0 but removed in Apacke Kafka 4.1. + // + // Version 1 is the initial stable version (KIP-932). + "validVersions": "1", "flexibleVersions": "0+", Review Comment: Should this be 1+ as well. Will this condition fail: https://github.com/apache/kafka/blob/c65a161cd8b4ef0bbc370be735a6d1dd9b413381/generator/src/main/java/org/apache/kafka/message/checker/EvolutionVerifier.java#L53? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
