mumrah commented on PR #19049:
URL: https://github.com/apache/kafka/pull/19049#issuecomment-2701360104
@chia7712 I'm just excited this many people care about the build 😆
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
mingdaoy opened a new pull request, #19119:
URL: https://github.com/apache/kafka/pull/19119
https://github.com/apache/kafka/pull/19097#discussion_r1981526593
Result:
--
This is an autom
chia7712 commented on PR #19049:
URL: https://github.com/apache/kafka/pull/19049#issuecomment-2701357088
there are so many people are working on it :)
@mumrah reverts the code
(https://github.com/apache/kafka/commit/d86cb597902d32ce83f27d65b60df6700cb7a61d)
@aliehsaeedii files #191
mumrah commented on PR #19049:
URL: https://github.com/apache/kafka/pull/19049#issuecomment-2701358555
@aliehsaeedii can you please file a new PR with your changes? Our CI didn't
run for the this PR, so we'll need a new one.
--
This is an automated message from the Apache Git Service.
To
m1a2st commented on PR #19115:
URL: https://github.com/apache/kafka/pull/19115#issuecomment-2701357282
It seems @mumrah revert that commit,
https://github.com/apache/kafka/commit/017692e86c5e40402312ebdb4bdab82face30181.
--
This is an automated message from the Apache Git Service.
To re
mingdaoy commented on code in PR #19097:
URL: https://github.com/apache/kafka/pull/19097#discussion_r1981698752
##
docs/upgrade.html:
##
@@ -46,6 +46,9 @@ Upgrading to
4.0.0 from any vers
Every https://github.com/apache/kafka/blob/trunk/server-common/src/main/java/org/
mumrah commented on PR #19119:
URL: https://github.com/apache/kafka/pull/19119#issuecomment-2701364462
@mingdaoy please update your PR with trunk, you likely have a broken commit
in your history (which we just reverted).
--
This is an automated message from the Apache Git Service.
To resp
mumrah commented on PR #19115:
URL: https://github.com/apache/kafka/pull/19115#issuecomment-2701370188
Thanks for the prompt attention to this @m1a2st! I ended up reverting since
the CI didn't run at all. If it was just a javadoc breakage, I would be fine
with a hotfix like this.
--
This
m1a2st closed pull request #19115: HOTFIX client java doc compile error
URL: https://github.com/apache/kafka/pull/19115
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsub
chia7712 commented on code in PR #18299:
URL: https://github.com/apache/kafka/pull/18299#discussion_r1981708674
##
committer-tools/verify_license.py:
##
@@ -74,12 +75,20 @@ def get_license_deps(license_text):
return set(LICENSE_DEP_PATTERN.findall(license_text))
def main
lucasbru commented on PR #19030:
URL: https://github.com/apache/kafka/pull/19030#issuecomment-2701372613
@mimaison The broken commit was reverted on trunk, sorry for that. For some
reason CI didn't run and I didn't notice.
--
This is an automated message from the Apache Git Service.
To re
mimaison commented on PR #19030:
URL: https://github.com/apache/kafka/pull/19030#issuecomment-2701378571
No worries this happens :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific co
mumrah commented on code in PR #18299:
URL: https://github.com/apache/kafka/pull/18299#discussion_r1981718530
##
committer-tools/verify_license.py:
##
@@ -74,12 +75,20 @@ def get_license_deps(license_text):
return set(LICENSE_DEP_PATTERN.findall(license_text))
def main()
chia7712 commented on PR #19107:
URL: https://github.com/apache/kafka/pull/19107#issuecomment-2701386610
@mingdaoy could you please tweak the title? maybe "MINOR: improve the
example of kafka-metadata-shell.sh"?
--
This is an automated message from the Apache Git Service.
To respond to th
aliehsaeedii opened a new pull request, #19120:
URL: https://github.com/apache/kafka/pull/19120
https://issues.apache.org/jira/browse/KAFKA-18887
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
[
https://issues.apache.org/jira/browse/KAFKA-18919?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai resolved KAFKA-18919.
Resolution: Fixed
trunk:
https://github.com/apache/kafka/commit/6ecf6817ad3fcfc91f3d35caa
appchemist commented on PR #18800:
URL: https://github.com/apache/kafka/pull/18800#issuecomment-2701011822
@mjsax kindly ping
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
FrankYang0529 commented on PR #18258:
URL: https://github.com/apache/kafka/pull/18258#issuecomment-2701078180
Hi @mjsax, thanks for the comment. Not sure whether KS version 2.3.x is
typo. From
[KIP-1124](https://cwiki.apache.org/confluence/display/KAFKA/KIP-1124%3A+Providing+a+clear+Kafka+C
lucasbru commented on code in PR #19114:
URL: https://github.com/apache/kafka/pull/19114#discussion_r1981494265
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -7160,6 +7881,34 @@ private int shareGroupHeartbeatIntervalMs(St
mingdaoy commented on code in PR #19107:
URL: https://github.com/apache/kafka/pull/19107#discussion_r1981564521
##
docs/ops.html:
##
@@ -3965,7 +3965,7 @@ The kafka-metadata-shell.sh tool can be used to interactively inspect the
state of the cluster metadata partition:
- $ b
m1a2st opened a new pull request, #19115:
URL: https://github.com/apache/kafka/pull/19115
HOTFIX client java doc compile error
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment
[
https://issues.apache.org/jira/browse/KAFKA-18919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17932672#comment-17932672
]
Ismael Juma commented on KAFKA-18919:
-
Why would we document it versus having `Kafka
[
https://issues.apache.org/jira/browse/KAFKA-18910?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
黃竣陽 updated KAFKA-18910:
Summary: Romve kafka.utils.json (was: Move kafka.utils.json to
server-common module)
> Romve kafka.utils.json
m1a2st commented on PR #19115:
URL: https://github.com/apache/kafka/pull/19115#issuecomment-2701239907
```
~/java_workspace/kafka$ ./gradlew :clients:javadoc
> Configure project :
Starting build with version 4.1.0-SNAPSHOT (commit id b974bba0) using Gradle
8.10.2, Java 17 and Sc
chia7712 commented on code in PR #19115:
URL: https://github.com/apache/kafka/pull/19115#discussion_r1981619097
##
clients/src/main/java/org/apache/kafka/clients/admin/AlterStreamsGroupOffsetsOptions.java:
##
@@ -20,7 +20,7 @@
/**
- * Options for the {@link Admin#alterStrea
[
https://issues.apache.org/jira/browse/KAFKA-18925?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lucas Brutschy reassigned KAFKA-18925:
--
Assignee: Lucas Brutschy
> Add streams groups support in `Admin.listGroups`.
> --
Lucas Brutschy created KAFKA-18925:
--
Summary: Add streams groups support in `Admin.listGroups`.
Key: KAFKA-18925
URL: https://issues.apache.org/jira/browse/KAFKA-18925
Project: Kafka
Issue T
AndrewJSchofield commented on code in PR #18976:
URL: https://github.com/apache/kafka/pull/18976#discussion_r1981601768
##
clients/src/test/java/org/apache/kafka/clients/admin/KafkaAdminClientTest.java:
##
@@ -9439,4 +9443,106 @@ public void
testAlterShareGroupOffsetsWithErrorI
[
https://issues.apache.org/jira/browse/KAFKA-18925?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lucas Brutschy updated KAFKA-18925:
---
Summary: Add streams groups support in Admin.listGroups. (was: Add streams
groups support i
[
https://issues.apache.org/jira/browse/KAFKA-18887?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lucas Brutschy resolved KAFKA-18887.
Resolution: Fixed
> Implement Admin API extensions beyond list/describe group (delete grou
lucasbru opened a new pull request, #19116:
URL: https://github.com/apache/kafka/pull/19116
Adds `describeStreamsGroup` to Admin API.
This exposes the result of the `DESCRIBE_STREAMS_GROUP` RPC in the Admin API.
--
This is an automated message from the Apache Git Service.
To respond
mingdaoy commented on code in PR #19107:
URL: https://github.com/apache/kafka/pull/19107#discussion_r1981564521
##
docs/ops.html:
##
@@ -3965,7 +3965,7 @@ The kafka-metadata-shell.sh tool can be used to interactively inspect the
state of the cluster metadata partition:
- $ b
mumrah commented on code in PR #18299:
URL: https://github.com/apache/kafka/pull/18299#discussion_r1981634646
##
committer-tools/verify_license.py:
##
@@ -74,12 +75,20 @@ def get_license_deps(license_text):
return set(LICENSE_DEP_PATTERN.findall(license_text))
def main()
mimaison commented on PR #19030:
URL: https://github.com/apache/kafka/pull/19030#issuecomment-2701304492
The CI failure is caused by an issue in trunk, there's a PR to fix it:
https://github.com/apache/kafka/pull/19115
I'll rekick the CI, once #19115 is merged.
--
This is an automa
chia7712 commented on PR #19103:
URL: https://github.com/apache/kafka/pull/19103#issuecomment-2700303106
Sorry for late review.
Could we avoid using ? It might mislead users to use the
bootstrap snapshot file `-00.checkpoint`.
Addition
[
https://issues.apache.org/jira/browse/KAFKA-15371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17932559#comment-17932559
]
Chia-Ping Tsai commented on KAFKA-15371:
the metadata shell is used to read snap
m1a2st commented on code in PR #19104:
URL: https://github.com/apache/kafka/pull/19104#discussion_r1980945000
##
clients/src/main/java/org/apache/kafka/common/config/internals/BrokerSecurityConfigs.java:
##
@@ -79,7 +79,9 @@ public class BrokerSecurityConfigs {
"nam
chia7712 commented on code in PR #18299:
URL: https://github.com/apache/kafka/pull/18299#discussion_r1981005687
##
committer-tools/verify_license.py:
##
@@ -74,12 +75,20 @@ def get_license_deps(license_text):
return set(LICENSE_DEP_PATTERN.findall(license_text))
def main
frankvicky commented on code in PR #17614:
URL: https://github.com/apache/kafka/pull/17614#discussion_r1981011690
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##
@@ -427,7 +428,7 @@ public void onGroupAssignmentUpdated(Set
partit
lucasbru commented on code in PR #19049:
URL: https://github.com/apache/kafka/pull/19049#discussion_r1981138435
##
clients/src/main/java/org/apache/kafka/clients/admin/ListStreamsGroupOffsetsResult.java:
##
@@ -0,0 +1,75 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF
dengziming opened a new pull request, #19109:
URL: https://github.com/apache/kafka/pull/19109
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e
dajac merged PR #19103:
URL: https://github.com/apache/kafka/pull/19103
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or
FrankYang0529 opened a new pull request, #19111:
URL: https://github.com/apache/kafka/pull/19111
Close `InputStream` from `RemoteStorageManager#fetchIndex`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
dengziming opened a new pull request, #19110:
URL: https://github.com/apache/kafka/pull/19110
1. Convert ControRecordType schema to use auto-generated
protocol`ControRecordTypeSchema`
2. Substitute `CURRENT_CONTROL_RECORD_KEY_SIZE` with`controlRecordKeySize()`
method since the size is ac
chia7712 merged PR #19054:
URL: https://github.com/apache/kafka/pull/19054
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
[
https://issues.apache.org/jira/browse/KAFKA-18882?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai updated KAFKA-18882:
---
Summary: Remove BaseKey, TxnKey, and UnknownKey (was: Move BaseKey,
TxnKey, and UnknownKey
[
https://issues.apache.org/jira/browse/KAFKA-18422?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Jacot updated KAFKA-18422:
Fix Version/s: (was: 4.0.0)
> add Kafka client upgrade path
> -
>
[
https://issues.apache.org/jira/browse/KAFKA-18074?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Jacot updated KAFKA-18074:
Fix Version/s: (was: 4.0.0)
> Add kafka client compatibility matrix
>
AndrewJSchofield opened a new pull request, #19113:
URL: https://github.com/apache/kafka/pull/19113
User testing of the `KafkaShareConsumer` interface has revealed some areas
which confuse people. One of these is that way that it decides whether you want
to use implicit or explicit acknowle
lucasbru commented on code in PR #19114:
URL: https://github.com/apache/kafka/pull/19114#discussion_r1981489149
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/streams/StreamsGroupBuilder.java:
##
@@ -97,7 +99,7 @@ public List build() {
gro
lucasbru commented on code in PR #19114:
URL: https://github.com/apache/kafka/pull/19114#discussion_r1981491718
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/streams/StreamsGroup.java:
##
@@ -355,6 +355,32 @@ public StreamsGroupMember getOrMaybeCreateMemb
ijuma commented on code in PR #19097:
URL: https://github.com/apache/kafka/pull/19097#discussion_r1981526593
##
docs/upgrade.html:
##
@@ -46,6 +46,9 @@ Upgrading to
4.0.0 from any vers
Every https://github.com/apache/kafka/blob/trunk/server-common/src/main/java/org/apa
lucasbru commented on PR #19049:
URL: https://github.com/apache/kafka/pull/19049#issuecomment-2701110816
LGTM, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To un
lucasbru merged PR #19049:
URL: https://github.com/apache/kafka/pull/19049
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
ijuma commented on code in PR #19097:
URL: https://github.com/apache/kafka/pull/19097#discussion_r1981529249
##
docs/upgrade.html:
##
@@ -46,6 +46,9 @@ Upgrading to
4.0.0 from any vers
Every https://github.com/apache/kafka/blob/trunk/server-common/src/main/java/org/apa
AndrewJSchofield merged PR #19057:
URL: https://github.com/apache/kafka/pull/19057
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafk
[
https://issues.apache.org/jira/browse/KAFKA-18919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17932675#comment-17932675
]
Chia-Ping Tsai commented on KAFKA-18919:
{quote}
Why would we document it versus
mimaison commented on code in PR #19030:
URL: https://github.com/apache/kafka/pull/19030#discussion_r1981604968
##
storage/src/main/java/org/apache/kafka/storage/internals/log/UnifiedLog.java:
##
@@ -55,6 +113,2289 @@ public class UnifiedLog {
public static final String STR
lucasbru opened a new pull request, #19117:
URL: https://github.com/apache/kafka/pull/19117
Seems like
[017692e](https://github.com/apache/kafka/commit/017692e86c5e40402312ebdb4bdab82face30181)
broke trunk, despite just having green checkmarks. This should fix it
--
This is an automa
[
https://issues.apache.org/jira/browse/KAFKA-18919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17932677#comment-17932677
]
Ismael Juma commented on KAFKA-18919:
-
Not sure if it's a breaking change. It only a
lucasbru closed pull request #19117: MINOR: admin client javadoc hotfix
URL: https://github.com/apache/kafka/pull/19117
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsub
chia7712 commented on PR #19117:
URL: https://github.com/apache/kafka/pull/19117#issuecomment-2701339197
hi @lucasbru could you please take a look at #19115? The CI is running and I
will merge it after "build" pass.
--
This is an automated message from the Apache Git Service.
To respond t
lucasbru commented on PR #19117:
URL: https://github.com/apache/kafka/pull/19117#issuecomment-2701342472
Already covered by https://github.com/apache/kafka/pull/19115
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
kevin-wu24 commented on code in PR #18987:
URL: https://github.com/apache/kafka/pull/18987#discussion_r1981774312
##
raft/src/test/java/org/apache/kafka/raft/RaftEventSimulationTest.java:
##
@@ -297,18 +309,83 @@ void canMakeProgressIfMajorityIsReachable(
scheduler.runU
[
https://issues.apache.org/jira/browse/KAFKA-14121?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kuan Po Tseng updated KAFKA-14121:
--
Fix Version/s: 4.1.0
> AlterPartitionReassignments API should allow callers to specify the opt
[
https://issues.apache.org/jira/browse/KAFKA-14121?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kuan Po Tseng reassigned KAFKA-14121:
-
Assignee: Kuan Po Tseng (was: Stanislav Kozlovski)
> AlterPartitionReassignments API s
[
https://issues.apache.org/jira/browse/KAFKA-14121?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kuan Po Tseng resolved KAFKA-14121.
---
Resolution: Fixed
> AlterPartitionReassignments API should allow callers to specify the opti
mingdaoy commented on code in PR #19107:
URL: https://github.com/apache/kafka/pull/19107#discussion_r1981782595
##
docs/ops.html:
##
@@ -3983,7 +3983,7 @@
-
+ Note: -00.checkpoint does not contain cluster
metadata. Use a valid snapshot file when ex
lucasbru closed pull request #19118: MINOR: Fix java docs
URL: https://github.com/apache/kafka/pull/19118
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail
brandboat commented on PR #18983:
URL: https://github.com/apache/kafka/pull/18983#issuecomment-2701492450
> I will also let you resolve the JIRA appropriately and move the KIP to the
correct section + update the Kafka version in which it will be going out!
Thank you for merging this P
ahuang98 commented on code in PR #18600:
URL: https://github.com/apache/kafka/pull/18600#discussion_r1982108615
##
raft/src/test/java/org/apache/kafka/raft/KafkaRaftClientSnapshotTest.java:
##
@@ -795,21 +800,20 @@ public void testFetchSnapshotRequestAsLeader(boolean
withKip853
[
https://issues.apache.org/jira/browse/KAFKA-18054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17932736#comment-17932736
]
Lorcan commented on KAFKA-18054:
Hi [~ableegoldman], I’ve done some investigation into t
cherylws opened a new pull request, #19125:
URL: https://github.com/apache/kafka/pull/19125
- Adding a space, article and punctuation to the doc strings for consistency
and readability.
If you would like to tag individuals, add some commentary, upload images, or
include other suppl
mingdaoy commented on code in PR #19082:
URL: https://github.com/apache/kafka/pull/19082#discussion_r1982214194
##
metadata/src/main/java/org/apache/kafka/metadata/storage/ScramParser.java:
##
@@ -173,7 +173,8 @@ byte[] saltedPassword(byte[] salt, int iterations) throws
Excepti
mingdaoy commented on code in PR #19082:
URL: https://github.com/apache/kafka/pull/19082#discussion_r198021
##
clients/src/main/java/org/apache/kafka/common/security/scram/internals/ScramSaslClient.java:
##
@@ -190,7 +190,7 @@ private void setState(State state) {
priv
mingdaoy commented on code in PR #19082:
URL: https://github.com/apache/kafka/pull/19082#discussion_r1982210800
##
clients/src/main/java/org/apache/kafka/common/security/scram/internals/ScramSaslClient.java:
##
@@ -190,7 +190,7 @@ private void setState(State state) {
priv
mumrah merged PR #19126:
URL: https://github.com/apache/kafka/pull/19126
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.o
ableegoldman commented on PR #19089:
URL: https://github.com/apache/kafka/pull/19089#issuecomment-2702232938
ah, good catch, and thanks for the fix!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
[
https://issues.apache.org/jira/browse/KAFKA-18067?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
A. Sophie Blee-Goldman updated KAFKA-18067:
---
Fix Version/s: 4.1.0
> Kafka Streams can leak Producer client under EOS
> --
ahuang98 commented on code in PR #18987:
URL: https://github.com/apache/kafka/pull/18987#discussion_r1982287669
##
raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java:
##
@@ -3637,6 +3637,11 @@ QuorumState quorum() {
return quorum;
}
+// Visible onl
ahuang98 commented on code in PR #18987:
URL: https://github.com/apache/kafka/pull/18987#discussion_r1982280759
##
raft/src/test/java/org/apache/kafka/raft/RaftEventSimulationTest.java:
##
@@ -550,14 +576,17 @@ void canAddObserverAndRemovePartitionedVoter(
initializeC
kevin-wu24 commented on code in PR #18987:
URL: https://github.com/apache/kafka/pull/18987#discussion_r1982298361
##
raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java:
##
@@ -3637,6 +3637,11 @@ QuorumState quorum() {
return quorum;
}
+// Visible o
[
https://issues.apache.org/jira/browse/KAFKA-18921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17932770#comment-17932770
]
A. Sophie Blee-Goldman commented on KAFKA-18921:
[~davidarthur] is there
bbejeck commented on code in PR #19116:
URL: https://github.com/apache/kafka/pull/19116#discussion_r1982259039
##
clients/src/main/java/org/apache/kafka/clients/admin/DescribeStreamsGroupsResult.java:
##
@@ -0,0 +1,68 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) u
mumrah merged PR #19124:
URL: https://github.com/apache/kafka/pull/19124
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.o
[
https://issues.apache.org/jira/browse/KAFKA-18067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17932778#comment-17932778
]
A. Sophie Blee-Goldman commented on KAFKA-18067:
thanks for catching thi
mumrah opened a new pull request, #19126:
URL: https://github.com/apache/kafka/pull/19126
Change the `strict` value to false. Follow-up of #19124
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
mumrah opened a new pull request, #19123:
URL: https://github.com/apache/kafka/pull/19123
Just testing a new PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscri
mumrah commented on code in PR #19122:
URL: https://github.com/apache/kafka/pull/19122#discussion_r1981908712
##
.asf.yaml:
##
@@ -45,3 +45,19 @@ github:
squash_commit_message: PR_TITLE_AND_DESC
merge: false
rebase: false
+
+ protected_branches:
+trunk:
+
mumrah merged PR #19122:
URL: https://github.com/apache/kafka/pull/19122
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.o
ahuang98 commented on code in PR #18600:
URL: https://github.com/apache/kafka/pull/18600#discussion_r1982110708
##
raft/src/test/java/org/apache/kafka/raft/KafkaRaftClientSnapshotTest.java:
##
@@ -52,13 +54,19 @@
import java.util.concurrent.atomic.AtomicLong;
import java.util.
ahuang98 commented on code in PR #18600:
URL: https://github.com/apache/kafka/pull/18600#discussion_r1982108615
##
raft/src/test/java/org/apache/kafka/raft/KafkaRaftClientSnapshotTest.java:
##
@@ -795,21 +800,20 @@ public void testFetchSnapshotRequestAsLeader(boolean
withKip853
[
https://issues.apache.org/jira/browse/KAFKA-18925?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-18925:
Component/s: streams
> Add streams groups support in Admin.listGroups.
> -
ahuang98 commented on PR #18600:
URL: https://github.com/apache/kafka/pull/18600#issuecomment-2701942128
@frankvicky let me know when you need another review, I spot checked some of
the comments I left earlier that you thumbs up-ed and it seems they haven't all
been addressed yet
--
This
Iamoshione commented on PR #19077:
URL: https://github.com/apache/kafka/pull/19077#issuecomment-2702105935
@AndrewJSchofield Apologies for the oversight—I didn’t notice it on time.
I’ve now addressed the request as specified. Let me know if any further changes
are needed. Thanks!
--
This
AndrewJSchofield commented on PR #19077:
URL: https://github.com/apache/kafka/pull/19077#issuecomment-2702110906
@Iamoshione Please could you update the branch with the latest changes from
trunk. I will need a green build of up-to-date code to merge.
--
This is an automated message from t
Iamoshione commented on PR #19077:
URL: https://github.com/apache/kafka/pull/19077#issuecomment-2702116652
@AndrewJSchofield Branch updated with trunk. Please let me know if any
further changes are needed. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to
mingdaoy commented on code in PR #19082:
URL: https://github.com/apache/kafka/pull/19082#discussion_r1982214194
##
metadata/src/main/java/org/apache/kafka/metadata/storage/ScramParser.java:
##
@@ -173,7 +173,8 @@ byte[] saltedPassword(byte[] salt, int iterations) throws
Excepti
mingdaoy commented on code in PR #19082:
URL: https://github.com/apache/kafka/pull/19082#discussion_r1982216871
##
core/src/main/scala/kafka/server/DelegationTokenManager.scala:
##
@@ -100,13 +100,13 @@ class DelegationTokenManager(val config: KafkaConfig,
}
/**
- * @p
mingdaoy commented on code in PR #19082:
URL: https://github.com/apache/kafka/pull/19082#discussion_r1982207332
##
metadata/src/main/java/org/apache/kafka/metadata/storage/ScramParser.java:
##
@@ -173,7 +173,9 @@ byte[] saltedPassword(byte[] salt, int iterations) throws
Excepti
101 - 200 of 251 matches
Mail list logo
