mumrah commented on code in PR #18299:
URL: https://github.com/apache/kafka/pull/18299#discussion_r1981718530
##########
committer-tools/verify_license.py:
##########
@@ -74,12 +75,20 @@ def get_license_deps(license_text):
return set(LICENSE_DEP_PATTERN.findall(license_text))
def main():
+ # Argument parser
+ parser = argparse.ArgumentParser(description="Whether to skip executing
ReleaseTarGz.")
+ parser.add_argument('--skipReleaseTarGz', type=str, default=False,
help='Whether to skip ReleaseTarGz (true/false)')
Review Comment:
Yea that makes sense. I wasn't sure what default behavior we would want. In
that case, I'd suggest `--skip-build` :) (i like kebab-case for CLI arguments)
##########
committer-tools/verify_license.py:
##########
@@ -74,12 +75,20 @@ def get_license_deps(license_text):
return set(LICENSE_DEP_PATTERN.findall(license_text))
def main():
+ # Argument parser
+ parser = argparse.ArgumentParser(description="Whether to skip executing
ReleaseTarGz.")
+ parser.add_argument('--skipReleaseTarGz', type=str, default=False,
help='Whether to skip ReleaseTarGz (true/false)')
Review Comment:
Yea that makes sense. I wasn't sure what default behavior we would want.
In that case, I'd suggest `--skip-build` :) (i like kebab-case for CLI
arguments)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
