Re: [PR] KAFKA-17014: ScramFormatter should not use String for password [kafka]

[via GitHub]

mingdaoy commented on code in PR #19082:
URL: https://github.com/apache/kafka/pull/19082#discussion_r1982210800


##########
clients/src/main/java/org/apache/kafka/common/security/scram/internals/ScramSaslClient.java:
##########
@@ -190,7 +190,7 @@ private void setState(State state) {
 
     private ClientFinalMessage handleServerFirstMessage(char[] password) 
throws SaslException {
         try {
-            byte[] passwordBytes = ScramFormatter.normalize(new 
String(password));
+            byte[] passwordBytes = ScramFormatter.normalize(new 
String(password).toCharArray());

Review Comment:
   
![image](https://github.com/user-attachments/assets/5045337e-38f2-4e3d-84c9-82ad2861fffc)
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org