chia7712 commented on code in PR #18299:
URL: https://github.com/apache/kafka/pull/18299#discussion_r1981005687
##########
committer-tools/verify_license.py:
##########
@@ -74,12 +75,20 @@ def get_license_deps(license_text):
return set(LICENSE_DEP_PATTERN.findall(license_text))
def main():
+ # Argument parser
+ parser = argparse.ArgumentParser(description="Process some integers.")
Review Comment:
please replace `Process some integers.` by other description
##########
.github/workflows/build.yml:
##########
@@ -166,6 +166,8 @@ jobs:
find ./site-docs/generated -type f -exec grep -L "." {} \; >&2
exit 1
fi
+ - name: Verify license file
+ run: python committer-tools/verify_license.py --skipReleaseTarGz true
Review Comment:
`true` is redundant.
##########
committer-tools/verify_license.py:
##########
@@ -74,12 +75,20 @@ def get_license_deps(license_text):
return set(LICENSE_DEP_PATTERN.findall(license_text))
def main():
+ # Argument parser
+ parser = argparse.ArgumentParser(description="Process some integers.")
+ parser.add_argument('--skipReleaseTarGz', type=str, default='false',
help='Whether to skip ReleaseTarGz (true/false)')
+ args = parser.parse_args()
+
# Assume the current working directory is the project root.
project_dir = os.getcwd()
print("Using project directory:", project_dir)
-
+
+ if args.skipReleaseTarGz.lower() == 'true':
+ print("Skip running './gradlew clean releaseTarGz'")
+ else:
+ run_gradlew(project_dir)
# Build the tarball.
Review Comment:
please move the comment to line#89
##########
committer-tools/verify_license.py:
##########
@@ -74,12 +75,20 @@ def get_license_deps(license_text):
return set(LICENSE_DEP_PATTERN.findall(license_text))
def main():
+ # Argument parser
+ parser = argparse.ArgumentParser(description="Process some integers.")
+ parser.add_argument('--skipReleaseTarGz', type=str, default='false',
help='Whether to skip ReleaseTarGz (true/false)')
Review Comment:
`default='false'` -> `default=False`
##########
committer-tools/verify_license.py:
##########
@@ -74,12 +75,20 @@ def get_license_deps(license_text):
return set(LICENSE_DEP_PATTERN.findall(license_text))
def main():
+ # Argument parser
+ parser = argparse.ArgumentParser(description="Process some integers.")
+ parser.add_argument('--skipReleaseTarGz', type=str, default='false',
help='Whether to skip ReleaseTarGz (true/false)')
+ args = parser.parse_args()
+
# Assume the current working directory is the project root.
project_dir = os.getcwd()
print("Using project directory:", project_dir)
-
+
+ if args.skipReleaseTarGz.lower() == 'true':
Review Comment:
`if args.skipReleaseTarGz:`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
