m1a2st commented on code in PR #19104:
URL: https://github.com/apache/kafka/pull/19104#discussion_r1980945000
##########
clients/src/main/java/org/apache/kafka/common/config/internals/BrokerSecurityConfigs.java:
##########
@@ -79,7 +79,9 @@ public class BrokerSecurityConfigs {
"name from the client certificate if one is provided; otherwise,
if client authentication is not required, " +
"the principal name will be ANONYMOUS. For SASL authentication,
the principal will be derived using the " +
"rules defined by <code>" +
SASL_KERBEROS_PRINCIPAL_TO_LOCAL_RULES_CONFIG + "</code> if GSSAPI is in use, "
+
- "and the SASL authentication ID for other mechanisms. For
PLAINTEXT, the principal will be ANONYMOUS.";
+ "and the SASL authentication ID for other mechanisms. For
PLAINTEXT, the principal will be ANONYMOUS. " +
+ "Note that custom implementations of KafkaPrincipalBuilder is
required to implement KafkaPrincipalSerde " +
Review Comment:
I think it's better to wrap class names with a code block for improved
readability.
- `<code> KafkaPrincipalBuilder </code>`
- `<code> KafkaPrincipalSerde </code>`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
