[PR] KAFKA-18844: Stale features information in QuorumController#registerBroker (#18997) [kafka]

2025-02-28 Thread via GitHub
FrankYang0529 opened a new pull request, #19058: URL: https://github.com/apache/kafka/pull/19058 In https://github.com/apache/kafka/pull/16848, we added `kraft.version` to finalized features and got finalized features outside controller event handling thread. This may make finalized feature

[jira] [Updated] (KAFKA-18700) Migrate suitable classes to records in raft

2025-02-28 Thread Ming-Yen Chung (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18700?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ming-Yen Chung updated KAFKA-18700: --- Description: raft: Entry SnapshotPath was: raft: Entry SnapshotPath   > Migrate suitab

Re: [PR] KAFKA-18734: Implemented share partition metrics (KIP-1103) [kafka]

2025-02-28 Thread via GitHub
AndrewJSchofield merged PR #19045: URL: https://github.com/apache/kafka/pull/19045 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafk

Re: [PR] KAFKA-15900, KAFKA-18310: fix flaky test testOutdatedCoordinatorAssignment and AbstractCoordinatorTest [kafka]

2025-02-28 Thread via GitHub
lianetm commented on PR #18945: URL: https://github.com/apache/kafka/pull/18945#issuecomment-2691120474 Thanks for the updates @FrankYang0529 ! Could you check the style failures pls -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

Re: [PR] KAFKA-17516: Synonyms for client metrics configs [kafka]

2025-02-28 Thread via GitHub
AndrewJSchofield commented on code in PR #17264: URL: https://github.com/apache/kafka/pull/17264#discussion_r1975678964 ## core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala: ## @@ -981,10 +981,6 @@ class PlaintextAdminIntegrationTest extends BaseAdmi

Re: [PR] KAFKA-18817:[1/N] ShareGroupHeartbeat and ShareGroupDescribe API must check topic describe [kafka]

2025-02-28 Thread via GitHub
AndrewJSchofield commented on code in PR #19055: URL: https://github.com/apache/kafka/pull/19055#discussion_r1975724557 ## clients/src/main/java/org/apache/kafka/common/requests/ShareGroupHeartbeatResponse.java: ## @@ -35,6 +35,7 @@ * - {@link Errors#INVALID_REQUEST} * - {@l

[jira] [Created] (KAFKA-18904) Listing of configs for dynamically created resources is mysterious

2025-02-28 Thread Andrew Schofield (Jira)
Andrew Schofield created KAFKA-18904: Summary: Listing of configs for dynamically created resources is mysterious Key: KAFKA-18904 URL: https://issues.apache.org/jira/browse/KAFKA-18904 Project: K

[jira] [Updated] (KAFKA-18905) Avoid out of order sequence errors from multiple in-flight batches

2025-02-28 Thread Sean Quah (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18905?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sean Quah updated KAFKA-18905: -- Description: Consider a similar setup to KAFKA-9199: The broker attempts to cache the state of the la

[jira] [Commented] (KAFKA-18898) 4.0 Upgrade docs rendering below other versions

2025-02-28 Thread David Arthur (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17931481#comment-17931481 ] David Arthur commented on KAFKA-18898: -- I was looking at [https://kafka.apache.org/

[jira] [Created] (KAFKA-18905) Avoid out of order sequence errors from multiple in-flight batches

2025-02-28 Thread Sean Quah (Jira)
Sean Quah created KAFKA-18905: - Summary: Avoid out of order sequence errors from multiple in-flight batches Key: KAFKA-18905 URL: https://issues.apache.org/jira/browse/KAFKA-18905 Project: Kafka

[jira] [Updated] (KAFKA-17894) Additional metrics for cooperative consumption

2025-02-28 Thread Apoorv Mittal (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17894?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Apoorv Mittal updated KAFKA-17894: -- Affects Version/s: 4.1.0 > Additional metrics for cooperative consumption > --

[jira] [Updated] (KAFKA-18700) Migrate suitable classes to records in raft

2025-02-28 Thread Ming-Yen Chung (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18700?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ming-Yen Chung updated KAFKA-18700: --- Summary: Migrate suitable classes to records in raft (was: Migrate suitable classes to reco

[jira] [Updated] (KAFKA-18734) Implement share partition metrics for share fetch

2025-02-28 Thread Apoorv Mittal (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18734?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Apoorv Mittal updated KAFKA-18734: -- Affects Version/s: 4.1 > Implement share partition metrics for share fetch > -

Re: [PR] KAFKA-18873: Fixed incorrect error message when exceeds 5 for transactional producers [kafka]

2025-02-28 Thread via GitHub
EsMoX commented on PR #19041: URL: https://github.com/apache/kafka/pull/19041#issuecomment-2690914753 > Thanks for the PR. Seems there is some confusion about this test... > > First, the test was added like this 2 year ago and never modified. So it was missed on the original PR review

[PR] KAFKA-18878: Added share session cache and delayed share fetch metrics (KIP-1103) [kafka]

2025-02-28 Thread via GitHub
apoorvmittal10 opened a new pull request, #19059: URL: https://github.com/apache/kafka/pull/19059 The PR implements the ShareSessionCache and DelayedShareFetchMetrics as defined in KIP-1103. https://github.com/user-attachments/assets/81578d64-51b6-4228-972a-ce76a43a97d6"; /> https

Re: [PR] KAFKA-17516: Synonyms for client metrics configs [kafka]

2025-02-28 Thread via GitHub
AndrewJSchofield commented on code in PR #17264: URL: https://github.com/apache/kafka/pull/17264#discussion_r1975679794 ## core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala: ## @@ -981,10 +981,6 @@ class PlaintextAdminIntegrationTest extends BaseAdmi

Re: [PR] MINOR: Move DeleteGroupsResult to internals package. [kafka]

2025-02-28 Thread via GitHub
AndrewJSchofield commented on PR #19057: URL: https://github.com/apache/kafka/pull/19057#issuecomment-2691225538 > @AndrewJSchofield: DeleteGroupsResult wasn't included as part of the public interface in the original KIP. Do you think that it makes sense to include it in the public interfac

[PR] KAFKA-18881: Document the ConsumerRecord as non-thread safe [kafka]

2025-02-28 Thread via GitHub
LoganZhuZzz opened a new pull request, #19056: URL: https://github.com/apache/kafka/pull/19056 Due to concurrent issues encountered with ConsumerRecord's headers, it is necessary to add documentation to remind users. -- This is an automated message from the Apache Git Service. To resp

Re: [PR] KAFKA-18276 Migrate RebootstrapTest to new test infra [kafka]

2025-02-28 Thread via GitHub
m1a2st commented on code in PR #19046: URL: https://github.com/apache/kafka/pull/19046#discussion_r1975600010 ## core/src/test/java/kafka/test/api/ProducerRebootstrapTest.java: ## @@ -0,0 +1,121 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * co

[jira] [Resolved] (KAFKA-18734) Implement share partition metrics for share fetch

2025-02-28 Thread Apoorv Mittal (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18734?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Apoorv Mittal resolved KAFKA-18734. --- Resolution: Fixed > Implement share partition metrics for share fetch >

[jira] [Updated] (KAFKA-18734) Implement share partition metrics for share fetch

2025-02-28 Thread Apoorv Mittal (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18734?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Apoorv Mittal updated KAFKA-18734: -- Affects Version/s: 4.1.0 (was: 4.1) > Implement share partition met

Re: [PR] KAFKA-18500 Build PRs at HEAD commit [kafka]

2025-02-28 Thread via GitHub
mumrah commented on code in PR #18449: URL: https://github.com/apache/kafka/pull/18449#discussion_r1975617598 ## .github/workflows/README.md: ## @@ -133,4 +133,47 @@ Composite actions are a convenient way to reuse build logic, but they have some limitations. - Cannot run m

[jira] [Updated] (KAFKA-18903) Use curl + jq in update-cache.sh

2025-02-28 Thread David Arthur (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18903?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Arthur updated KAFKA-18903: - Component/s: build > Use curl + jq in update-cache.sh > > >

[PR] KAFKA-18899: Limit retry time for ShareConsumer.commitAsync [kafka]

2025-02-28 Thread via GitHub
AndrewJSchofield opened a new pull request, #19060: URL: https://github.com/apache/kafka/pull/19060 Previously, the ShareConsumer.commitAsync method retried sending ShareAcknowledge requests indefinitely. There was no good reason for this. This change adopts the usual Kafka practice of u

Re: [PR] KAFKA-16758: Extend Consumer#close with an option to leave the group or not [kafka]

2025-02-28 Thread via GitHub
frankvicky commented on code in PR #17614: URL: https://github.com/apache/kafka/pull/17614#discussion_r1975624999 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/WorkerGroupMember.java: ## @@ -198,7 +199,7 @@ public void requestRejoin() { }

[jira] [Created] (KAFKA-18903) Use curl + jq in update-cache.sh

2025-02-28 Thread David Arthur (Jira)
David Arthur created KAFKA-18903: Summary: Use curl + jq in update-cache.sh Key: KAFKA-18903 URL: https://issues.apache.org/jira/browse/KAFKA-18903 Project: Kafka Issue Type: Improvement

[jira] [Updated] (KAFKA-18905) Avoid out of order sequence errors from multiple in-flight batches

2025-02-28 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18905?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-18905: -- Component/s: clients > Avoid out of order sequence errors from multiple in-flight batches > --

[jira] [Updated] (KAFKA-18905) Avoid out of order sequence errors from multiple in-flight batches

2025-02-28 Thread Sean Quah (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18905?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sean Quah updated KAFKA-18905: -- Description: Consider a similar setup to KAFKA-9199: The broker attempts to cache the state of the la

Re: [PR] KAFKA-10864: Convert end txn marker schema to use auto-generated protocol [kafka]

2025-02-28 Thread via GitHub
dengziming commented on code in PR #9766: URL: https://github.com/apache/kafka/pull/9766#discussion_r1975048781 ## clients/src/main/java/org/apache/kafka/common/record/EndTransactionMarker.java: ## @@ -95,32 +71,28 @@ public int hashCode() { private static void ensureTran

Re: [PR] KAFKA-18881: Document the ConsumerRecord as non-thread safe [kafka]

2025-02-28 Thread via GitHub
frankvicky commented on code in PR #19056: URL: https://github.com/apache/kafka/pull/19056#discussion_r1975394152 ## clients/src/main/java/org/apache/kafka/clients/consumer/ConsumerRecord.java: ## @@ -27,6 +27,8 @@ * A key/value pair to be received from Kafka. This also consis

Re: [PR] KAFKA-15900, KAFKA-18310: fix flaky test testOutdatedCoordinatorAssignment and AbstractCoordinatorTest [kafka]

2025-02-28 Thread via GitHub
FrankYang0529 commented on code in PR #18945: URL: https://github.com/apache/kafka/pull/18945#discussion_r1975413906 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/BaseHeartbeatThread.java: ## @@ -0,0 +1,69 @@ +/* + * Licensed to the Apache Software Foundat

[jira] [Resolved] (KAFKA-18522) Limit fetch records batches as per acquired records

2025-02-28 Thread Apoorv Mittal (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18522?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Apoorv Mittal resolved KAFKA-18522. --- Fix Version/s: 4.1.0 Resolution: Fixed The first PR is merged and for MemoryRecords w

[jira] [Created] (KAFKA-18899) Limit retry time for ShareConsumer.commitAsync

2025-02-28 Thread Andrew Schofield (Jira)
Andrew Schofield created KAFKA-18899: Summary: Limit retry time for ShareConsumer.commitAsync Key: KAFKA-18899 URL: https://issues.apache.org/jira/browse/KAFKA-18899 Project: Kafka Issue

[jira] [Commented] (KAFKA-16719) Add AdminClient.deleteShareGroups

2025-02-28 Thread Sushant Mahajan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17931432#comment-17931432 ] Sushant Mahajan commented on KAFKA-16719: - https://github.com/apache/kafka/pull/

Re: [PR] KAFKA-18629: ShareGroupDeleteState admin client impl. [kafka]

2025-02-28 Thread via GitHub
smjn commented on code in PR #18928: URL: https://github.com/apache/kafka/pull/18928#discussion_r1975196948 ## clients/src/main/java/org/apache/kafka/clients/admin/DeleteGroupsResult.java: ## @@ -0,0 +1,56 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

Re: [PR] KAFKA-18817:[1/N] ShareGroupHeartbeat and ShareGroupDescribe API must check topic describe [kafka]

2025-02-28 Thread via GitHub
ShivsundarR commented on code in PR #19055: URL: https://github.com/apache/kafka/pull/19055#discussion_r1975285732 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/ShareHeartbeatRequestManagerTest.java: ## @@ -402,6 +402,12 @@ public void testHeartbeatRespons

Re: [PR] KAFKA-18844: Stale features information in QuorumController#registerBroker [kafka]

2025-02-28 Thread via GitHub
FrankYang0529 commented on PR #18997: URL: https://github.com/apache/kafka/pull/18997#issuecomment-2690675552 3.9 PR: https://github.com/apache/kafka/pull/19058 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

[jira] [Created] (KAFKA-18902) Experiment with ShareConsumer option to throw on poll if there are unacked records

2025-02-28 Thread Andrew Schofield (Jira)
Andrew Schofield created KAFKA-18902: Summary: Experiment with ShareConsumer option to throw on poll if there are unacked records Key: KAFKA-18902 URL: https://issues.apache.org/jira/browse/KAFKA-18902

[jira] [Created] (KAFKA-18900) Create a consumer config to select between implicit and explicit acknowledgement

2025-02-28 Thread Andrew Schofield (Jira)
Andrew Schofield created KAFKA-18900: Summary: Create a consumer config to select between implicit and explicit acknowledgement Key: KAFKA-18900 URL: https://issues.apache.org/jira/browse/KAFKA-18900

[jira] [Created] (KAFKA-18901) Improve redistribution of share group SimpleAssignor

2025-02-28 Thread Andrew Schofield (Jira)
Andrew Schofield created KAFKA-18901: Summary: Improve redistribution of share group SimpleAssignor Key: KAFKA-18901 URL: https://issues.apache.org/jira/browse/KAFKA-18901 Project: Kafka

[jira] [Updated] (KAFKA-18700) Migrate suitable classes to records in raft and connector-common modules

2025-02-28 Thread Ming-Yen Chung (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18700?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ming-Yen Chung updated KAFKA-18700: --- Description: raft: Entry SnapshotPath   was: raft: Entry SnapshotPath connector-common:

Re: [PR] KAFKA-18808: add test to ensure the name= is not equal to default quota [kafka]

2025-02-28 Thread via GitHub
Rancho-7 commented on code in PR #18966: URL: https://github.com/apache/kafka/pull/18966#discussion_r1974984330 ## core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala: ## @@ -138,6 +138,50 @@ class PlaintextAdminIntegrationTest extends BaseAdminIntegra

Re: [PR] KAFKA-18734: Implemented share partition metrics (KIP-1103) [kafka]

2025-02-28 Thread via GitHub
apoorvmittal10 commented on code in PR #19045: URL: https://github.com/apache/kafka/pull/19045#discussion_r1975320265 ## core/src/main/java/kafka/server/share/SharePartition.java: ## @@ -1326,6 +1355,56 @@ int leaderEpoch() { return leaderEpoch; } +/** +

Re: [PR] KAFKA-18734: Implemented share partition metrics (KIP-1103) [kafka]

2025-02-28 Thread via GitHub
apoorvmittal10 commented on code in PR #19045: URL: https://github.com/apache/kafka/pull/19045#discussion_r1975371781 ## core/src/main/java/kafka/server/share/SharePartition.java: ## @@ -313,6 +320,21 @@ public static RecordState forId(byte id) { */ private ShareParti

Re: [PR] MINOR: Move DeleteGroupsResult to internals package. [kafka]

2025-02-28 Thread via GitHub
ijuma commented on PR #19057: URL: https://github.com/apache/kafka/pull/19057#issuecomment-2690601588 I don't think we should do this change for the reason @AndrewJSchofield mentioned. Parent classes of public classes need themselves to be public. -- This is an automated message from the

Re: [PR] KAFKA-18734: Implemented share partition metrics (KIP-1103) [kafka]

2025-02-28 Thread via GitHub
AndrewJSchofield commented on code in PR #19045: URL: https://github.com/apache/kafka/pull/19045#discussion_r1975345141 ## core/src/main/java/kafka/server/share/SharePartition.java: ## @@ -313,6 +320,21 @@ public static RecordState forId(byte id) { */ private SharePar

Re: [PR] MINOR: Move DeleteGroupsResult to internals package. [kafka]

2025-02-28 Thread via GitHub
AndrewJSchofield commented on PR #19057: URL: https://github.com/apache/kafka/pull/19057#issuecomment-2690555953 @junrao Is this better? It seems to me that we now have two public classes inheriting from a class in the internals package. Would you prefer that we remove the inheritance and j

Re: [PR] KAFKA-18734: Implemented share partition metrics (KIP-1103) [kafka]

2025-02-28 Thread via GitHub
apoorvmittal10 commented on code in PR #19045: URL: https://github.com/apache/kafka/pull/19045#discussion_r1975371781 ## core/src/main/java/kafka/server/share/SharePartition.java: ## @@ -313,6 +320,21 @@ public static RecordState forId(byte id) { */ private ShareParti

Re: [PR] KAFKA-18276 Migrate RebootstrapTest to new test infra [kafka]

2025-02-28 Thread via GitHub
clarkwtc commented on code in PR #19046: URL: https://github.com/apache/kafka/pull/19046#discussion_r1975509750 ## core/src/test/java/kafka/test/api/ProducerRebootstrapTest.java: ## @@ -0,0 +1,121 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

Re: [PR] KAFKA-18276 Migrate RebootstrapTest to new test infra [kafka]

2025-02-28 Thread via GitHub
clarkwtc commented on code in PR #19046: URL: https://github.com/apache/kafka/pull/19046#discussion_r1975509750 ## core/src/test/java/kafka/test/api/ProducerRebootstrapTest.java: ## @@ -0,0 +1,121 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

Re: [PR] KAFKA-18617 Allow use of ClusterInstance inside BeforeEach [kafka]

2025-02-28 Thread via GitHub
mumrah commented on code in PR #18662: URL: https://github.com/apache/kafka/pull/18662#discussion_r1975512220 ## test-common/test-common-runtime/src/test/java/org/apache/kafka/common/test/junit/ClusterTestBeforeEachTest.java: ## @@ -0,0 +1,59 @@ +/* + * Licensed to the Apache So

Re: [PR] KAFKA-18276 Migrate RebootstrapTest to new test infra [kafka]

2025-02-28 Thread via GitHub
clarkwtc commented on code in PR #19046: URL: https://github.com/apache/kafka/pull/19046#discussion_r1975509750 ## core/src/test/java/kafka/test/api/ProducerRebootstrapTest.java: ## @@ -0,0 +1,121 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

[jira] [Commented] (KAFKA-18898) 4.0 Upgrade docs rendering below other versions

2025-02-28 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17931486#comment-17931486 ] Ismael Juma commented on KAFKA-18898: - No. > 4.0 Upgrade docs rendering below other

Re: [PR] KAFKA-18882:Move BaseKey, TxnKey, and UnknownKey to transaction-coordinator module [kafka]

2025-02-28 Thread via GitHub
frankvicky commented on code in PR #19054: URL: https://github.com/apache/kafka/pull/19054#discussion_r1975528720 ## core/src/main/scala/kafka/coordinator/transaction/TransactionLog.scala: ## @@ -96,12 +97,9 @@ object TransactionLog { val version = buffer.getShort if (

Re: [PR] KAFKA-18477 remove usage of OffsetForLeaderEpochRequest in AbstractFetcherThread [kafka]

2025-02-28 Thread via GitHub
github-actions[bot] commented on PR #18489: URL: https://github.com/apache/kafka/pull/18489#issuecomment-2691891338 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

[jira] [Commented] (KAFKA-18477) remove usage of OffsetForLeaderEpochRequest in AbstractFetcherThread

2025-02-28 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17931623#comment-17931623 ] Chia-Ping Tsai commented on KAFKA-18477: {quote} since we only have V2 message

Re: [PR] KAFKA-18646: Null records in fetch response breaks librdkafka [kafka]

2025-02-28 Thread via GitHub
ijuma commented on code in PR #18726: URL: https://github.com/apache/kafka/pull/18726#discussion_r1976211371 ## clients/src/main/resources/common/message/FetchResponse.json: ## @@ -106,7 +106,7 @@ ]}, { "name": "PreferredReadReplica", "type": "int32", "versions

[PR] KAFKA-18700: Migrate SnapshotPath and Entry in LogHistory to record classes [kafka]

2025-02-28 Thread via GitHub
mingyen066 opened a new pull request, #19062: URL: https://github.com/apache/kafka/pull/19062 Migrate the following data carrier class to records to eliminate constructors, equals, hashCode, and toString. * `final class Entry` in `LogHistory.java` * `public final class SnapshotPath`

Re: [PR] KAFKA-18617 Allow use of ClusterInstance inside BeforeEach [kafka]

2025-02-28 Thread via GitHub
chia7712 commented on code in PR #18662: URL: https://github.com/apache/kafka/pull/18662#discussion_r1976248738 ## test-common/test-common-runtime/src/test/java/org/apache/kafka/common/test/junit/ClusterTestBeforeEachTest.java: ## @@ -0,0 +1,59 @@ +/* + * Licensed to the Apache

Re: [PR] KAFKA-16580: Enable dynamic quorum reconfiguration for raft simulation tests pt 1 [kafka]

2025-02-28 Thread via GitHub
ahuang98 commented on code in PR #18987: URL: https://github.com/apache/kafka/pull/18987#discussion_r1976004288 ## raft/src/test/java/org/apache/kafka/raft/RaftEventSimulationTest.java: ## @@ -945,9 +987,13 @@ boolean allReachedHighWatermark(long offset) { .allM

[PR] KAFKA-17039: KIP-919 suports for unregisterBroker [kafka]

2025-02-28 Thread via GitHub
frankvicky opened a new pull request, #19063: URL: https://github.com/apache/kafka/pull/19063 JIRA: KAFKA-17039 This patch makes the controller able to handle `UnregisterBrokerRequest`. -- This is an automated message from the Apache Git Service. To respond to the message, pleas

Re: [PR] KAFKA-18332: fix ClassDataAbstractionCoupling problem in KafkaRaftClientTest(1/2) [kafka]

2025-02-28 Thread via GitHub
chia7712 commented on code in PR #18926: URL: https://github.com/apache/kafka/pull/18926#discussion_r1976306426 ## raft/src/test/java/org/apache/kafka/raft/KafkaRaftClientTest.java: ## @@ -4641,15 +4533,15 @@ public void testHandleLeaderChangeFiresAfterResignRegistration(boolea

Re: [PR] KAFKA-18617 Allow use of ClusterInstance inside BeforeEach [kafka]

2025-02-28 Thread via GitHub
chia7712 commented on code in PR #18662: URL: https://github.com/apache/kafka/pull/18662#discussion_r1976249061 ## test-common/test-common-internal-api/src/main/java/org/apache/kafka/common/test/api/README.md: ## @@ -104,7 +104,7 @@ For each generated invocation: * Non-static `

[PR] KAFKA-18893: KIP-877 Add support for ReplicaSelector [kafka]

2025-02-28 Thread via GitHub
TaiJuWu opened a new pull request, #19064: URL: https://github.com/apache/kafka/pull/19064 Delete this text and replace it with a detailed description of your change. The PR title and body will become the squashed commit message. If you would like to tag individuals, add some comm

Re: [PR] KAFKA-18893: KIP-877 Add support for ReplicaSelector [kafka]

2025-02-28 Thread via GitHub
TaiJuWu closed pull request #19064: KAFKA-18893: KIP-877 Add support for ReplicaSelector URL: https://github.com/apache/kafka/pull/19064 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] KAFKA-17039: KIP-919 suports for unregisterBroker [kafka]

2025-02-28 Thread via GitHub
chia7712 commented on code in PR #19063: URL: https://github.com/apache/kafka/pull/19063#discussion_r1976277903 ## core/src/test/java/kafka/server/BootstrapControllersIntegrationTest.java: ## @@ -228,6 +228,17 @@ public void testIncrementalAlterConfigs(ClusterInstance clusterIn

Re: [PR] MINOR: cleanup JavaDocs for deprecation warnings [kafka]

2025-02-28 Thread via GitHub
frankvicky commented on code in PR #18402: URL: https://github.com/apache/kafka/pull/18402#discussion_r1976255333 ## streams/src/main/java/org/apache/kafka/streams/kstream/JoinWindows.java: ## @@ -221,7 +221,7 @@ public long size() { * @return this updated builder *

Re: [PR] KAFKA-17607: Add CI step to verify LICENSE-binary [kafka]

2025-02-28 Thread via GitHub
chia7712 commented on code in PR #18299: URL: https://github.com/apache/kafka/pull/18299#discussion_r1976317444 ## .github/workflows/build.yml: ## @@ -127,6 +127,8 @@ jobs: gradle-cache-read-only: ${{ !inputs.is-trunk }} gradle-cache-write-only: ${{ inputs.

Re: [PR] KAFKA-18881: Document the ConsumerRecord as non-thread safe [kafka]

2025-02-28 Thread via GitHub
chia7712 commented on code in PR #19056: URL: https://github.com/apache/kafka/pull/19056#discussion_r1976092524 ## clients/src/main/java/org/apache/kafka/clients/consumer/ConsumerRecord.java: ## @@ -27,6 +27,8 @@ * A key/value pair to be received from Kafka. This also consists

Re: [PR] KAFKA-18646: Null records in fetch response breaks librdkafka [kafka]

2025-02-28 Thread via GitHub
junrao commented on code in PR #18726: URL: https://github.com/apache/kafka/pull/18726#discussion_r1976167164 ## clients/src/main/resources/common/message/FetchResponse.json: ## @@ -106,7 +106,7 @@ ]}, { "name": "PreferredReadReplica", "type": "int32", "version

[jira] [Resolved] (KAFKA-18669) Connector is restarted before it is started

2025-02-28 Thread Anil Dasari (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18669?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anil Dasari resolved KAFKA-18669. - Resolution: Done > Connector is restarted before it is started > ---

Re: [PR] KAFKA-16580: Enable dynamic quorum reconfiguration for raft simulation tests pt 1 [kafka]

2025-02-28 Thread via GitHub
kevin-wu24 commented on code in PR #18987: URL: https://github.com/apache/kafka/pull/18987#discussion_r1976012893 ## raft/src/test/java/org/apache/kafka/raft/RaftEventSimulationTest.java: ## @@ -580,6 +576,30 @@ void canRecoverFromSingleNodeCommittedDataLoss( scheduler.

Re: [PR] KAFKA-18646: Null records in fetch response breaks librdkafka [kafka]

2025-02-28 Thread via GitHub
ijuma commented on code in PR #18726: URL: https://github.com/apache/kafka/pull/18726#discussion_r1976186661 ## clients/src/main/resources/common/message/FetchResponse.json: ## @@ -106,7 +106,7 @@ ]}, { "name": "PreferredReadReplica", "type": "int32", "versions

Re: [PR] KAFKA-16580: Enable dynamic quorum reconfiguration for raft simulation tests pt 1 [kafka]

2025-02-28 Thread via GitHub
ahuang98 commented on code in PR #18987: URL: https://github.com/apache/kafka/pull/18987#discussion_r1976005044 ## raft/src/test/java/org/apache/kafka/raft/RaftEventSimulationTest.java: ## @@ -580,6 +576,30 @@ void canRecoverFromSingleNodeCommittedDataLoss( scheduler.ru

Re: [PR] KAFKA-18646: Null records in fetch response breaks librdkafka [kafka]

2025-02-28 Thread via GitHub
junrao commented on code in PR #18726: URL: https://github.com/apache/kafka/pull/18726#discussion_r1976078647 ## clients/src/main/resources/common/message/FetchResponse.json: ## @@ -106,7 +106,7 @@ ]}, { "name": "PreferredReadReplica", "type": "int32", "version

[jira] [Commented] (KAFKA-18876) 4.0 documentation improvement

2025-02-28 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17931584#comment-17931584 ] Chia-Ping Tsai commented on KAFKA-18876: Sure, we can fix it in the next few day

Re: [PR] KAFKA-18646: Null records in fetch response breaks librdkafka [kafka]

2025-02-28 Thread via GitHub
chia7712 commented on code in PR #18726: URL: https://github.com/apache/kafka/pull/18726#discussion_r1976088168 ## clients/src/main/resources/common/message/FetchResponse.json: ## @@ -106,7 +106,7 @@ ]}, { "name": "PreferredReadReplica", "type": "int32", "versi

Re: [PR] KAFKA-18646: Null records in fetch response breaks librdkafka [kafka]

2025-02-28 Thread via GitHub
junrao commented on code in PR #18726: URL: https://github.com/apache/kafka/pull/18726#discussion_r1976209643 ## clients/src/main/resources/common/message/FetchResponse.json: ## @@ -106,7 +106,7 @@ ]}, { "name": "PreferredReadReplica", "type": "int32", "version

[jira] [Resolved] (KAFKA-18657) Flaky SharePartitionManagerTest

2025-02-28 Thread Andrew Schofield (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18657?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Schofield resolved KAFKA-18657. -- Fix Version/s: 4.1.0 Resolution: Fixed > Flaky SharePartitionManagerTest >

Re: [PR] KAFKA-18808: add test to ensure the name= is not equal to default quota [kafka]

2025-02-28 Thread via GitHub
Rancho-7 commented on code in PR #18966: URL: https://github.com/apache/kafka/pull/18966#discussion_r1974984330 ## core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala: ## @@ -138,6 +138,50 @@ class PlaintextAdminIntegrationTest extends BaseAdminIntegra

Re: [PR] KAFKA-18808: add test to ensure the name= is not equal to default quota [kafka]

2025-02-28 Thread via GitHub
Rancho-7 commented on code in PR #18966: URL: https://github.com/apache/kafka/pull/18966#discussion_r1974987786 ## core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala: ## @@ -138,6 +138,50 @@ class PlaintextAdminIntegrationTest extends BaseAdminIntegra

Re: [PR] MINOR: Removing share partition manager flaky annotation [kafka]

2025-02-28 Thread via GitHub
AndrewJSchofield merged PR #19053: URL: https://github.com/apache/kafka/pull/19053 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafk

Re: [PR] KAFKA-18808: add test to ensure the name= is not equal to default quota [kafka]

2025-02-28 Thread via GitHub
Rancho-7 commented on code in PR #18966: URL: https://github.com/apache/kafka/pull/18966#discussion_r1974984330 ## core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala: ## @@ -138,6 +138,50 @@ class PlaintextAdminIntegrationTest extends BaseAdminIntegra

Re: [PR] KAFKA-18864:remove the Evolving tag from stable public interfaces [kafka]

2025-02-28 Thread via GitHub
junrao merged PR #19036: URL: https://github.com/apache/kafka/pull/19036 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.o

Re: [PR] KAFKA-16580: Enable dynamic quorum reconfiguration for raft simulation tests pt 1 [kafka]

2025-02-28 Thread via GitHub
kevin-wu24 commented on code in PR #18987: URL: https://github.com/apache/kafka/pull/18987#discussion_r1976011663 ## raft/src/test/java/org/apache/kafka/raft/RaftEventSimulationTest.java: ## @@ -117,40 +125,101 @@ public class RaftEventSimulationTest { void canElectInitialL

Re: [PR] KAFKA-18646: Null records in fetch response breaks librdkafka [kafka]

2025-02-28 Thread via GitHub
junrao commented on code in PR #18726: URL: https://github.com/apache/kafka/pull/18726#discussion_r1976015748 ## clients/src/main/resources/common/message/FetchResponse.json: ## @@ -106,7 +106,7 @@ ]}, { "name": "PreferredReadReplica", "type": "int32", "version

[jira] [Resolved] (KAFKA-18864) remove the Evolving tag from stable public interfaces

2025-02-28 Thread Jun Rao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18864?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao resolved KAFKA-18864. - Fix Version/s: 4.1.0 Resolution: Fixed > remove the Evolving tag from stable public interfaces >

Re: [PR] KAFKA-16580: Enable dynamic quorum reconfiguration for raft simulation tests pt 1 [kafka]

2025-02-28 Thread via GitHub
ahuang98 commented on code in PR #18987: URL: https://github.com/apache/kafka/pull/18987#discussion_r1975971708 ## raft/src/test/java/org/apache/kafka/raft/RaftEventSimulationTest.java: ## @@ -117,40 +125,101 @@ public class RaftEventSimulationTest { void canElectInitialLea

Re: [PR] KAFKA-18617 Allow use of ClusterInstance inside BeforeEach [kafka]

2025-02-28 Thread via GitHub
mumrah commented on code in PR #18662: URL: https://github.com/apache/kafka/pull/18662#discussion_r1975497268 ## test-common/test-common-runtime/src/test/java/org/apache/kafka/common/test/junit/ClusterTestBeforeEachTest.java: ## @@ -0,0 +1,59 @@ +/* + * Licensed to the Apache So

[jira] [Assigned] (KAFKA-18903) Use curl + jq in update-cache.sh

2025-02-28 Thread Ming-Yen Chung (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18903?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ming-Yen Chung reassigned KAFKA-18903: -- Assignee: Ming-Yen Chung > Use curl + jq in update-cache.sh > ---

Re: [PR] KAFKA-18881: Document the ConsumerRecord as non-thread safe [kafka]

2025-02-28 Thread via GitHub
kirktrue commented on code in PR #19056: URL: https://github.com/apache/kafka/pull/19056#discussion_r1975850054 ## clients/src/main/java/org/apache/kafka/clients/consumer/ConsumerRecord.java: ## @@ -27,6 +27,8 @@ * A key/value pair to be received from Kafka. This also consists

Re: [PR] KAFKA-16580: Enable dynamic quorum reconfiguration for raft simulation tests pt 1 [kafka]

2025-02-28 Thread via GitHub
kevin-wu24 commented on code in PR #18987: URL: https://github.com/apache/kafka/pull/18987#discussion_r1976010924 ## raft/src/test/java/org/apache/kafka/raft/RaftEventSimulationTest.java: ## @@ -117,40 +125,101 @@ public class RaftEventSimulationTest { void canElectInitialL

[jira] [Commented] (KAFKA-18904) Listing of configs for dynamically created resources is mysterious

2025-02-28 Thread PoAn Yang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17931601#comment-17931601 ] PoAn Yang commented on KAFKA-18904: --- Hi [~schofielaj], if you're not working on this,

Re: [PR] KAFKA-18646: Null records in fetch response breaks librdkafka [kafka]

2025-02-28 Thread via GitHub
ijuma commented on code in PR #18726: URL: https://github.com/apache/kafka/pull/18726#discussion_r1976211222 ## clients/src/main/resources/common/message/FetchResponse.json: ## @@ -106,7 +106,7 @@ ]}, { "name": "PreferredReadReplica", "type": "int32", "versions

Re: [PR] KAFKA-15900, KAFKA-18310: fix flaky test testOutdatedCoordinatorAssignment and AbstractCoordinatorTest [kafka]

2025-02-28 Thread via GitHub
FrankYang0529 commented on PR #18945: URL: https://github.com/apache/kafka/pull/18945#issuecomment-2691860399 Sorry for that. I only checked test can pass yesterday. Fixed style error. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please l

Re: [PR] KAFKA-18646: Null records in fetch response breaks librdkafka [kafka]

2025-02-28 Thread via GitHub
junrao commented on code in PR #18726: URL: https://github.com/apache/kafka/pull/18726#discussion_r1976015748 ## clients/src/main/resources/common/message/FetchResponse.json: ## @@ -106,7 +106,7 @@ ]}, { "name": "PreferredReadReplica", "type": "int32", "version

Re: [PR] KAFKA-18842: add configurable max number of connectors [kafka]

2025-02-28 Thread via GitHub
github-actions[bot] commented on PR #18993: URL: https://github.com/apache/kafka/pull/18993#issuecomment-2691891270 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

Re: [PR] MINOR: Add README.md test command [kafka]

2025-02-28 Thread via GitHub
chia7712 merged PR #19025: URL: https://github.com/apache/kafka/pull/19025 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] KAFKA-18748 Run new tests separately in PRs [kafka]

2025-02-28 Thread via GitHub
chia7712 commented on code in PR #18770: URL: https://github.com/apache/kafka/pull/18770#discussion_r1976251415 ## README.md: ## @@ -42,7 +42,6 @@ Follow instructions in https://kafka.apache.org/quickstart ./gradlew test # runs both unit and integration tests ./gradle

Re: [PR] KAFKA-18843: Fix MirrorMaker2 workerId is not unique, but use the sam… [kafka]

2025-02-28 Thread via GitHub
github-actions[bot] commented on PR #18994: URL: https://github.com/apache/kafka/pull/18994#issuecomment-2691891254 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

  1   2   >