Re: [PR] MINOR: Remove unused system test code and avoid misleading `quorum.zk` references [kafka]

2025-02-26 Thread via GitHub
m1a2st commented on code in PR #19034: URL: https://github.com/apache/kafka/pull/19034#discussion_r1971614754 ## tests/kafkatest/services/kafka/kafka.py: ## @@ -1362,7 +1356,7 @@ def alter_message_format(self, topic, msg_format_version, node=None): def kafka_acls_cmd_with_

[jira] [Commented] (KAFKA-15283) Client support for OffsetFetch and OffsetCommit with topic ID

2025-02-26 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17930701#comment-17930701 ] Lianet Magrans commented on KAFKA-15283: Hi [~isding_l] , not working on it beca

Re: [PR] [MINOR] Clean up coordinator-common and server modules [kafka]

2025-02-26 Thread via GitHub
sjhajharia commented on PR #19009: URL: https://github.com/apache/kafka/pull/19009#issuecomment-2685660580 hey @chia7712 gentle reminder for this PR Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[jira] [Updated] (KAFKA-18874) KRaft controller does not retry registration if the first attempt times out

2025-02-26 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-18874?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] José Armando García Sancio updated KAFKA-18874: --- Component/s: controller > KRaft controller does not retry registrati

Re: [PR] MINOR: Remove old message format documentation [kafka]

2025-02-26 Thread via GitHub
ijuma merged PR #19033: URL: https://github.com/apache/kafka/pull/19033 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

Re: [PR] MINOR: Remove old message format documentation [kafka]

2025-02-26 Thread via GitHub
ijuma commented on PR #19033: URL: https://github.com/apache/kafka/pull/19033#issuecomment-2685752393 Cherry-picked to 4.0 as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] KAFKA-17431: Support invalid static configs for KRaft so long as dynamic configs are valid [kafka]

2025-02-26 Thread via GitHub
cmccabe commented on code in PR #18949: URL: https://github.com/apache/kafka/pull/18949#discussion_r1972230877 ## core/src/main/scala/kafka/raft/RaftManager.scala: ## @@ -104,6 +104,8 @@ trait RaftManager[T] { def replicatedLog: ReplicatedLog def voterNode(id: Int, liste

[PR] KAFKA-18813: ConsumerGroupHeartbeat API and ConsumerGroupDescribe API… [kafka]

2025-02-26 Thread via GitHub
dongnuo123 opened a new pull request, #19042: URL: https://github.com/apache/kafka/pull/19042 … must check topic describe (#18989) This patch filters out the topic describe unauthorized topics from the ConsumerGroupHeartbeat and ConsumerGroupDescribe response. In ConsumerGroupH

Re: [PR] KAFKA-18813: ConsumerGroupHeartbeat API and ConsumerGroupDescribe API… [kafka]

2025-02-26 Thread via GitHub
dongnuo123 commented on code in PR #19042: URL: https://github.com/apache/kafka/pull/19042#discussion_r1972238070 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorService.java: ## @@ -158,29 +160,28 @@ public Builder withGroupConfigManager(Gr

Re: [PR] KAFKA-15900, KAFKA-18310: fix flaky test testOutdatedCoordinatorAssignment and AbstractCoordinatorTest [kafka]

2025-02-26 Thread via GitHub
lianetm commented on code in PR #18945: URL: https://github.com/apache/kafka/pull/18945#discussion_r1971704382 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java: ## @@ -165,16 +165,18 @@ public AbstractCoordinator(GroupRebalanceConfig

Re: [PR] WIP Investigate OOM [kafka]

2025-02-26 Thread via GitHub
mumrah commented on PR #19031: URL: https://github.com/apache/kafka/pull/19031#issuecomment-2686054397 Seems to have reproduced here: https://github.com/apache/kafka/actions/runs/13550598471/job/37873138268?pr=19031 No activity for a while after ``` Wed, 26 Feb 2025 18:35:41 GMT

Re: [PR] KAFKA-18850: Fix the docs of org.apache.kafka.automatic.config.providers [kafka]

2025-02-26 Thread via GitHub
Rancho-7 commented on code in PR #19039: URL: https://github.com/apache/kafka/pull/19039#discussion_r1971674751 ## clients/src/test/java/org/apache/kafka/common/config/AbstractConfigTest.java: ## @@ -450,6 +450,33 @@ public void testConfigProvidersPropsAsParam() { MockF

Re: [PR] KAFKA-18850: Fix the docs of org.apache.kafka.automatic.config.providers [kafka]

2025-02-26 Thread via GitHub
Rancho-7 commented on code in PR #19039: URL: https://github.com/apache/kafka/pull/19039#discussion_r1971671660 ## clients/src/test/java/org/apache/kafka/common/config/AbstractConfigTest.java: ## @@ -450,6 +450,33 @@ public void testConfigProvidersPropsAsParam() { MockF

Re: [PR] KAFKA-18850: Fix the docs of org.apache.kafka.automatic.config.providers [kafka]

2025-02-26 Thread via GitHub
Rancho-7 commented on code in PR #19039: URL: https://github.com/apache/kafka/pull/19039#discussion_r1971676812 ## clients/src/test/java/org/apache/kafka/common/config/AbstractConfigTest.java: ## @@ -450,6 +450,33 @@ public void testConfigProvidersPropsAsParam() { MockF

Re: [PR] KAFKA-18850: Fix the docs of org.apache.kafka.automatic.config.providers [kafka]

2025-02-26 Thread via GitHub
Rancho-7 commented on code in PR #19039: URL: https://github.com/apache/kafka/pull/19039#discussion_r1971676812 ## clients/src/test/java/org/apache/kafka/common/config/AbstractConfigTest.java: ## @@ -450,6 +450,33 @@ public void testConfigProvidersPropsAsParam() { MockF

Re: [PR] MINOR: Disallow unused local variables [kafka]

2025-02-26 Thread via GitHub
mumrah commented on code in PR #18963: URL: https://github.com/apache/kafka/pull/18963#discussion_r1971693097 ## tools/src/main/java/org/apache/kafka/tools/ShareConsumerPerformance.java: ## @@ -79,7 +79,8 @@ public static void main(String[] args) { shareConsumer

Re: [PR] KAFKA-18813: ConsumerGroupHeartbeat API and ConsumerGroupDescribe API must check topic describe [kafka]

2025-02-26 Thread via GitHub
dongnuo123 commented on code in PR #18989: URL: https://github.com/apache/kafka/pull/18989#discussion_r1971754326 ## core/src/test/scala/integration/kafka/api/EndToEndAuthorizationTest.scala: ## @@ -561,5 +568,17 @@ abstract class EndToEndAuthorizationTest extends IntegrationTe

[jira] [Commented] (KAFKA-18329) Delete old group coordinator (KIP-848)

2025-02-26 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17930718#comment-17930718 ] Ismael Juma commented on KAFKA-18329: - Why 4.2.0? What's stopping us from doing it n

Re: [PR] MINOR: Remove unused system test code and avoid misleading `quorum.zk` references [kafka]

2025-02-26 Thread via GitHub
ijuma commented on code in PR #19034: URL: https://github.com/apache/kafka/pull/19034#discussion_r1971797966 ## tests/kafkatest/services/kafka/kafka.py: ## @@ -1362,7 +1356,7 @@ def alter_message_format(self, topic, msg_format_version, node=None): def kafka_acls_cmd_with_o

[PR] KAFKA-18858: Refactor FeatureControlManager to avoid using uninitialized MV [kafka]

2025-02-26 Thread via GitHub
FrankYang0529 opened a new pull request, #19040: URL: https://github.com/apache/kafka/pull/19040 The `FeatureControlManager` used `MetadataVersion#LATEST_PRODUCTION` as uninitialized MV. This makes other component may get a stale MV. In production code, the `FeatureControlManager` set M

Re: [PR] KAFKA-18813: ConsumerGroupHeartbeat API and ConsumerGroupDescribe API must check topic describe [kafka]

2025-02-26 Thread via GitHub
lianetm commented on code in PR #18989: URL: https://github.com/apache/kafka/pull/18989#discussion_r1971805902 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -2592,6 +2608,38 @@ class KafkaApis(val requestChannel: RequestChannel, response.groups.addAll(r

Re: [PR] MINOR: Remove unused system test code and avoid misleading `quorum.zk` references [kafka]

2025-02-26 Thread via GitHub
m1a2st commented on code in PR #19034: URL: https://github.com/apache/kafka/pull/19034#discussion_r1971599561 ## tests/kafkatest/services/kafka/kafka.py: ## @@ -1362,7 +1356,7 @@ def alter_message_format(self, topic, msg_format_version, node=None): def kafka_acls_cmd_with_

Re: [PR] KAFKA-18850: Fix the docs of org.apache.kafka.automatic.config.providers [kafka]

2025-02-26 Thread via GitHub
frankvicky commented on code in PR #19039: URL: https://github.com/apache/kafka/pull/19039#discussion_r1971633273 ## clients/src/test/java/org/apache/kafka/common/config/AbstractConfigTest.java: ## @@ -450,6 +450,33 @@ public void testConfigProvidersPropsAsParam() { Moc

Re: [PR] KAFKA-18868: add the "default value" explanation to the docs of num.replica.alter.log.dirs.threads [kafka]

2025-02-26 Thread via GitHub
m1a2st commented on code in PR #19038: URL: https://github.com/apache/kafka/pull/19038#discussion_r1971566712 ## server/src/main/java/org/apache/kafka/server/config/ServerConfigs.java: ## @@ -52,7 +52,8 @@ public class ServerConfigs { public static final String BACKGROUND_T

Re: [PR] KAFKA-17607: Add CI step to verify LICENSE-binary [kafka]

2025-02-26 Thread via GitHub
m1a2st commented on code in PR #18299: URL: https://github.com/apache/kafka/pull/18299#discussion_r1971829502 ## .github/workflows/build.yml: ## @@ -127,6 +127,9 @@ jobs: gradle-cache-read-only: ${{ !inputs.is-trunk }} gradle-cache-write-only: ${{ inputs.is

Re: [PR] KAFKA-18614, KAFKA-18613: Add streams group request plumbing [kafka]

2025-02-26 Thread via GitHub
lucasbru merged PR #18979: URL: https://github.com/apache/kafka/pull/18979 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] MINOR: Remove old message format documentation [kafka]

2025-02-26 Thread via GitHub
ijuma commented on code in PR #19033: URL: https://github.com/apache/kafka/pull/19033#discussion_r1971831709 ## docs/implementation.html: ## @@ -103,67 +103,8 @@ 5.3.3 Old Message Format -Prior to Kafka 0.11, messages were transferred and stored in message sets. I

[jira] [Updated] (KAFKA-18651) Core streams-specific broker configurations

2025-02-26 Thread Lucas Brutschy (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18651?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lucas Brutschy updated KAFKA-18651: --- Fix Version/s: 4.1 > Core streams-specific broker configurations > -

[jira] [Updated] (KAFKA-18651) Core streams-specific broker configurations

2025-02-26 Thread Lucas Brutschy (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18651?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lucas Brutschy updated KAFKA-18651: --- Fix Version/s: 4.1.0 (was: 4.1) > Core streams-specific broker config

[PR] KAFKA-18850: Fix the docs of org.apache.kafka.automatic.config.providers [kafka]

2025-02-26 Thread via GitHub
Rancho-7 opened a new pull request, #19039: URL: https://github.com/apache/kafka/pull/19039 jira: https://issues.apache.org/jira/browse/KAFKA-18850 `org.apache.kafka.automatic.config.providers = env` is incorrect. According to the source code, the correct value should be the [class n

Re: [PR] MINOR: Add README.md test command [kafka]

2025-02-26 Thread via GitHub
m1a2st commented on code in PR #19025: URL: https://github.com/apache/kafka/pull/19025#discussion_r1971727446 ## README.md: ## @@ -75,6 +76,7 @@ Retries are disabled by default, but you can set maxTestRetryFailures and maxTes The following example declares -PmaxTestRetries=1 a

Re: [PR] MINOR: Add README.md test command [kafka]

2025-02-26 Thread via GitHub
m1a2st commented on code in PR #19025: URL: https://github.com/apache/kafka/pull/19025#discussion_r1971727446 ## README.md: ## @@ -75,6 +76,7 @@ Retries are disabled by default, but you can set maxTestRetryFailures and maxTes The following example declares -PmaxTestRetries=1 a

Re: [PR] KAFKA-16580: Enable dynamic quorum reconfiguration for raft simulation tests pt 1 [kafka]

2025-02-26 Thread via GitHub
kevin-wu24 commented on code in PR #18987: URL: https://github.com/apache/kafka/pull/18987#discussion_r1971722138 ## raft/src/test/java/org/apache/kafka/raft/RaftEventSimulationTest.java: ## @@ -1127,14 +1331,75 @@ private MajorityReachedHighWatermark(Cluster cluster) {

Re: [PR] MINOR: Add README.md test command [kafka]

2025-02-26 Thread via GitHub
m1a2st commented on code in PR #19025: URL: https://github.com/apache/kafka/pull/19025#discussion_r1971727446 ## README.md: ## @@ -75,6 +76,7 @@ Retries are disabled by default, but you can set maxTestRetryFailures and maxTes The following example declares -PmaxTestRetries=1 a

[jira] [Created] (KAFKA-18873) Incorrect error message for max.in.flight.requests.per.connection when using transactional producer.

2025-02-26 Thread Eslam Mohamed (Jira)
Eslam Mohamed created KAFKA-18873: - Summary: Incorrect error message for max.in.flight.requests.per.connection when using transactional producer. Key: KAFKA-18873 URL: https://issues.apache.org/jira/browse/KAFKA-1

[jira] [Commented] (KAFKA-18872) Convert StressTestLog and TestLinearWriteSpeed to jmh benchmarks

2025-02-26 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17930717#comment-17930717 ] Ismael Juma commented on KAFKA-18872: - Given that this is exercising the log layer,

Re: [PR] KAFKA-18780: Extend RetriableException related exceptions [kafka]

2025-02-26 Thread via GitHub
m1a2st commented on code in PR #19020: URL: https://github.com/apache/kafka/pull/19020#discussion_r1971884683 ## clients/src/test/java/org/apache/kafka/common/errors/TransactionExceptionHierarchyTest.java: ## @@ -0,0 +1,60 @@ +/* + * Licensed to the Apache Software Foundation (A

[jira] [Commented] (KAFKA-18877) an mechanism to find cases where we accessed variables from the wrong thread

2025-02-26 Thread David Arthur (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17930871#comment-17930871 ] David Arthur commented on KAFKA-18877: -- I think the most likely unsafe access is re

Re: [PR] KAFKA-18849: Add "strict min ISR" to the docs of "min.insync.replicas" [kafka]

2025-02-26 Thread via GitHub
clarkwtc commented on code in PR #19016: URL: https://github.com/apache/kafka/pull/19016#discussion_r1972555921 ## server-common/src/main/java/org/apache/kafka/server/config/ServerTopicConfigSynonyms.java: ## @@ -78,6 +78,7 @@ public final class ServerTopicConfigSynonyms {

Re: [PR] KAFKA-18849: Add "strict min ISR" to the docs of "min.insync.replicas" [kafka]

2025-02-26 Thread via GitHub
clarkwtc commented on code in PR #19016: URL: https://github.com/apache/kafka/pull/19016#discussion_r1972555921 ## server-common/src/main/java/org/apache/kafka/server/config/ServerTopicConfigSynonyms.java: ## @@ -78,6 +78,7 @@ public final class ServerTopicConfigSynonyms {

[PR] KAFKA-18734: Implemented share partition metrics (KIP-1103) [kafka]

2025-02-26 Thread via GitHub
apoorvmittal10 opened a new pull request, #19045: URL: https://github.com/apache/kafka/pull/19045 The PR implements the SharePartitionMetrics as defined in KIP-1103, with one change. The metric `FetchLockRatio` is defined as `Meter` in KIP but is implemented as `HIstogram`. There was a disc

[jira] [Resolved] (KAFKA-18863) Runtime additions for connector multiversioning.

2025-02-26 Thread Greg Harris (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18863?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Harris resolved KAFKA-18863. - Fix Version/s: 4.1.0 Resolution: Fixed > Runtime additions for connector multiversioning.

[jira] [Created] (KAFKA-18878) Implement share session cache metrics for share fetch

2025-02-26 Thread Apoorv Mittal (Jira)
Apoorv Mittal created KAFKA-18878: - Summary: Implement share session cache metrics for share fetch Key: KAFKA-18878 URL: https://issues.apache.org/jira/browse/KAFKA-18878 Project: Kafka Issue

[jira] [Updated] (KAFKA-18878) Implement ShareSessionCache and DelayedShareFetchMetrics metrics for share fetch

2025-02-26 Thread Apoorv Mittal (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18878?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Apoorv Mittal updated KAFKA-18878: -- Summary: Implement ShareSessionCache and DelayedShareFetchMetrics metrics for share fetch (wa

Re: [PR] KAFKA-18863: Connect Multiversion Support (Versioned Connector Creation and related changes) [kafka]

2025-02-26 Thread via GitHub
gharris1727 merged PR #17743: URL: https://github.com/apache/kafka/pull/17743 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apa

Re: [PR] KAFKA-16758: Extend Consumer#close with an option to leave the group or not [kafka]

2025-02-26 Thread via GitHub
ableegoldman commented on code in PR #17614: URL: https://github.com/apache/kafka/pull/17614#discussion_r1972542173 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractMembershipManager.java: ## @@ -275,6 +284,24 @@ public int memberEpoch() { re

[jira] [Commented] (KAFKA-18877) an mechanism to find cases where we accessed variables from the wrong thread

2025-02-26 Thread TengYao Chi (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17930883#comment-17930883 ] TengYao Chi commented on KAFKA-18877: - Hi [~chia7712]  If you are not start working

[jira] [Commented] (KAFKA-15636) Investigate FetcherTest's/FetchRequestManager's testFetchResponseMetrics

2025-02-26 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17930891#comment-17930891 ] Kirk True commented on KAFKA-15636: --- Can we do both :) Process the first fetch and mak

Re: [PR] KAFKA-18646: Null records in fetch response breaks librdkafka [kafka]

2025-02-26 Thread via GitHub
chia7712 commented on code in PR #18726: URL: https://github.com/apache/kafka/pull/18726#discussion_r1972645207 ## clients/src/main/resources/common/message/FetchResponse.json: ## @@ -106,7 +106,7 @@ ]}, { "name": "PreferredReadReplica", "type": "int32", "versi

[jira] [Updated] (KAFKA-18876) 4.0 documentation improvement

2025-02-26 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18876?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated KAFKA-18876: --- Fix Version/s: 4.0.0 > 4.0 documentation improvement > - > >

[jira] [Commented] (KAFKA-17037) KIP-919 supports for `describeClientQuotas` and `alterClientQuotas`

2025-02-26 Thread TaiJuWu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17930895#comment-17930895 ] TaiJuWu commented on KAFKA-17037: - Hi [~isding_l] , this ticket was finished for a long

[PR] KAFKA-18276 Migrate RebootstrapTest to new test infra [kafka]

2025-02-26 Thread via GitHub
clarkwtc opened a new pull request, #19046: URL: https://github.com/apache/kafka/pull/19046 Migrate RebootstrapTest to new test infra and remove the old Scala test. The test results https://github.com/user-attachments/assets/35812c96-13f7-41f8-829d-40947f768646"; /> --

[jira] [Updated] (KAFKA-18850) Fix the docs of org.apache.kafka.automatic.config.providers

2025-02-26 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18850?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated KAFKA-18850: --- Fix Version/s: 4.0.0 > Fix the docs of org.apache.kafka.automatic.config.providers > ---

[jira] [Updated] (KAFKA-18849) add "strict min ISR" to the docs of "min.insync.replicas"

2025-02-26 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18849?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated KAFKA-18849: --- Fix Version/s: 4.0.0 > add "strict min ISR" to the docs of "min.insync.replicas" > -

[jira] [Updated] (KAFKA-18868) add the "default value" explanation to the docs of num.replica.alter.log.dirs.threads

2025-02-26 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18868?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated KAFKA-18868: --- Fix Version/s: 4.0.0 > add the "default value" explanation to the docs of > num.replica.alt

[jira] [Updated] (KAFKA-18869) add remote storage threads to "Updating Thread Configs" section

2025-02-26 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18869?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated KAFKA-18869: --- Fix Version/s: 4.0.0 > add remote storage threads to "Updating Thread Configs" section > ---

Re: [PR] KAFKA-18868: add the "default value" explanation to the docs of num.replica.alter.log.dirs.threads [kafka]

2025-02-26 Thread via GitHub
LoganZhuZzz commented on code in PR #19038: URL: https://github.com/apache/kafka/pull/19038#discussion_r1972652456 ## server/src/main/java/org/apache/kafka/server/config/ServerConfigs.java: ## @@ -52,7 +52,8 @@ public class ServerConfigs { public static final String BACKGRO

[jira] [Commented] (KAFKA-17037) KIP-919 supports for `describeClientQuotas` and `alterClientQuotas`

2025-02-26 Thread Lan Ding (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17930896#comment-17930896 ] Lan Ding commented on KAFKA-17037: -- Hi [~taijuwu] ,  If this ticket is still open, may

[jira] (KAFKA-17037) KIP-919 supports for `describeClientQuotas` and `alterClientQuotas`

2025-02-26 Thread Lan Ding (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17037 ] Lan Ding deleted comment on KAFKA-17037: -- was (Author: JIRAUSER30): Hi [~taijuwu] ,  If this ticket is still open, may I take it over? > KIP-919 supports for `describeClientQuotas` and `alt

[jira] [Assigned] (KAFKA-18870) implement describeDelegationToken for controller

2025-02-26 Thread TaiJuWu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18870?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] TaiJuWu reassigned KAFKA-18870: --- Assignee: TaiJuWu > implement describeDelegationToken for controller >

[jira] [Commented] (KAFKA-17651) Implement `describeUserScramCredentials`

2025-02-26 Thread Lan Ding (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17930897#comment-17930897 ] Lan Ding commented on KAFKA-17651: -- Hi [~frankvicky],  If this ticket is still open, ma

Re: [PR] KAFKA-18646: Null records in fetch response breaks librdkafka [kafka]

2025-02-26 Thread via GitHub
junrao commented on code in PR #18726: URL: https://github.com/apache/kafka/pull/18726#discussion_r1972659486 ## clients/src/main/resources/common/message/FetchResponse.json: ## @@ -106,7 +106,7 @@ ]}, { "name": "PreferredReadReplica", "type": "int32", "version

Re: [PR] KAFKA-18850: Fix the docs of org.apache.kafka.automatic.config.providers [kafka]

2025-02-26 Thread via GitHub
chia7712 commented on code in PR #19039: URL: https://github.com/apache/kafka/pull/19039#discussion_r1972658599 ## clients/src/test/java/org/apache/kafka/common/config/AbstractConfigTest.java: ## @@ -450,6 +450,33 @@ public void testConfigProvidersPropsAsParam() { MockF

[jira] [Commented] (KAFKA-18870) implement describeDelegationToken for controller

2025-02-26 Thread Szu-Yung Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17930898#comment-17930898 ] Szu-Yung Wang commented on KAFKA-18870: --- Hi, may I take this? > implement describ

Re: [PR] KAFKA-18844: Stale features information in QuorumController#registerBroker [kafka]

2025-02-26 Thread via GitHub
FrankYang0529 commented on PR #18997: URL: https://github.com/apache/kafka/pull/18997#issuecomment-2686577937 @junrao updated PR description. Also, added reviewers to it. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[jira] [Commented] (KAFKA-17039) KIP-919 supports for `unregisterBroker`

2025-02-26 Thread Lan Ding (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17930900#comment-17930900 ] Lan Ding commented on KAFKA-17039: -- Hi [~frankvicky],  If this ticket is still open, ma

[jira] [Commented] (KAFKA-17037) KIP-919 supports for `describeClientQuotas` and `alterClientQuotas`

2025-02-26 Thread Lan Ding (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17930892#comment-17930892 ] Lan Ding commented on KAFKA-17037: -- Hi [~taijuwu], are you still working on this? I wou

Re: [PR] KAFKA-17607: Add CI step to verify LICENSE-binary [kafka]

2025-02-26 Thread via GitHub
xijiu commented on code in PR #18299: URL: https://github.com/apache/kafka/pull/18299#discussion_r1972668711 ## .github/workflows/build.yml: ## @@ -127,6 +127,9 @@ jobs: gradle-cache-read-only: ${{ !inputs.is-trunk }} gradle-cache-write-only: ${{ inputs.is-

[jira] [Commented] (KAFKA-17039) KIP-919 supports for `unregisterBroker`

2025-02-26 Thread TengYao Chi (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17930903#comment-17930903 ] TengYao Chi commented on KAFKA-17039: - Hi [~isding_l]  Thanks for the interest. Ho

Re: [PR] KAFKA-18646: Null records in fetch response breaks librdkafka [kafka]

2025-02-26 Thread via GitHub
ijuma commented on code in PR #18726: URL: https://github.com/apache/kafka/pull/18726#discussion_r1972672957 ## clients/src/main/resources/common/message/FetchResponse.json: ## @@ -106,7 +106,7 @@ ]}, { "name": "PreferredReadReplica", "type": "int32", "versions

[jira] [Assigned] (KAFKA-15283) Client support for OffsetFetch and OffsetCommit with topic ID

2025-02-26 Thread Lan Ding (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15283?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lan Ding reassigned KAFKA-15283: Assignee: Lan Ding (was: Lianet Magrans) > Client support for OffsetFetch and OffsetCommit with

[jira] [Assigned] (KAFKA-18877) an mechanism to find cases where we accessed variables from the wrong thread

2025-02-26 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18877?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai reassigned KAFKA-18877: -- Assignee: TengYao Chi (was: Chia-Ping Tsai) > an mechanism to find cases where we ac

Re: [PR] KAFKA-18646: Null records in fetch response breaks librdkafka [kafka]

2025-02-26 Thread via GitHub
chia7712 commented on code in PR #18726: URL: https://github.com/apache/kafka/pull/18726#discussion_r1972681634 ## clients/src/main/resources/common/message/FetchResponse.json: ## @@ -106,7 +106,7 @@ ]}, { "name": "PreferredReadReplica", "type": "int32", "versi

Re: [PR] KAFKA-18849: Add "strict min ISR" to the docs of "min.insync.replicas" [kafka]

2025-02-26 Thread via GitHub
ijuma commented on PR #19016: URL: https://github.com/apache/kafka/pull/19016#issuecomment-2686608878 I pushed a very minor tweak. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

Re: [PR] KAFKA-17645: KIP-1052: Enable warmup in producer performance test [kafka]

2025-02-26 Thread via GitHub
kirktrue commented on code in PR #17340: URL: https://github.com/apache/kafka/pull/17340#discussion_r1972681856 ## tools/src/main/java/org/apache/kafka/tools/ProducerPerformance.java: ## @@ -148,6 +175,7 @@ KafkaProducer createKafkaProducer(Properties props) { Callback cb;

Re: [PR] KAFKA-18850: Fix the docs of org.apache.kafka.automatic.config.providers [kafka]

2025-02-26 Thread via GitHub
chia7712 commented on code in PR #19039: URL: https://github.com/apache/kafka/pull/19039#discussion_r1972690127 ## clients/src/test/java/org/apache/kafka/common/config/AbstractConfigTest.java: ## @@ -450,6 +451,32 @@ public void testConfigProvidersPropsAsParam() { MockF

Re: [PR] KAFKA-18869:add remote storage threads to "Updating Thread Configs" section [kafka]

2025-02-26 Thread via GitHub
chia7712 merged PR #19037: URL: https://github.com/apache/kafka/pull/19037 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] KAFKA-18869:add remote storage threads to "Updating Thread Configs" section [kafka]

2025-02-26 Thread via GitHub
chia7712 commented on PR #19037: URL: https://github.com/apache/kafka/pull/19037#issuecomment-2686638814 cherry-pick to 4.0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[jira] [Resolved] (KAFKA-18869) add remote storage threads to "Updating Thread Configs" section

2025-02-26 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18869?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-18869. Resolution: Fixed trunk: [https://github.com/apache/kafka/commit/8bbca913efe260ba59c82480

[jira] [Resolved] (KAFKA-18875) KRaft controller does not retry registration if the first attempt times out

2025-02-26 Thread TaiJuWu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18875?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] TaiJuWu resolved KAFKA-18875. - Resolution: Duplicate > KRaft controller does not retry registration if the first attempt times out > --

Re: [PR] KAFKA-18859: honor the error message of UnregisterBrokerResponse [kafka]

2025-02-26 Thread via GitHub
chia7712 commented on code in PR #19027: URL: https://github.com/apache/kafka/pull/19027#discussion_r1972693467 ## core/src/main/scala/kafka/server/ControllerApis.scala: ## @@ -642,9 +642,11 @@ class ControllerApis( def createResponseCallback(requestThrottleMs: Int,

[jira] [Updated] (KAFKA-17651) Implement `describeUserScramCredentials`

2025-02-26 Thread TengYao Chi (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17651?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] TengYao Chi updated KAFKA-17651: Description: Currently there is no implementation for `describeUserScramCredentials` (was: Curren

[jira] [Commented] (KAFKA-17651) Implement `describeUserScramCredentials`

2025-02-26 Thread TengYao Chi (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17930930#comment-17930930 ] TengYao Chi commented on KAFKA-17651: - Hi [~isding_l]  Thanks for offering to help,

Re: [PR] KAFKA-16758: Extend Consumer#close with an option to leave the group or not [kafka]

2025-02-26 Thread via GitHub
frankvicky commented on code in PR #17614: URL: https://github.com/apache/kafka/pull/17614#discussion_r1972757524 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java: ## @@ -1151,31 +1153,28 @@ protected void handlePollTimeoutExpiry() {

Re: [PR] KAFKA-18780: Extend RetriableException related exceptions [kafka]

2025-02-26 Thread via GitHub
k-raina commented on code in PR #19020: URL: https://github.com/apache/kafka/pull/19020#discussion_r1971936154 ## clients/src/test/java/org/apache/kafka/common/errors/TransactionExceptionHierarchyTest.java: ## @@ -0,0 +1,60 @@ +/* + * Licensed to the Apache Software Foundation (

[jira] [Created] (KAFKA-18875) KRaft controller does not retry registration if the first attempt times out

2025-02-26 Thread Daniel Fonai (Jira)
Daniel Fonai created KAFKA-18875: Summary: KRaft controller does not retry registration if the first attempt times out Key: KAFKA-18875 URL: https://issues.apache.org/jira/browse/KAFKA-18875 Project:

[jira] [Commented] (KAFKA-18874) KRaft controller does not retry registration if the first attempt times out

2025-02-26 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17930751#comment-17930751 ] Ismael Juma commented on KAFKA-18874: - Thanks for the report. Can you specify the ve

Re: [PR] KAFKA-18813: ConsumerGroupHeartbeat API and ConsumerGroupDescribe API must check topic describe [kafka]

2025-02-26 Thread via GitHub
lianetm merged PR #18989: URL: https://github.com/apache/kafka/pull/18989 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

Re: [PR] KAFKA-18844: Stale features information in QuorumController#registerBroker [kafka]

2025-02-26 Thread via GitHub
mumrah commented on PR #18997: URL: https://github.com/apache/kafka/pull/18997#issuecomment-2685820634 Regarding: https://github.com/user-attachments/assets/096cf482-4701-4219-a8eb-c5613adfb390"; /> This was added in #18985 as part of the merge queue effort. It is not yet require

Re: [PR] KAFKA-18844: Stale features information in QuorumController#registerBroker [kafka]

2025-02-26 Thread via GitHub
junrao commented on PR #18997: URL: https://github.com/apache/kafka/pull/18997#issuecomment-2685839532 @FrankYang0529 : Thanks for the updated description. Just a minor comment. This makes finalized features may be stale when processing registerBroker event. => This may make finaliz

[jira] [Updated] (KAFKA-18873) Incorrect error message for max.in.flight.requests.per.connection when using transactional producer.

2025-02-26 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18873?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-18873: -- Component/s: producer > Incorrect error message for max.in.flight.requests.per.connection when using

[jira] [Created] (KAFKA-18876) 4.0 documentation improvement

2025-02-26 Thread Jun Rao (Jira)
Jun Rao created KAFKA-18876: --- Summary: 4.0 documentation improvement Key: KAFKA-18876 URL: https://issues.apache.org/jira/browse/KAFKA-18876 Project: Kafka Issue Type: Improvement Affects Versi

Re: [PR] WIP Investigate OOM [kafka]

2025-02-26 Thread via GitHub
mumrah commented on code in PR #19031: URL: https://github.com/apache/kafka/pull/19031#discussion_r1972112034 ## build.gradle: ## @@ -54,7 +54,7 @@ ext { buildVersionFileName = "kafka-version.properties" defaultMaxHeapSize = "2g" - defaultJvmArgs = ["-Xss4m", "-XX:+UseP

[jira] [Updated] (KAFKA-16092) Queues for Kafka

2025-02-26 Thread Andrew Schofield (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16092?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Schofield updated KAFKA-16092: - Fix Version/s: (was: 4.1.0) > Queues for Kafka > > >

[jira] [Created] (KAFKA-18874) KRaft controller does not retry registration if the first attempt times out

2025-02-26 Thread Daniel Fonai (Jira)
Daniel Fonai created KAFKA-18874: Summary: KRaft controller does not retry registration if the first attempt times out Key: KAFKA-18874 URL: https://issues.apache.org/jira/browse/KAFKA-18874 Project:

Re: [PR] WIP Investigate OOM [kafka]

2025-02-26 Thread via GitHub
mumrah commented on PR #19031: URL: https://github.com/apache/kafka/pull/19031#issuecomment-2685589737 It looks like the UserQuotaTest is the likely culprit. From https://github.com/apache/kafka/actions/runs/13523225366/job/37791507296 ``` Gradle Test Run :core:test > Gradle Tes

Re: [PR] KAFKA-18780: Extend RetriableException related exceptions [kafka]

2025-02-26 Thread via GitHub
k-raina commented on code in PR #19020: URL: https://github.com/apache/kafka/pull/19020#discussion_r1971934155 ## clients/src/test/java/org/apache/kafka/common/errors/TransactionExceptionHierarchyTest.java: ## @@ -0,0 +1,60 @@ +/* + * Licensed to the Apache Software Foundation (

Re: [PR] KAFKA-17565: Move MetadataCache interface to metadata module [kafka]

2025-02-26 Thread via GitHub
FrankYang0529 commented on PR #18801: URL: https://github.com/apache/kafka/pull/18801#issuecomment-2685571786 @mumrah I update benchmark to PR description. The result is a little different from yours. The difference between trunk and branch results on my laptop is close, so I think the resu

Re: [PR] KAFKA-18780: Extend RetriableException related exceptions [kafka]

2025-02-26 Thread via GitHub
k-raina commented on code in PR #19020: URL: https://github.com/apache/kafka/pull/19020#discussion_r1971934155 ## clients/src/test/java/org/apache/kafka/common/errors/TransactionExceptionHierarchyTest.java: ## @@ -0,0 +1,60 @@ +/* + * Licensed to the Apache Software Foundation (

[jira] [Updated] (KAFKA-18723) KRaft must handle corrupted records in the fetch response

2025-02-26 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-18723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] José Armando García Sancio updated KAFKA-18723: --- Fix Version/s: 4.0.1 > KRaft must handle corrupted records in the fe

  1   2   >