junrao commented on code in PR #18726:
URL: https://github.com/apache/kafka/pull/18726#discussion_r1972659486
##########
clients/src/main/resources/common/message/FetchResponse.json:
##########
@@ -106,7 +106,7 @@
]},
{ "name": "PreferredReadReplica", "type": "int32", "versions": "11+",
"default": "-1", "ignorable": false, "entityType": "brokerId",
"about": "The preferred read replica for the consumer to use on its
next fetch request."},
- { "name": "Records", "type": "records", "versions": "0+",
"nullableVersions": "0+", "about": "The record data."}
Review Comment:
My point is that before 4.0, the server could already include null records
for certain errors. So the client already needs to deal with that. If it
doesn't, it's a bug in the client that needs to be fixed. Once the client is
fixed, it's not necessary to make the records non-null. We could consider
changing it to be non-null, but it would be useful to think through if this
change should be applied consistently to other places such as
ShareFetchResponse and ProduceRequest.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
