chia7712 commented on code in PR #18726: URL: https://github.com/apache/kafka/pull/18726#discussion_r1972681634
########## clients/src/main/resources/common/message/FetchResponse.json: ########## @@ -106,7 +106,7 @@ ]}, { "name": "PreferredReadReplica", "type": "int32", "versions": "11+", "default": "-1", "ignorable": false, "entityType": "brokerId", "about": "The preferred read replica for the consumer to use on its next fetch request."}, - { "name": "Records", "type": "records", "versions": "0+", "nullableVersions": "0+", "about": "The record data."} Review Comment: > are you saying that we actually don't end up with null records in that case? A 3.9 server does return null records in extremely rare cases, but we don't end up with null records for newer clients as down-conversion does not happen. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org