m1a2st commented on code in PR #19034:
URL: https://github.com/apache/kafka/pull/19034#discussion_r1971614754
##########
tests/kafkatest/services/kafka/kafka.py:
##########
@@ -1362,7 +1356,7 @@ def alter_message_format(self, topic, msg_format_version,
node=None):
def kafka_acls_cmd_with_optional_security_settings(self, node,
force_use_zk_connection, kafka_security_protocol = None,
override_command_config = None):
if self.quorum_info.using_kraft and not self.quorum_info.has_brokers:
raise Exception("Must invoke kafka-acls against a broker, not a
KRaft controller")
- force_use_zk_connection = force_use_zk_connection or not
self.all_nodes_acl_command_supports_bootstrap_server
+ force_use_zk_connection = force_use_zk_connection
Review Comment:
may be we can remove this parameter, and clean up the if condition.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
