Rancho-7 commented on code in PR #19039:
URL: https://github.com/apache/kafka/pull/19039#discussion_r1971671660


##########
clients/src/test/java/org/apache/kafka/common/config/AbstractConfigTest.java:
##########
@@ -450,6 +450,33 @@ public void testConfigProvidersPropsAsParam() {
         MockFileConfigProvider.assertClosed(id);
     }
 
+    @Test
+    public void testAutomaticConfigProvidersWithFullClassName() {
+        Properties props = new Properties();
+        props.put("config.providers", "file");
+        props.put("config.providers.file.class", 
MockFileConfigProvider.class.getName());
+        String id = UUID.randomUUID().toString();

Review Comment:
   Thanks for the review! I have some questions that I noticed we use Java UUID 
in some other tests in this file.Should we keep the same approach or not?
   
https://github.com/apache/kafka/blob/4b5a16bf6ffcb4322d7c5b35a484ff914397909c/clients/src/test/java/org/apache/kafka/common/config/AbstractConfigTest.java#L544



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to