frankvicky commented on code in PR #17549:
URL: https://github.com/apache/kafka/pull/17549#discussion_r1820686572
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java:
##
@@ -944,23 +941,20 @@ public boolean sameRequest(final OffsetFetch
frankvicky commented on code in PR #17549:
URL: https://github.com/apache/kafka/pull/17549#discussion_r1820686572
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java:
##
@@ -944,23 +941,20 @@ public boolean sameRequest(final OffsetFetch
frankvicky commented on code in PR #17549:
URL: https://github.com/apache/kafka/pull/17549#discussion_r1820686572
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java:
##
@@ -944,23 +941,20 @@ public boolean sameRequest(final OffsetFetch
frankvicky commented on code in PR #17549:
URL: https://github.com/apache/kafka/pull/17549#discussion_r1820699580
##
clients/src/main/resources/common/message/ConsumerGroupHeartbeatResponse.json:
##
@@ -39,7 +39,7 @@
{ "name": "ErrorMessage", "type": "string", "versions": "
frankvicky commented on code in PR #17549:
URL: https://github.com/apache/kafka/pull/17549#discussion_r1820868382
##
core/src/test/scala/unit/kafka/server/ConsumerGroupHeartbeatRequestTest.scala:
##
@@ -36,54 +35,68 @@ import scala.collection.Map
import scala.jdk.CollectionConv
[
https://issues.apache.org/jira/browse/KAFKA-17519?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lianet Magrans updated KAFKA-17519:
---
Fix Version/s: 4.0.0
> Define and validate correctness of Consumer.close() and its timeout w
[
https://issues.apache.org/jira/browse/KAFKA-15247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17893807#comment-17893807
]
Dave Crighton commented on KAFKA-15247:
---
Updating to major as the cost of maintain
OmniaGM commented on code in PR #15968:
URL: https://github.com/apache/kafka/pull/15968#discussion_r1820876284
##
core/src/main/scala/kafka/server/KafkaApis.scala:
##
@@ -2468,7 +2483,7 @@ class KafkaApis(val requestChannel: RequestChannel,
} else {
// Ot
mumrah commented on PR #17397:
URL: https://github.com/apache/kafka/pull/17397#issuecomment-2444352725
Verified that things look good on trunk.
When comparing the two test catalogs generated before and after [this
commit](https://github.com/apache/kafka/commit/4817eb9227bc54225f9d24d
peterxcli commented on code in PR #17444:
URL: https://github.com/apache/kafka/pull/17444#discussion_r1820799880
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/Utils.java:
##
@@ -235,4 +238,20 @@ public static ApiMessage
messageOrNull(ApiMessageAndVersion
[
https://issues.apache.org/jira/browse/KAFKA-16966?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lianet Magrans updated KAFKA-16966:
---
Fix Version/s: 4.0.0
> Allow offset commit fetch to reuse previous request if partitions are
mumrah opened a new pull request, #17624:
URL: https://github.com/apache/kafka/pull/17624
Second part of #17397. This patch will take the extracted test catalog
generate on trunk and commit it to an orphaned Git branch in the Apache Kafka
repository
--
This is an automated message from t
[
https://issues.apache.org/jira/browse/KAFKA-17892?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mickael Maison updated KAFKA-17892:
---
Fix Version/s: 4.0.0
> Update README after migration to log4j2
> ---
mimaison commented on code in PR #17373:
URL: https://github.com/apache/kafka/pull/17373#discussion_r1820546264
##
config/log4j2.properties:
##
@@ -0,0 +1,163 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOT
mimaison merged PR #17600:
URL: https://github.com/apache/kafka/pull/17600
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
lucasbru merged PR #17433:
URL: https://github.com/apache/kafka/pull/17433
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
lucasbru commented on code in PR #17433:
URL: https://github.com/apache/kafka/pull/17433#discussion_r1820817284
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/streams/StreamsGroupInitializeResult.java:
##
@@ -0,0 +1,74 @@
+/*
+ * Licensed to the Apache Sof
lucasbru commented on code in PR #17433:
URL: https://github.com/apache/kafka/pull/17433#discussion_r1820808722
##
streams/src/test/resources/log4j.properties:
##
@@ -29,6 +29,8 @@ log4j.logger.org.apache.kafka.clients.consumer=INFO
log4j.logger.org.apache.kafka.clients.produce
peterxcli commented on code in PR #17444:
URL: https://github.com/apache/kafka/pull/17444#discussion_r1820799880
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/Utils.java:
##
@@ -235,4 +238,20 @@ public static ApiMessage
messageOrNull(ApiMessageAndVersion
[
https://issues.apache.org/jira/browse/KAFKA-17891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17893829#comment-17893829
]
Dave Crighton commented on KAFKA-17891:
---
Fantastic news Mickael. We will skip 3.8.
lucasbru commented on code in PR #17433:
URL: https://github.com/apache/kafka/pull/17433#discussion_r1820813476
##
core/src/main/scala/kafka/server/AutoTopicCreationManager.scala:
##
@@ -159,8 +192,8 @@ class DefaultAutoTopicCreationManager(
}
private def sendCreateTopic
FrankYang0529 commented on code in PR #17444:
URL: https://github.com/apache/kafka/pull/17444#discussion_r1820813089
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/Utils.java:
##
@@ -235,4 +238,20 @@ public static ApiMessage
messageOrNull(ApiMessageAndVer
[
https://issues.apache.org/jira/browse/KAFKA-17891?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mickael Maison resolved KAFKA-17891.
Resolution: Duplicate
> Kafka 3.8 no longer works on z/OS due to hard dependency on zstd-j
[
https://issues.apache.org/jira/browse/KAFKA-17891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17893832#comment-17893832
]
Mickael Maison commented on KAFKA-17891:
Ok, so I'll mark this ticket as a dupli
FrankYang0529 commented on code in PR #17444:
URL: https://github.com/apache/kafka/pull/17444#discussion_r1820813089
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/Utils.java:
##
@@ -235,4 +238,20 @@ public static ApiMessage
messageOrNull(ApiMessageAndVer
[
https://issues.apache.org/jira/browse/KAFKA-17719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17893838#comment-17893838
]
Daniel Urban commented on KAFKA-17719:
--
I'm still thinking about a possible solutio
mimaison commented on code in PR #17373:
URL: https://github.com/apache/kafka/pull/17373#discussion_r1820849781
##
config/log4j2.properties:
##
@@ -0,0 +1,163 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOT
lucasbru merged PR #17091:
URL: https://github.com/apache/kafka/pull/17091
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
dajac commented on code in PR #17444:
URL: https://github.com/apache/kafka/pull/17444#discussion_r1820345424
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/modern/TopicMetadata.java:
##
@@ -41,10 +41,25 @@ public class TopicMetadata {
*/
private
dajac commented on code in PR #17444:
URL: https://github.com/apache/kafka/pull/17444#discussion_r1820345424
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/modern/TopicMetadata.java:
##
@@ -41,10 +41,25 @@ public class TopicMetadata {
*/
private
dajac commented on code in PR #17444:
URL: https://github.com/apache/kafka/pull/17444#discussion_r1820352389
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/modern/TopicMetadata.java:
##
@@ -41,10 +41,25 @@ public class TopicMetadata {
*/
private
Mickael Maison created KAFKA-17890:
--
Summary: Move DelayedOperationPurgatory to server-common
Key: KAFKA-17890
URL: https://issues.apache.org/jira/browse/KAFKA-17890
Project: Kafka
Issue Typ
dajac commented on code in PR #17444:
URL: https://github.com/apache/kafka/pull/17444#discussion_r1820753168
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/Utils.java:
##
@@ -235,4 +238,20 @@ public static ApiMessage
messageOrNull(ApiMessageAndVersion api
frankvicky commented on code in PR #17549:
URL: https://github.com/apache/kafka/pull/17549#discussion_r1820699580
##
clients/src/main/resources/common/message/ConsumerGroupHeartbeatResponse.json:
##
@@ -39,7 +39,7 @@
{ "name": "ErrorMessage", "type": "string", "versions": "
frankvicky commented on code in PR #17549:
URL: https://github.com/apache/kafka/pull/17549#discussion_r1820756222
##
core/src/test/scala/unit/kafka/server/ConsumerGroupHeartbeatRequestTest.scala:
##
@@ -36,54 +35,68 @@ import scala.collection.Map
import scala.jdk.CollectionConv
ppkarwasz commented on code in PR #17373:
URL: https://github.com/apache/kafka/pull/17373#discussion_r1820760649
##
config/log4j2.properties:
##
@@ -0,0 +1,163 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NO
OmniaGM commented on PR #15968:
URL: https://github.com/apache/kafka/pull/15968#issuecomment-2443926654
Hi @junrao sorry for the delayed respond. I will first fix the conflict with
`ReplicaManager` as new class `TopicOptionalIdPartition` as part of
https://github.com/apache/kafka/pull/17437
[
https://issues.apache.org/jira/browse/KAFKA-17875?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mickael Maison resolved KAFKA-17875.
Fix Version/s: 4.0.0
Resolution: Fixed
> Align KRaft controller count recommendatio
jlprat opened a new pull request, #17623:
URL: https://github.com/apache/kafka/pull/17623
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of testing
[
https://issues.apache.org/jira/browse/KAFKA-17891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17893823#comment-17893823
]
Mickael Maison commented on KAFKA-17891:
In Kafka 3.8.0, the zstd and lz4 librar
[
https://issues.apache.org/jira/browse/KAFKA-17719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17893727#comment-17893727
]
Daniel Urban commented on KAFKA-17719:
--
[~cmukka20] I think your analysis is correc
[
https://issues.apache.org/jira/browse/KAFKA-17719?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Daniel Urban reassigned KAFKA-17719:
Assignee: Daniel Urban
> Connect may fail to start tasks when reading from a compacted co
ppkarwasz commented on PR #17588:
URL: https://github.com/apache/kafka/pull/17588#issuecomment-2444020233
Thanks, I opened a [thread on
`dev@kafka`](https://lists.apache.org/thread/9logy8yv3v3tom8kd45sq01nl2qfxcx7).
--
This is an automated message from the Apache Git Service.
To respond t
frankvicky commented on code in PR #17549:
URL: https://github.com/apache/kafka/pull/17549#discussion_r1820671218
##
core/src/test/scala/unit/kafka/server/ConsumerGroupHeartbeatRequestTest.scala:
##
@@ -36,54 +35,68 @@ import scala.collection.Map
import scala.jdk.CollectionConv
frankvicky commented on code in PR #17549:
URL: https://github.com/apache/kafka/pull/17549#discussion_r1820674708
##
core/src/test/scala/unit/kafka/server/ConsumerProtocolMigrationTest.scala:
##
@@ -242,50 +243,54 @@ class ConsumerProtocolMigrationTest(cluster:
ClusterInstance)
chia7712 commented on code in PR #17444:
URL: https://github.com/apache/kafka/pull/17444#discussion_r1820684694
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/Utils.java:
##
@@ -235,4 +238,20 @@ public static ApiMessage
messageOrNull(ApiMessageAndVersion
FrankYang0529 commented on code in PR #17444:
URL: https://github.com/apache/kafka/pull/17444#discussion_r1820720961
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/Utils.java:
##
@@ -235,4 +238,20 @@ public static ApiMessage
messageOrNull(ApiMessageAndVer
FrankYang0529 commented on code in PR #17444:
URL: https://github.com/apache/kafka/pull/17444#discussion_r1820720961
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/Utils.java:
##
@@ -235,4 +238,20 @@ public static ApiMessage
messageOrNull(ApiMessageAndVer
Dave Crighton created KAFKA-17891:
-
Summary: Kafka 3.8 no longer works on z/OS due to hard dependency
on zstd-jni
Key: KAFKA-17891
URL: https://issues.apache.org/jira/browse/KAFKA-17891
Project: Kafka
[
https://issues.apache.org/jira/browse/KAFKA-15247?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dave Crighton updated KAFKA-15247:
--
Priority: Major (was: Minor)
> OutOfMemoryError in SaslClientAuthenticator during server rest
dajac commented on code in PR #17549:
URL: https://github.com/apache/kafka/pull/17549#discussion_r1820736948
##
core/src/test/scala/unit/kafka/server/ConsumerGroupHeartbeatRequestTest.scala:
##
@@ -36,54 +35,68 @@ import scala.collection.Map
import scala.jdk.CollectionConverter
chia7712 commented on code in PR #17444:
URL: https://github.com/apache/kafka/pull/17444#discussion_r1820899350
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/Utils.java:
##
@@ -235,4 +238,20 @@ public static ApiMessage
messageOrNull(ApiMessageAndVersion
[
https://issues.apache.org/jira/browse/KAFKA-15961?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Apoorv Mittal resolved KAFKA-15961.
---
Resolution: Won't Fix
Marking ZK failed test as won't fix.
> Flaky test: testTopicIdPersis
jlprat opened a new pull request, #17629:
URL: https://github.com/apache/kafka/pull/17629
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade no
[
https://issues.apache.org/jira/browse/KAFKA-17893?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
A. Sophie Blee-Goldman updated KAFKA-17893:
---
Labels: needs-kip (was: )
> Support record keys in the foreignKeyExtractor
[
https://issues.apache.org/jira/browse/KAFKA-17893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17893985#comment-17893985
]
Peter Lee commented on KAFKA-17893:
---
Hi, Can I work on this issue?
> Support record k
artemlivshits commented on code in PR #17402:
URL: https://github.com/apache/kafka/pull/17402#discussion_r1821566565
##
core/src/main/scala/kafka/coordinator/transaction/TransactionMetadata.scala:
##
@@ -346,14 +346,14 @@ private[transaction] class TransactionMetadata(val
trans
wperlichek opened a new pull request, #17631:
URL: https://github.com/apache/kafka/pull/17631
Found a spelling typo when going through the Docker Compose examples README.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify t
rreddy-22 commented on code in PR #17402:
URL: https://github.com/apache/kafka/pull/17402#discussion_r1821543141
##
clients/src/test/java/org/apache/kafka/clients/producer/internals/TransactionManagerTest.java:
##
@@ -2980,6 +2980,66 @@ public void
testEpochBumpAfterLastInfligh
lianetm commented on PR #16686:
URL: https://github.com/apache/kafka/pull/16686#issuecomment-2445322201
Hey @kirktrue , sounds mostly fair to me, one question and one proposal to
move on from here :)
Question is why 8?:
> 8: The application thread will not wait for confirmation th
[
https://issues.apache.org/jira/browse/KAFKA-17898?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ritika Reddy updated KAFKA-17898:
-
Description:
With KAFKA-14562, we implemented epoch bump on both the client and the server.
Men
[
https://issues.apache.org/jira/browse/KAFKA-17898?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ritika Reddy updated KAFKA-17898:
-
Description:
With KAFKA-14562, we implemented epoch bump on both the client and the server.
Now
kirktrue commented on PR #17581:
URL: https://github.com/apache/kafka/pull/17581#issuecomment-2445529054
@chia7712—do you have any advice for the best way to arrange these changes
for review?
--
This is an automated message from the Apache Git Service.
To respond to the message, please lo
[
https://issues.apache.org/jira/browse/KAFKA-17826?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai updated KAFKA-17826:
---
Labels: need-kip (was: )
> Consumer#offsetsForTimes should not return null value
>
[
https://issues.apache.org/jira/browse/KAFKA-17895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17893981#comment-17893981
]
A. Sophie Blee-Goldman commented on KAFKA-17895:
My guess is that this w
mumrah commented on PR #17627:
URL: https://github.com/apache/kafka/pull/17627#issuecomment-2445360036
Here is a commit generated with this PR
https://github.com/apache/kafka/commit/6f0b61bdaa5ccf900e41aba7f3f1cd37065e5808
It is missing a number of tests since several tests were not r
jolshan commented on code in PR #17402:
URL: https://github.com/apache/kafka/pull/17402#discussion_r1821581624
##
core/src/main/scala/kafka/coordinator/transaction/TransactionMetadata.scala:
##
@@ -346,14 +346,14 @@ private[transaction] class TransactionMetadata(val
transaction
cmccabe commented on code in PR #17601:
URL: https://github.com/apache/kafka/pull/17601#discussion_r1821611120
##
tests/kafkatest/tests/core/compatibility_test_new_broker_test.py:
##
@@ -48,7 +43,6 @@ def setUp(self):
@cluster(num_nodes=6)
@matrix(producer_version=[str
cmccabe commented on code in PR #17601:
URL: https://github.com/apache/kafka/pull/17601#discussion_r1821613856
##
tests/kafkatest/tests/streams/streams_application_upgrade_test.py:
##
@@ -1,306 +0,0 @@
-# Licensed to the Apache Software Foundation (ASF) under one or more
-# cont
cmccabe commented on code in PR #17601:
URL: https://github.com/apache/kafka/pull/17601#discussion_r1821608094
##
tests/kafkatest/tests/client/truncation_test.py:
##
@@ -1,149 +0,0 @@
-# Licensed to the Apache Software Foundation (ASF) under one or more
-# contributor license ag
cmccabe commented on code in PR #17601:
URL: https://github.com/apache/kafka/pull/17601#discussion_r1821613581
##
tests/kafkatest/tests/core/throttling_test.py:
##
@@ -1,180 +0,0 @@
-# Licensed to the Apache Software Foundation (ASF) under one or more
-# contributor license agre
cmccabe commented on PR #17601:
URL: https://github.com/apache/kafka/pull/17601#issuecomment-2445457973
We can't just remove tests that don't specify a quorum. Those have to be
converted to use kraft. That may be something that we do in a separate PR, but
we do still have to do it.
--
Th
cmccabe commented on code in PR #17601:
URL: https://github.com/apache/kafka/pull/17601#discussion_r1821609247
##
tests/kafkatest/tests/connect/connect_distributed_test.py:
##
@@ -998,54 +858,6 @@ def test_transformations(self, connect_protocol,
metadata_quorum, use_new_coordi
cmccabe commented on code in PR #17601:
URL: https://github.com/apache/kafka/pull/17601#discussion_r1821613205
##
tests/kafkatest/tests/core/security_rolling_upgrade_test.py:
##
@@ -1,189 +0,0 @@
-# Licensed to the Apache Software Foundation (ASF) under one or more
-# contributo
cmccabe commented on code in PR #17601:
URL: https://github.com/apache/kafka/pull/17601#discussion_r1821612629
##
tests/kafkatest/tests/core/downgrade_test.py:
##
@@ -1,166 +0,0 @@
-# Licensed to the Apache Software Foundation (ASF) under one or more
-# contributor license agree
rreddy-22 commented on code in PR #17402:
URL: https://github.com/apache/kafka/pull/17402#discussion_r1821618006
##
core/src/main/scala/kafka/coordinator/transaction/TransactionMetadata.scala:
##
@@ -346,14 +346,14 @@ private[transaction] class TransactionMetadata(val
transacti
cmccabe commented on PR #17601:
URL: https://github.com/apache/kafka/pull/17601#issuecomment-2445464791
* Obviously cases where we test "the old client" can be removed (I think you
already did this) :) I actually thought we already did this when we removed the
old client, but I guess it got
cmccabe commented on code in PR #17601:
URL: https://github.com/apache/kafka/pull/17601#discussion_r1821609878
##
tests/kafkatest/tests/connect/connect_test.py:
##
@@ -57,23 +56,15 @@ class ConnectStandaloneFileTest(Test):
def __init__(self, test_context):
super(
[
https://issues.apache.org/jira/browse/KAFKA-17804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17894034#comment-17894034
]
Jun Rao commented on KAFKA-17804:
-
[~kangning] : Yes, you are right. We can only skip th
cmccabe commented on code in PR #17601:
URL: https://github.com/apache/kafka/pull/17601#discussion_r1821604696
##
tests/kafkatest/services/kafka/quorum.py:
##
@@ -21,18 +21,18 @@
# How we will parameterize tests that exercise all quorum styles
# [“ZK”, “ISOLATED_KRAFT”, "COM
cmccabe commented on code in PR #17601:
URL: https://github.com/apache/kafka/pull/17601#discussion_r1821604393
##
tests/kafkatest/services/kafka/kafka.py:
##
@@ -548,7 +548,7 @@ def security_config(self):
interbroker_security_protocol_to_use=SecurityConfig.PLAIN
cmccabe commented on code in PR #17601:
URL: https://github.com/apache/kafka/pull/17601#discussion_r1821605952
##
tests/kafkatest/tests/client/client_compatibility_features_test.py:
##
@@ -107,29 +104,7 @@ def invoke_compatibility_program(self, features):
@cluster(num_nod
cmccabe commented on code in PR #17601:
URL: https://github.com/apache/kafka/pull/17601#discussion_r1821606562
##
tests/kafkatest/tests/client/client_compatibility_produce_consume_test.py:
##
@@ -48,37 +46,13 @@ def __init__(self, test_context):
self.messages_per_produc
cmccabe commented on code in PR #17601:
URL: https://github.com/apache/kafka/pull/17601#discussion_r1821608441
##
tests/kafkatest/tests/connect/connect_distributed_test.py:
##
@@ -460,122 +442,6 @@ def test_pause_state_persistent(self,
exactly_once_source, connect_protocol, met
cmccabe commented on code in PR #17604:
URL: https://github.com/apache/kafka/pull/17604#discussion_r1821602257
##
metadata/src/test/java/org/apache/kafka/controller/ReplicationControlManagerTest.java:
##
@@ -565,6 +565,42 @@ public void configure(Map configs) {
}
}
cmccabe commented on code in PR #17601:
URL: https://github.com/apache/kafka/pull/17601#discussion_r1821607886
##
tests/kafkatest/tests/client/message_format_change_test.py:
##
@@ -1,106 +0,0 @@
-# Licensed under the Apache License, Version 2.0 (the "License");
-# you may not us
[
https://issues.apache.org/jira/browse/KAFKA-17826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17894043#comment-17894043
]
Chia-Ping Tsai commented on KAFKA-17826:
{quote}
do we need a KIP to make the c
xijiu closed pull request #17563: KAFKA-17804: (DO NOT MERGE)Optimize
ReplicaManager.completeDelayedOperationsWhenNotPartitionLeader
URL: https://github.com/apache/kafka/pull/17563
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
cmccabe commented on code in PR #17601:
URL: https://github.com/apache/kafka/pull/17601#discussion_r1821612914
##
tests/kafkatest/tests/core/group_mode_transactions_test.py:
##
@@ -1,331 +0,0 @@
-# Licensed to the Apache Software Foundation (ASF) under one or more
-# contributor
cmccabe commented on code in PR #17601:
URL: https://github.com/apache/kafka/pull/17601#discussion_r1821611120
##
tests/kafkatest/tests/core/compatibility_test_new_broker_test.py:
##
@@ -48,7 +43,6 @@ def setUp(self):
@cluster(num_nodes=6)
@matrix(producer_version=[str
bbejeck opened a new pull request, #17630:
URL: https://github.com/apache/kafka/pull/17630
This is a stacked PR based off #17021 and should only get reviewed and
merged after #17021 is merged
*Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or
Ritika Reddy created KAFKA-17898:
Summary: Seperate Epoch Bump Scenarios and Error Handling in TV2
Key: KAFKA-17898
URL: https://issues.apache.org/jira/browse/KAFKA-17898
Project: Kafka
Issue
jolshan commented on code in PR #17402:
URL: https://github.com/apache/kafka/pull/17402#discussion_r1821572727
##
core/src/main/scala/kafka/coordinator/transaction/TransactionMetadata.scala:
##
@@ -346,14 +346,14 @@ private[transaction] class TransactionMetadata(val
transaction
[
https://issues.apache.org/jira/browse/KAFKA-17898?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ritika Reddy updated KAFKA-17898:
-
Description:
With KAFKA-14562, we implemented epoch bump on both the client and the server.
Now
[
https://issues.apache.org/jira/browse/KAFKA-17898?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ritika Reddy updated KAFKA-17898:
-
Description:
With KAFKA-14562, we implemented epoch bump on both the client and the server.
Now
[
https://issues.apache.org/jira/browse/KAFKA-17898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17894011#comment-17894011
]
Ritika Reddy commented on KAFKA-17898:
--
https://issues.apache.org/jira/browse/KAFKA
cmccabe commented on code in PR #17601:
URL: https://github.com/apache/kafka/pull/17601#discussion_r1821607544
##
tests/kafkatest/tests/client/quota_test.py:
##
@@ -1,237 +0,0 @@
-# Licensed to the Apache Software Foundation (ASF) under one or more
-# contributor license agreeme
MahsaSeifikar opened a new pull request, #17632:
URL: https://github.com/apache/kafka/pull/17632
MINOR: Correct error message in reassign_partitions_test.py
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage a
junrao commented on code in PR #16842:
URL: https://github.com/apache/kafka/pull/16842#discussion_r1821630956
##
core/src/main/java/kafka/server/share/SharePartitionManager.java:
##
@@ -490,6 +497,30 @@ public void acknowledgeSessionUpdate(String groupId,
ShareRequestMetadata r
lianetm commented on code in PR #17549:
URL: https://github.com/apache/kafka/pull/17549#discussion_r1821015724
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java:
##
@@ -944,23 +941,20 @@ public boolean sameRequest(final OffsetFetchReq
1 - 100 of 174 matches
Mail list logo
