frankvicky commented on code in PR #17549:
URL: https://github.com/apache/kafka/pull/17549#discussion_r1820674708
##########
core/src/test/scala/unit/kafka/server/ConsumerProtocolMigrationTest.scala:
##########
@@ -242,50 +243,54 @@ class ConsumerProtocolMigrationTest(cluster:
ClusterInstance) extends GroupCoord
assignment = assignment(List(0, 1, 2))
)
- // The joining request with a consumer group member 2 is accepted.
- val memberId2 = consumerGroupHeartbeat(
- groupId = groupId,
- rebalanceTimeoutMs = 5 * 60 * 1000,
- subscribedTopicNames = List("foo"),
- topicPartitions = List.empty,
- expectedError = Errors.NONE
- ).memberId
-
- // The group has become a consumer group.
- assertEquals(
- List(
- new ListGroupsResponseData.ListedGroup()
- .setGroupId(groupId)
- .setProtocolType("consumer")
- .setGroupState(ConsumerGroupState.RECONCILING.toString)
- .setGroupType(Group.GroupType.CONSUMER.toString)
- ),
- listGroups(
- statesFilter = List.empty,
- typesFilter = List(Group.GroupType.CONSUMER.toString)
+ for (version <- ApiKeys.CONSUMER_GROUP_HEARTBEAT.oldestVersion() to
ApiKeys.CONSUMER_GROUP_HEARTBEAT.latestVersion(isUnstableApiEnabled)) {
Review Comment:
I have test all the versions in `ConsumerGroupHeartbeatRequestTest` but I
have a question, see:
https://github.com/apache/kafka/pull/17549#discussion_r1820671218
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
