dajac commented on code in PR #17444: URL: https://github.com/apache/kafka/pull/17444#discussion_r1820345424
########## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/modern/TopicMetadata.java: ########## @@ -41,10 +41,25 @@ public class TopicMetadata { */ private final int numPartitions; + /** + * Map of every partition Id to a set of its rack Ids, if they exist. + * If rack information is unavailable for all partitions, this is an empty map. + */ + private final Map<Integer, Set<String>> partitionRacks; Review Comment: @chia7712 This is not how we have designed it. The group epoch is bumped to trigger a re-computation of the target assignment. If the assignment does not change, only the epoch of the target assignment is bump. End of the operation. We don't need to compare assignments to not bump the group epoch is the first place. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org