peterxcli commented on code in PR #17444:
URL: https://github.com/apache/kafka/pull/17444#discussion_r1820799880
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/Utils.java:
##########
@@ -235,4 +238,20 @@ public static ApiMessage
messageOrNull(ApiMessageAndVersion apiMessageAndVersion
return apiMessageAndVersion.message();
}
}
+
+ public static long hashSubscriptionMetadata(Map<String, TopicMetadata>
subscriptionMetadata) {
Review Comment:
@FrankYang0529
Is he saying that whenever
[`consumerGroupHeartbeat`](https://github.com/frankyang0529/kafka/blob/2ff4c89b8e88ec1170ab698cb016e33564724909/group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java#L1796-L1813)
is called, it’s necessary to recompute the hash for the incoming `<groupName,
topicMetadata>` map? This would mean recalculating the hash for either each
group name’s individual metadata or for the entire map, which is indeed quite
time-consuming.
upd: Sorry, just ignore this comment cause I totally mistake this issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
