frankvicky commented on code in PR #17549:
URL: https://github.com/apache/kafka/pull/17549#discussion_r1820699580


##########
clients/src/main/resources/common/message/ConsumerGroupHeartbeatResponse.json:
##########
@@ -39,7 +39,7 @@
     { "name": "ErrorMessage", "type": "string", "versions": "0+", 
"nullableVersions": "0+", "default": "null",
       "about": "The top-level error message, or null if there was no error." },
     { "name": "MemberId", "type": "string", "versions": "0+", 
"nullableVersions": "0+", "default": "null",
-      "about": "The member id generated by the coordinator. Only provided when 
the member joins with MemberEpoch == 0." },
+      "about": "The member id is generated by the consumer and provided by the 
consumer for all requests." },

Review Comment:
   ~hmm... I feel that we don't need to specify the behavior in version `0` 
since it's an unstable version.~
   ~If users are using the 4.0 release, they should have the latest behavior.~
   Update: I think we should precise it since it's response from server.
   
   > However, in version 1+, it is basically the value received from the 
consumer?
   
   I think yes.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to