[
https://issues.apache.org/jira/browse/KAFKA-14696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17686925#comment-17686925
]
MillieZhang commented on KAFKA-14696:
-
As you said, I'm going to fix this by turning
showuon commented on code in PR #13206:
URL: https://github.com/apache/kafka/pull/13206#discussion_r1102353791
##
core/src/main/java/kafka/server/TierStateMachine.java:
##
@@ -0,0 +1,59 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor
dajac opened a new pull request, #13230:
URL: https://github.com/apache/kafka/pull/13230
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of testing s
vamossagar12 commented on PR #13127:
URL: https://github.com/apache/kafka/pull/13127#issuecomment-1425469233
@cadonna , @fvaleri I ran the system test for StreamsResetter from my local
(and fixed the checkstyle). The tests are running, would keep an eye on it =>
```
./gradlew clean
divijvaidya commented on PR #13220:
URL: https://github.com/apache/kafka/pull/13220#issuecomment-1425505624
Hey @ouyangnengda
I see that this is your first contribution to Kafka. Thank you for your
interest in the project!
Since you are new to the community, let me fill you in
showuon commented on code in PR #13040:
URL: https://github.com/apache/kafka/pull/13040#discussion_r1102512047
##
storage/src/main/java/org/apache/kafka/storage/internals/log/ProducerStateManager.java:
##
@@ -0,0 +1,679 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
divijvaidya commented on PR #13078:
URL: https://github.com/apache/kafka/pull/13078#issuecomment-1425521316
> One concern is that the ConcurrentHashMap could take up more space. This
metric was introduced to try to get this memory usage under control.
The hash map in question here sto
[
https://issues.apache.org/jira/browse/KAFKA-14704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17686986#comment-17686986
]
Luke Chen commented on KAFKA-14704:
---
[~dajac] , could you add some bug description? Th
divijvaidya commented on PR #12590:
URL: https://github.com/apache/kafka/pull/12590#issuecomment-1425527332
Thank you @dajac for your patience through this PR. It took a long time but
it would definitely improve consumers! Cheers!
--
This is an automated message from the Apache Git Servic
dajac commented on PR #12590:
URL: https://github.com/apache/kafka/pull/12590#issuecomment-1425530666
@divijvaidya Sorry again for the long delay. By the way, I was wondering if
we should also do this in the AbstractFetcherThread in order to close sessions
used by replication when a broker
[
https://issues.apache.org/jira/browse/KAFKA-14704?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Jacot updated KAFKA-14704:
Description:
When a leader becomes a follower, it is likely that it has uncommitted records
in it
divijvaidya commented on code in PR #13219:
URL: https://github.com/apache/kafka/pull/13219#discussion_r1102521315
##
clients/src/test/java/org/apache/kafka/common/utils/ImplicitLinkedHashCollectionTest.java:
##
@@ -142,8 +143,8 @@ static void expectTraversal(Iterator iterator,
[
https://issues.apache.org/jira/browse/KAFKA-14704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17686993#comment-17686993
]
David Jacot commented on KAFKA-14704:
-
[~showuon] Done. Sorry for that.
> Follower
divijvaidya commented on PR #12590:
URL: https://github.com/apache/kafka/pull/12590#issuecomment-1425536975
> @divijvaidya Sorry again for the long delay. By the way, I was wondering
if we should also do this in the AbstractFetcherThread in order to close
sessions used by replication when a
[
https://issues.apache.org/jira/browse/KAFKA-14704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17686996#comment-17686996
]
Luke Chen commented on KAFKA-14704:
---
No worries! Nice catch!
> Follower should tru
fvaleri commented on code in PR #13214:
URL: https://github.com/apache/kafka/pull/13214#discussion_r1102548459
##
tools/src/main/java/org/apache/kafka/tools/MessageReader.java:
##
@@ -0,0 +1,48 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * con
fvaleri commented on code in PR #13214:
URL: https://github.com/apache/kafka/pull/13214#discussion_r1102548459
##
tools/src/main/java/org/apache/kafka/tools/MessageReader.java:
##
@@ -0,0 +1,48 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * con
satishd commented on PR #13040:
URL: https://github.com/apache/kafka/pull/13040#issuecomment-1425587517
Thanks @showuon for your review. Addressed them with the latest commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub a
fvaleri commented on code in PR #13204:
URL: https://github.com/apache/kafka/pull/13204#discussion_r1102366936
##
build.gradle:
##
@@ -1756,6 +1756,7 @@ project(':tools') {
dependencies {
implementation project(':clients')
+implementation project(':core')
Review C
Hangleton commented on code in PR #13214:
URL: https://github.com/apache/kafka/pull/13214#discussion_r1102625366
##
tools/src/main/java/org/apache/kafka/tools/MessageReader.java:
##
@@ -0,0 +1,48 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * c
Hangleton commented on code in PR #13215:
URL: https://github.com/apache/kafka/pull/13215#discussion_r1102626937
##
tools/src/main/java/org/apache/kafka/tools/ConsumerPerformance.java:
##
@@ -0,0 +1,394 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or mor
Hangleton commented on code in PR #13215:
URL: https://github.com/apache/kafka/pull/13215#discussion_r1102629200
##
tools/src/main/java/org/apache/kafka/tools/ConsumerPerformance.java:
##
@@ -0,0 +1,394 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or mor
vamossagar12 commented on PR #13127:
URL: https://github.com/apache/kafka/pull/13127#issuecomment-1425650698
Tests seemed to have passed for one of the builds.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL ab
mimaison commented on code in PR #12366:
URL: https://github.com/apache/kafka/pull/12366#discussion_r1102632023
##
connect/mirror/README.md:
##
@@ -194,6 +194,10 @@ it is important to keep configuration consistent across
flows to the same
target cluster. In most cases, your en
Federico Valeri created KAFKA-14705:
---
Summary: Delete kafka.tools.JmxTool redirection object
Key: KAFKA-14705
URL: https://issues.apache.org/jira/browse/KAFKA-14705
Project: Kafka
Issue Typ
[
https://issues.apache.org/jira/browse/KAFKA-14705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17687038#comment-17687038
]
Federico Valeri commented on KAFKA-14705:
-
https://github.com/apache/kafka/pull/
Hangleton commented on code in PR #13206:
URL: https://github.com/apache/kafka/pull/13206#discussion_r1102707234
##
core/src/main/scala/kafka/server/AbstractFetcherThread.scala:
##
@@ -683,33 +655,24 @@ abstract class AbstractFetcherThread(name: String,
* produced to the
ijuma commented on PR #13195:
URL: https://github.com/apache/kafka/pull/13195#issuecomment-1425806964
Was a KIP submitted for this? Generally, if something ends up in the release
notes due to user impact, it requires a KIP.
--
This is an automated message from the Apache Git Service.
To r
ijuma commented on PR #13171:
URL: https://github.com/apache/kafka/pull/13171#issuecomment-1425808110
Yeah, I think we should consider simply removing the tool if it doesn't
work. But if it was exposed in ` bin`, we'd need a KIP for it.
--
This is an automated message from the Apache Git
fvaleri commented on code in PR #13215:
URL: https://github.com/apache/kafka/pull/13215#discussion_r1102766672
##
tools/src/main/java/org/apache/kafka/tools/ConsumerPerformance.java:
##
@@ -0,0 +1,394 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
fvaleri commented on code in PR #13215:
URL: https://github.com/apache/kafka/pull/13215#discussion_r1102766672
##
tools/src/main/java/org/apache/kafka/tools/ConsumerPerformance.java:
##
@@ -0,0 +1,394 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
fvaleri commented on code in PR #13215:
URL: https://github.com/apache/kafka/pull/13215#discussion_r1102766672
##
tools/src/main/java/org/apache/kafka/tools/ConsumerPerformance.java:
##
@@ -0,0 +1,394 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
[
https://issues.apache.org/jira/browse/KAFKA-14705?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Federico Valeri updated KAFKA-14705:
Summary: Delete kafka.tools.JmxTool redirection (was: Delete
kafka.tools.JmxTool redirect
[
https://issues.apache.org/jira/browse/KAFKA-14696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17687087#comment-17687087
]
Manikumar commented on KAFKA-14696:
---
Yes, you ca fix cherry picking the commit
ae22ec
[
https://issues.apache.org/jira/browse/KAFKA-14696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17687087#comment-17687087
]
Manikumar edited comment on KAFKA-14696 at 2/10/23 1:58 PM:
dmariassy commented on code in PR #13224:
URL: https://github.com/apache/kafka/pull/13224#discussion_r1102799491
##
core/src/test/scala/integration/kafka/api/ProducerSendTestHelpers.scala:
##
@@ -0,0 +1,238 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one o
pprovenzano commented on code in PR #13114:
URL: https://github.com/apache/kafka/pull/13114#discussion_r1102813837
##
core/src/main/scala/kafka/server/ControllerApis.scala:
##
@@ -816,6 +817,17 @@ class ControllerApis(val requestChannel: RequestChannel,
}
}
+ def ha
pprovenzano commented on code in PR #13114:
URL: https://github.com/apache/kafka/pull/13114#discussion_r1102815060
##
metadata/src/main/java/org/apache/kafka/controller/ScramControlManager.java:
##
@@ -0,0 +1,307 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
pprovenzano commented on code in PR #13114:
URL: https://github.com/apache/kafka/pull/13114#discussion_r1102815637
##
metadata/src/main/java/org/apache/kafka/image/ScramCredentialData.java:
##
@@ -0,0 +1,119 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one o
pprovenzano commented on code in PR #13114:
URL: https://github.com/apache/kafka/pull/13114#discussion_r1102815866
##
metadata/src/main/java/org/apache/kafka/image/ScramImage.java:
##
@@ -0,0 +1,97 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ *
ijuma commented on code in PR #13040:
URL: https://github.com/apache/kafka/pull/13040#discussion_r1102842008
##
core/src/main/scala/kafka/log/UnifiedLog.scala:
##
@@ -680,19 +680,23 @@ class UnifiedLog(@volatile var logStartOffset: Long,
}
private[log] def activeProducer
satishd commented on code in PR #13040:
URL: https://github.com/apache/kafka/pull/13040#discussion_r1102874502
##
core/src/test/scala/integration/kafka/api/TransactionsTest.scala:
##
@@ -685,7 +685,7 @@ class TransactionsTest extends IntegrationTestHarness {
// get here w
ijuma commented on code in PR #13040:
URL: https://github.com/apache/kafka/pull/13040#discussion_r1102882346
##
core/src/test/scala/integration/kafka/api/TransactionsTest.scala:
##
@@ -685,7 +685,7 @@ class TransactionsTest extends IntegrationTestHarness {
// get here wit
ijuma commented on code in PR #13040:
URL: https://github.com/apache/kafka/pull/13040#discussion_r1102882346
##
core/src/test/scala/integration/kafka/api/TransactionsTest.scala:
##
@@ -685,7 +685,7 @@ class TransactionsTest extends IntegrationTestHarness {
// get here wit
satishd commented on code in PR #13040:
URL: https://github.com/apache/kafka/pull/13040#discussion_r1102914037
##
storage/src/main/java/org/apache/kafka/storage/internals/log/ProducerStateManager.java:
##
@@ -0,0 +1,676 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
satishd commented on code in PR #13040:
URL: https://github.com/apache/kafka/pull/13040#discussion_r1102933380
##
core/src/main/scala/kafka/log/UnifiedLog.scala:
##
@@ -680,19 +680,23 @@ class UnifiedLog(@volatile var logStartOffset: Long,
}
private[log] def activeProduc
C0urante commented on code in PR #12366:
URL: https://github.com/apache/kafka/pull/12366#discussion_r1102971088
##
connect/mirror/README.md:
##
@@ -194,6 +194,10 @@ it is important to keep configuration consistent across
flows to the same
target cluster. In most cases, your en
C0urante commented on PR #12366:
URL: https://github.com/apache/kafka/pull/12366#issuecomment-1426050446
@mimaison I've updated the README and fixed a small bug in the integration
test recently introduced in https://github.com/apache/kafka/pull/13137. Mind
giving one more quick pass?
--
ijuma commented on code in PR #13040:
URL: https://github.com/apache/kafka/pull/13040#discussion_r1102975376
##
core/src/main/scala/kafka/log/UnifiedLog.scala:
##
@@ -680,19 +680,23 @@ class UnifiedLog(@volatile var logStartOffset: Long,
}
private[log] def activeProducer
ijuma commented on code in PR #13040:
URL: https://github.com/apache/kafka/pull/13040#discussion_r1102976553
##
storage/src/main/java/org/apache/kafka/storage/internals/log/ProducerStateManager.java:
##
@@ -0,0 +1,676 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) u
satishd commented on code in PR #13040:
URL: https://github.com/apache/kafka/pull/13040#discussion_r1102997944
##
storage/src/main/java/org/apache/kafka/storage/internals/log/ProducerStateManager.java:
##
@@ -0,0 +1,676 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
cmccabe commented on code in PR #13227:
URL: https://github.com/apache/kafka/pull/13227#discussion_r1103072726
##
server-common/src/main/java/org/apache/kafka/server/fault/ProcessTerminatingFaultHandler.java:
##
@@ -0,0 +1,97 @@
+/*
+ * Licensed to the Apache Software Foundation
jolshan commented on code in PR #13230:
URL: https://github.com/apache/kafka/pull/13230#discussion_r1103074467
##
core/src/main/scala/kafka/server/AbstractFetcherThread.scala:
##
@@ -348,33 +348,39 @@ abstract class AbstractFetcherThread(name: String,
Errors.forCo
[
https://issues.apache.org/jira/browse/KAFKA-14688?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ismael Juma resolved KAFKA-14688.
-
Resolution: Fixed
> Move org.apache.kafka.server.log.internals to
> org.apache.kafka.storage.in
vcrfxia commented on code in PR #13188:
URL: https://github.com/apache/kafka/pull/13188#discussion_r1103076551
##
streams/src/main/java/org/apache/kafka/streams/state/VersionedKeyValueStore.java:
##
@@ -0,0 +1,99 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
philipnee commented on code in PR #13190:
URL: https://github.com/apache/kafka/pull/13190#discussion_r1103108812
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java:
##
@@ -501,13 +501,16 @@ boolean joinGroupIfNeeded(final Timer timer) {
jolshan commented on code in PR #13230:
URL: https://github.com/apache/kafka/pull/13230#discussion_r1103127795
##
core/src/test/scala/unit/kafka/server/AbstractFetcherThreadTest.scala:
##
@@ -1089,6 +1089,85 @@ class AbstractFetcherThreadTest {
fetcher.verifyLastFetchedEpoc
jolshan commented on code in PR #13230:
URL: https://github.com/apache/kafka/pull/13230#discussion_r1103129876
##
core/src/test/scala/unit/kafka/server/AbstractFetcherThreadTest.scala:
##
@@ -1387,13 +1466,8 @@ class AbstractFetcherThreadTest {
val state = replicaPartitio
jsancio commented on code in PR #13227:
URL: https://github.com/apache/kafka/pull/13227#discussion_r1103137743
##
server-common/src/main/java/org/apache/kafka/server/fault/ProcessTerminatingFaultHandler.java:
##
@@ -0,0 +1,97 @@
+/*
+ * Licensed to the Apache Software Foundation
vcrfxia commented on code in PR #13188:
URL: https://github.com/apache/kafka/pull/13188#discussion_r1103079190
##
streams/src/test/java/org/apache/kafka/streams/state/internals/RocksDBVersionedStoreTest.java:
##
@@ -0,0 +1,435 @@
+/*
+ * Licensed to the Apache Software Foundatio
vcrfxia commented on code in PR #13188:
URL: https://github.com/apache/kafka/pull/13188#discussion_r1103141124
##
streams/src/main/java/org/apache/kafka/streams/state/VersionedKeyValueStore.java:
##
@@ -0,0 +1,99 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
jolshan opened a new pull request, #13231:
URL: https://github.com/apache/kafka/pull/13231
I've updated the API spec and related classes.
Clients should only be able to send up to version 3 requests and that is
enforced by using the old Builder and forcing the older builder to build
jolshan commented on PR #13229:
URL: https://github.com/apache/kafka/pull/13229#issuecomment-1426235352
Hey -- what is the goal of this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the sp
vcrfxia commented on code in PR #13189:
URL: https://github.com/apache/kafka/pull/13189#discussion_r1103148828
##
streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBVersionedStore.java:
##
@@ -0,0 +1,877 @@
+/*
+ * Licensed to the Apache Software Foundation (A
vcrfxia commented on code in PR #13189:
URL: https://github.com/apache/kafka/pull/13189#discussion_r1103149123
##
streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBVersionedStoreRestoreWriteBuffer.java:
##
@@ -0,0 +1,269 @@
+/*
+ * Licensed to the Apache Soft
philipnee commented on PR #13225:
URL: https://github.com/apache/kafka/pull/13225#issuecomment-1426247418
@hachikuji - info level logging to prevent misleading warn.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
artemlivshits commented on PR #13078:
URL: https://github.com/apache/kafka/pull/13078#issuecomment-1426250015
> Which I assume is in "hundreds" in a busy cluster
We had cases of OOM due to number of producer ids, so we definitely don't
want to increase memory consumption (and should l
jolshan commented on code in PR #13196:
URL: https://github.com/apache/kafka/pull/13196#discussion_r1103164836
##
core/src/main/scala/kafka/cluster/Partition.scala:
##
@@ -49,6 +49,35 @@ import org.apache.kafka.server.log.internals.{AppendOrigin,
FetchDataInfo, Fetch
import sc
jolshan commented on code in PR #13196:
URL: https://github.com/apache/kafka/pull/13196#discussion_r1103166441
##
core/src/main/scala/kafka/cluster/Partition.scala:
##
@@ -49,6 +49,35 @@ import org.apache.kafka.server.log.internals.{AppendOrigin,
FetchDataInfo, Fetch
import sc
jolshan commented on code in PR #13196:
URL: https://github.com/apache/kafka/pull/13196#discussion_r1103166441
##
core/src/main/scala/kafka/cluster/Partition.scala:
##
@@ -49,6 +49,35 @@ import org.apache.kafka.server.log.internals.{AppendOrigin,
FetchDataInfo, Fetch
import sc
philipnee commented on PR #13021:
URL: https://github.com/apache/kafka/pull/13021#issuecomment-1426265591
There's still a couple things to be hashed out in the future, in particular
1. how do we plan to structure the subscription state and
2. what are the API calls for the subscription
rreddy-22 commented on code in PR #13230:
URL: https://github.com/apache/kafka/pull/13230#discussion_r1103221020
##
core/src/main/scala/kafka/server/AbstractFetcherThread.scala:
##
@@ -348,33 +348,39 @@ abstract class AbstractFetcherThread(name: String,
Errors.for
rreddy-22 commented on code in PR #13230:
URL: https://github.com/apache/kafka/pull/13230#discussion_r1103225207
##
core/src/main/scala/kafka/server/AbstractFetcherThread.scala:
##
@@ -348,33 +348,39 @@ abstract class AbstractFetcherThread(name: String,
Errors.for
gharris1727 commented on code in PR #13184:
URL: https://github.com/apache/kafka/pull/13184#discussion_r1103257875
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/ErrorHandlingTaskTest.java:
##
@@ -494,15 +500,25 @@ private void expectTopicCreation(String topic
gharris1727 commented on code in PR #13184:
URL: https://github.com/apache/kafka/pull/13184#discussion_r1103260370
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/ErrorHandlingTaskTest.java:
##
@@ -494,15 +500,25 @@ private void expectTopicCreation(String topic
gharris1727 commented on code in PR #13184:
URL: https://github.com/apache/kafka/pull/13184#discussion_r1103287942
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/ConnectorConfigTest.java:
##
@@ -147,10 +151,10 @@ public void singleTransform() {
props.
rreddy-22 commented on code in PR #13230:
URL: https://github.com/apache/kafka/pull/13230#discussion_r1103225207
##
core/src/main/scala/kafka/server/AbstractFetcherThread.scala:
##
@@ -348,33 +348,39 @@ abstract class AbstractFetcherThread(name: String,
Errors.for
rreddy-22 commented on code in PR #13230:
URL: https://github.com/apache/kafka/pull/13230#discussion_r1103221020
##
core/src/main/scala/kafka/server/AbstractFetcherThread.scala:
##
@@ -348,33 +348,39 @@ abstract class AbstractFetcherThread(name: String,
Errors.for
mjsax commented on code in PR #13188:
URL: https://github.com/apache/kafka/pull/13188#discussion_r1102242415
##
streams/src/test/java/org/apache/kafka/streams/state/internals/RocksDBVersionedStoreTest.java:
##
@@ -0,0 +1,435 @@
+/*
+ * Licensed to the Apache Software Foundation
gharris1727 commented on code in PR #13184:
URL: https://github.com/apache/kafka/pull/13184#discussion_r1103295046
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/ConnectorConfig.java:
##
@@ -270,28 +270,28 @@ public boolean includeRecordDetailsInErrorLog() {
mjsax commented on code in PR #13189:
URL: https://github.com/apache/kafka/pull/13189#discussion_r1103303535
##
streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBVersionedStore.java:
##
@@ -0,0 +1,877 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF
cmccabe merged PR #13226:
URL: https://github.com/apache/kafka/pull/13226
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
guozhangwang commented on code in PR #13189:
URL: https://github.com/apache/kafka/pull/13189#discussion_r1103405393
##
streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBVersionedStore.java:
##
@@ -0,0 +1,877 @@
+/*
+ * Licensed to the Apache Software Foundati
hachikuji commented on code in PR #13230:
URL: https://github.com/apache/kafka/pull/13230#discussion_r1103426128
##
core/src/test/scala/unit/kafka/server/AbstractFetcherThreadTest.scala:
##
@@ -1089,6 +1089,85 @@ class AbstractFetcherThreadTest {
fetcher.verifyLastFetchedEp
hachikuji commented on code in PR #13230:
URL: https://github.com/apache/kafka/pull/13230#discussion_r1103436599
##
core/src/main/scala/kafka/server/AbstractFetcherThread.scala:
##
@@ -348,33 +348,39 @@ abstract class AbstractFetcherThread(name: String,
Errors.for
hachikuji commented on code in PR #13227:
URL: https://github.com/apache/kafka/pull/13227#discussion_r1103438546
##
core/src/main/scala/kafka/server/SharedServer.scala:
##
@@ -60,7 +60,10 @@ class StandardFaultHandlerFactory extends
FaultHandlerFactory {
action: Runnable
hachikuji commented on code in PR #13227:
URL: https://github.com/apache/kafka/pull/13227#discussion_r1103438546
##
core/src/main/scala/kafka/server/SharedServer.scala:
##
@@ -60,7 +60,10 @@ class StandardFaultHandlerFactory extends
FaultHandlerFactory {
action: Runnable
gharris1727 commented on code in PR #13208:
URL: https://github.com/apache/kafka/pull/13208#discussion_r1103447933
##
connect/runtime/src/main/java/org/apache/kafka/connect/storage/OffsetStorageWriter.java:
##
@@ -98,6 +104,24 @@ private boolean flushing() {
return toFl
mjsax merged PR #13188:
URL: https://github.com/apache/kafka/pull/13188
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or
gharris1727 commented on PR #13178:
URL: https://github.com/apache/kafka/pull/13178#issuecomment-1426559007
I think my commit to synchronize the OffsetSyncStore introduced a dramatic
performance regression that is causing the current test failures. Where
previously the test would comfortabl
dajac commented on PR #13195:
URL: https://github.com/apache/kafka/pull/13195#issuecomment-1426647094
I am not aware of any KIP regarding the migration of the tools from core
module to tools module. Having a small one for those problematic tools is not a
bad idea.
For the context, pa
ijuma commented on PR #13195:
URL: https://github.com/apache/kafka/pull/13195#issuecomment-1426647425
@dajac well, that depends on whether it's considered public api. My position
is that the only API is the script. If there is no script, it's not public API.
How would users even know about
dajac commented on code in PR #13214:
URL: https://github.com/apache/kafka/pull/13214#discussion_r1103557466
##
tools/src/main/java/org/apache/kafka/tools/MessageReader.java:
##
@@ -0,0 +1,48 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contr
dajac commented on code in PR #13214:
URL: https://github.com/apache/kafka/pull/13214#discussion_r1103557897
##
tools/src/main/java/org/apache/kafka/tools/MessageReader.java:
##
@@ -0,0 +1,48 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contr
dajac commented on PR #13195:
URL: https://github.com/apache/kafka/pull/13195#issuecomment-1426652327
Yeah, it is definitely a gray area. I don’t think that those tools are
documented in the Kafka documentation. Somehow, JmxTool is known and you can
find references to it on Stackoverflow an
dajac commented on PR #13195:
URL: https://github.com/apache/kafka/pull/13195#issuecomment-1426652393
By the way, there is another case here:
https://github.com/apache/kafka/pull/13214.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on t
96 matches
Mail list logo
