satishd commented on code in PR #13040:
URL: https://github.com/apache/kafka/pull/13040#discussion_r1102933380
##########
core/src/main/scala/kafka/log/UnifiedLog.scala:
##########
@@ -680,19 +680,23 @@ class UnifiedLog(@volatile var logStartOffset: Long,
}
private[log] def activeProducersWithLastSequence: Map[Long, Int] = lock
synchronized {
Review Comment:
Right, it is used only in tests. But we should not move to `LogTestUtils` as
this method should take a lock while building the results. It is better to keep
these semantics and leave this method here even though it is used only in
tests. This will keep the method contract clean and thread safe.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
