satishd commented on code in PR #13040:
URL: https://github.com/apache/kafka/pull/13040#discussion_r1102874502
##########
core/src/test/scala/integration/kafka/api/TransactionsTest.scala:
##########
@@ -685,7 +685,7 @@ class TransactionsTest extends IntegrationTestHarness {
// get here without having bumped the epoch. If bumping the epoch is
possible, the producer will attempt to, so
// check there that the epoch has actually increased
producerStateEntry =
- brokers(partitionLeader).logManager.getLog(new
TopicPartition(testTopic,
0)).get.producerStateManager.activeProducers(producerId)
+ brokers(partitionLeader).logManager.getLog(new
TopicPartition(testTopic,
0)).get.producerStateManager.activeProducers.get(producerId)
Review Comment:
aah, forgot to update the comment. I added that check initially, but later
when I checked the old code, it did not have this kind of check in the old
Scala code. I plan to add that as a followup, limiting this change mostly
related to the refactoring.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
