ijuma commented on code in PR #13040:
URL: https://github.com/apache/kafka/pull/13040#discussion_r1102842008
##########
core/src/main/scala/kafka/log/UnifiedLog.scala:
##########
@@ -680,19 +680,23 @@ class UnifiedLog(@volatile var logStartOffset: Long,
}
private[log] def activeProducersWithLastSequence: Map[Long, Int] = lock
synchronized {
Review Comment:
Is it right that this is only used in tests? If so, can we move this to
`LogTestUtils`? Then we don't have to worry about the `toMap` copy.
Alternatively, just change the return type to `scala.collection.Map` and remove
the unnecessary `toMap` at the end.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
