ijuma commented on code in PR #13040:
URL: https://github.com/apache/kafka/pull/13040#discussion_r1102975376
##########
core/src/main/scala/kafka/log/UnifiedLog.scala:
##########
@@ -680,19 +680,23 @@ class UnifiedLog(@volatile var logStartOffset: Long,
}
private[log] def activeProducersWithLastSequence: Map[Long, Int] = lock
synchronized {
Review Comment:
Makes sense about keeping the implementation in `UnifiedLog`. I still think
we should simply return `collection.Map` and avoid the copy.
##########
core/src/main/scala/kafka/log/UnifiedLog.scala:
##########
@@ -680,19 +680,23 @@ class UnifiedLog(@volatile var logStartOffset: Long,
}
private[log] def activeProducersWithLastSequence: Map[Long, Int] = lock
synchronized {
Review Comment:
Makes sense about keeping the implementation in `UnifiedLog`. I still think
we should simply return `collection.Map` and avoid the extra copy.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
