[GitHub] [kafka] dajac commented on a diff in pull request #12902: KAFKA-14367; Add `OffsetDelete` to the new `GroupCoordinator` interface

dajac commented on code in PR #12902: URL: https://github.com/apache/kafka/pull/12902#discussion_r1070933822 ## core/src/test/scala/unit/kafka/server/KafkaApisTest.scala: ## @@ -2764,37 +2763,170 @@ class KafkaApisTest { val request = buildRequest(offsetDeleteRequest)

[GitHub] [kafka] ivanyu commented on a diff in pull request #13067: KAFKA-14524: Rewrite KafkaMetricsGroup in Java

ivanyu commented on code in PR #13067: URL: https://github.com/apache/kafka/pull/13067#discussion_r1070962067 ## server-common/src/main/java/org/apache/kafka/server/metrics/KafkaMetricsGroup.java: ## @@ -0,0 +1,161 @@ +/* + * Licensed to the Apache Software Foundation (ASF) unde

[GitHub] [kafka] clolov opened a new pull request, #13122: KAFKA-14594: Move LogDirsCommand to tools module

clolov opened a new pull request, #13122: URL: https://github.com/apache/kafka/pull/13122 Questions for reviewers: * Ideally, I would like to move the test using `KafkaServerTestHarness`, but I do not know whether we want to severe all links to Scala by moving the tools? * Is there a p

[GitHub] [kafka] clolov commented on pull request #13122: KAFKA-14594: Move LogDirsCommand to tools module

clolov commented on PR #13122: URL: https://github.com/apache/kafka/pull/13122#issuecomment-1384049900 Tagging @mimaison, @fvaleri and @dengziming as reviewers of https://github.com/apache/kafka/pull/13080 -- This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [kafka] fvaleri commented on a diff in pull request #13095: KAFKA-14580: Moving EndToEndLatency from core to tools module

fvaleri commented on code in PR #13095: URL: https://github.com/apache/kafka/pull/13095#discussion_r1071348242 ## tools/src/main/java/org/apache/kafka/tools/EndToEndLatency.java: ## @@ -0,0 +1,237 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

[GitHub] [kafka] fvaleri commented on a diff in pull request #13095: KAFKA-14580: Moving EndToEndLatency from core to tools module

fvaleri commented on code in PR #13095: URL: https://github.com/apache/kafka/pull/13095#discussion_r1071348600 ## tools/src/main/java/org/apache/kafka/tools/EndToEndLatency.java: ## @@ -0,0 +1,237 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

[GitHub] [kafka] fvaleri commented on a diff in pull request #13095: KAFKA-14580: Moving EndToEndLatency from core to tools module

fvaleri commented on code in PR #13095: URL: https://github.com/apache/kafka/pull/13095#discussion_r1071349940 ## tools/src/main/java/org/apache/kafka/tools/EndToEndLatency.java: ## @@ -0,0 +1,237 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

[GitHub] [kafka] ijuma commented on a diff in pull request #13040: KAFKA-14480 Move/Rewrite ProducerStateManager to storage module.

ijuma commented on code in PR #13040: URL: https://github.com/apache/kafka/pull/13040#discussion_r1071361752 ## core/src/main/scala/kafka/log/LogLoader.scala: ## @@ -191,7 +192,7 @@ class LogLoader( // Reload all snapshots into the ProducerStateManager cache, the intermedi

[GitHub] [kafka] ijuma commented on a diff in pull request #13095: KAFKA-14580: Moving EndToEndLatency from core to tools module

ijuma commented on code in PR #13095: URL: https://github.com/apache/kafka/pull/13095#discussion_r1071369472 ## tools/src/main/java/org/apache/kafka/tools/EndToEndLatency.java: ## @@ -0,0 +1,237 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * co

[GitHub] [kafka] ijuma commented on a diff in pull request #13095: KAFKA-14580: Moving EndToEndLatency from core to tools module

ijuma commented on code in PR #13095: URL: https://github.com/apache/kafka/pull/13095#discussion_r1071369472 ## tools/src/main/java/org/apache/kafka/tools/EndToEndLatency.java: ## @@ -0,0 +1,237 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * co

[GitHub] [kafka] ijuma commented on a diff in pull request #13095: KAFKA-14580: Moving EndToEndLatency from core to tools module

ijuma commented on code in PR #13095: URL: https://github.com/apache/kafka/pull/13095#discussion_r1071369472 ## tools/src/main/java/org/apache/kafka/tools/EndToEndLatency.java: ## @@ -0,0 +1,237 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * co

[GitHub] [kafka] margarita-nedzelska-sonarsource closed pull request #13123: Margo/sc

margarita-nedzelska-sonarsource closed pull request #13123: Margo/sc URL: https://github.com/apache/kafka/pull/13123 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscr

[GitHub] [kafka] jolshan commented on a diff in pull request #13111: KAFKA-14190: Update Zk TopicId from locally stored cache in controller

jolshan commented on code in PR #13111: URL: https://github.com/apache/kafka/pull/13111#discussion_r1071406824 ## core/src/main/scala/kafka/controller/KafkaController.scala: ## @@ -1698,7 +1708,7 @@ class KafkaController(val config: KafkaConfig, private def processPartitionMo

[GitHub] [kafka] jolshan commented on a diff in pull request #13111: KAFKA-14190: Update Zk TopicId from locally stored cache in controller

jolshan commented on code in PR #13111: URL: https://github.com/apache/kafka/pull/13111#discussion_r1071407921 ## core/src/main/scala/kafka/controller/KafkaController.scala: ## @@ -1716,27 +1726,25 @@ class KafkaController(val config: KafkaConfig, } if (!isActive) re

[GitHub] [kafka] jolshan commented on a diff in pull request #13111: KAFKA-14190: Update Zk TopicId from locally stored cache in controller

jolshan commented on code in PR #13111: URL: https://github.com/apache/kafka/pull/13111#discussion_r1071409739 ## core/src/main/scala/kafka/zk/KafkaZkClient.scala: ## @@ -602,14 +602,13 @@ class KafkaZkClient private[zk] (zooKeeperClient: ZooKeeperClient, isSecure: Boo val

[GitHub] [kafka] jolshan commented on a diff in pull request #13111: KAFKA-14190: Update Zk TopicId from locally stored cache in controller

jolshan commented on code in PR #13111: URL: https://github.com/apache/kafka/pull/13111#discussion_r1071409739 ## core/src/main/scala/kafka/zk/KafkaZkClient.scala: ## @@ -602,14 +602,13 @@ class KafkaZkClient private[zk] (zooKeeperClient: ZooKeeperClient, isSecure: Boo val

[GitHub] [kafka] jeffkbkim commented on a diff in pull request #12902: KAFKA-14367; Add `OffsetDelete` to the new `GroupCoordinator` interface

jeffkbkim commented on code in PR #12902: URL: https://github.com/apache/kafka/pull/12902#discussion_r1071419097 ## core/src/main/scala/kafka/coordinator/group/GroupCoordinatorAdapter.scala: ## @@ -470,4 +470,45 @@ class GroupCoordinatorAdapter( expireTimestamp = expireTi

[GitHub] [kafka] jolshan commented on a diff in pull request #13111: KAFKA-14190: Update Zk TopicId from locally stored cache in controller

jolshan commented on code in PR #13111: URL: https://github.com/apache/kafka/pull/13111#discussion_r1071420112 ## core/src/main/scala/kafka/controller/KafkaController.scala: ## @@ -1664,11 +1664,21 @@ class KafkaController(val config: KafkaConfig, } private def processTo

[GitHub] [kafka] jolshan commented on a diff in pull request #13111: KAFKA-14190: Update Zk TopicId from locally stored cache in controller

jolshan commented on code in PR #13111: URL: https://github.com/apache/kafka/pull/13111#discussion_r1071421020 ## core/src/main/scala/kafka/controller/KafkaController.scala: ## @@ -1664,11 +1664,21 @@ class KafkaController(val config: KafkaConfig, } private def processTo

[GitHub] [kafka] jolshan commented on pull request #13111: KAFKA-14190: Update Zk TopicId from locally stored cache in controller

jolshan commented on PR #13111: URL: https://github.com/apache/kafka/pull/13111#issuecomment-1384304126 > More specifically, we will still end up having two different topic Ids in cases when controller failover takes place between the time when Zk TopicID was overwritten/removed and time w

[GitHub] [kafka] dajac commented on pull request #12972: KAFKA-14391; Add ConsumerGroupHeartbeat API

dajac commented on PR #12972: URL: https://github.com/apache/kafka/pull/12972#issuecomment-1384315580 @hachikuji I played a bit with your suggesting and I personally prefer the current approach: `"apiStability": "evolving|stable"`. It is a bit odd to specify the unstable version because it

[GitHub] [kafka] vamossagar12 commented on a diff in pull request #13095: KAFKA-14580: Moving EndToEndLatency from core to tools module

vamossagar12 commented on code in PR #13095: URL: https://github.com/apache/kafka/pull/13095#discussion_r1071438783 ## tools/src/main/java/org/apache/kafka/tools/EndToEndLatency.java: ## @@ -0,0 +1,237 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more

[GitHub] [kafka] ijuma commented on pull request #13111: KAFKA-14190: Update Zk TopicId from locally stored cache in controller

ijuma commented on PR #13111: URL: https://github.com/apache/kafka/pull/13111#issuecomment-1384323798 It's too late for 3.4 unless it's a regression or a low risk critical fix to something new in 3.4. Have we tried encouraging users to move away from the command line switches depreca

[GitHub] [kafka] dajac commented on pull request #12902: KAFKA-14367; Add `OffsetDelete` to the new `GroupCoordinator` interface

dajac commented on PR #12902: URL: https://github.com/apache/kafka/pull/12902#issuecomment-1384325991 @jolshan @jeffkbkim This one is ready for the last round. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[GitHub] [kafka] vamossagar12 commented on a diff in pull request #13095: KAFKA-14580: Moving EndToEndLatency from core to tools module

vamossagar12 commented on code in PR #13095: URL: https://github.com/apache/kafka/pull/13095#discussion_r1071444925 ## tools/src/main/java/org/apache/kafka/tools/EndToEndLatency.java: ## @@ -0,0 +1,237 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more

[GitHub] [kafka] fvaleri commented on a diff in pull request #13095: KAFKA-14580: Moving EndToEndLatency from core to tools module

fvaleri commented on code in PR #13095: URL: https://github.com/apache/kafka/pull/13095#discussion_r1071445060 ## tools/src/main/java/org/apache/kafka/tools/EndToEndLatency.java: ## @@ -0,0 +1,237 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

[GitHub] [kafka] fvaleri commented on a diff in pull request #13095: KAFKA-14580: Moving EndToEndLatency from core to tools module

fvaleri commented on code in PR #13095: URL: https://github.com/apache/kafka/pull/13095#discussion_r1071348242 ## tools/src/main/java/org/apache/kafka/tools/EndToEndLatency.java: ## @@ -0,0 +1,237 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

[GitHub] [kafka] dajac commented on a diff in pull request #12902: KAFKA-14367; Add `OffsetDelete` to the new `GroupCoordinator` interface

dajac commented on code in PR #12902: URL: https://github.com/apache/kafka/pull/12902#discussion_r1071450200 ## core/src/main/scala/kafka/coordinator/group/GroupCoordinatorAdapter.scala: ## @@ -470,4 +470,45 @@ class GroupCoordinatorAdapter( expireTimestamp = expireTimest

[GitHub] [kafka] fvaleri commented on a diff in pull request #13122: KAFKA-14594: Move LogDirsCommand to tools module

fvaleri commented on code in PR #13122: URL: https://github.com/apache/kafka/pull/13122#discussion_r1071371063 ## tools/src/main/java/org/apache/kafka/tools/LogDirsCommand.java: ## @@ -0,0 +1,158 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or more + *

[GitHub] [kafka] fvaleri commented on a diff in pull request #13095: KAFKA-14580: Moving EndToEndLatency from core to tools module

fvaleri commented on code in PR #13095: URL: https://github.com/apache/kafka/pull/13095#discussion_r1071471254 ## tools/src/main/java/org/apache/kafka/tools/EndToEndLatency.java: ## @@ -0,0 +1,237 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

[GitHub] [kafka] jeffkbkim commented on a diff in pull request #12902: KAFKA-14367; Add `OffsetDelete` to the new `GroupCoordinator` interface

jeffkbkim commented on code in PR #12902: URL: https://github.com/apache/kafka/pull/12902#discussion_r1071515902 ## clients/src/main/java/org/apache/kafka/common/requests/OffsetDeleteResponse.java: ## @@ -44,6 +48,83 @@ */ public class OffsetDeleteResponse extends AbstractRes

[GitHub] [kafka] ijuma commented on a diff in pull request #13095: KAFKA-14580: Moving EndToEndLatency from core to tools module

ijuma commented on code in PR #13095: URL: https://github.com/apache/kafka/pull/13095#discussion_r1071526879 ## tools/src/main/java/org/apache/kafka/tools/EndToEndLatency.java: ## @@ -0,0 +1,237 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * co

[GitHub] [kafka] dajac commented on a diff in pull request #12902: KAFKA-14367; Add `OffsetDelete` to the new `GroupCoordinator` interface

dajac commented on code in PR #12902: URL: https://github.com/apache/kafka/pull/12902#discussion_r1071531038 ## clients/src/main/java/org/apache/kafka/common/requests/OffsetDeleteResponse.java: ## @@ -44,6 +48,83 @@ */ public class OffsetDeleteResponse extends AbstractRespons

[GitHub] [kafka] dengziming commented on pull request #12797: MINOR: Remove requirement to specify --bootstrap-server in utility scripts if specified in property file

dengziming commented on PR #12797: URL: https://github.com/apache/kafka/pull/12797#issuecomment-1384769507 @justinrlee can you add some test cases related to your change? there are already some cases which you can refer to. -- This is an automated message from the Apache Git Service. To r

[jira] [Created] (KAFKA-14625) CheckpointFile read and write API consistency

Satish Duggana created KAFKA-14625: -- Summary: CheckpointFile read and write API consistency Key: KAFKA-14625 URL: https://issues.apache.org/jira/browse/KAFKA-14625 Project: Kafka Issue Type

[GitHub] [kafka] satishd commented on a diff in pull request #13046: KAFKA-14551 Move/Rewrite LeaderEpochFileCache and its dependencies to the storage module.

satishd commented on code in PR #13046: URL: https://github.com/apache/kafka/pull/13046#discussion_r1071702185 ## server-common/src/main/java/org/apache/kafka/server/common/CheckpointFile.java: ## @@ -72,7 +71,7 @@ public CheckpointFile(File file, tempPath = Paths.get(a

[GitHub] [kafka] cmccabe commented on pull request #13111: KAFKA-14190: Update Zk TopicId from locally stored cache in controller

cmccabe commented on PR #13111: URL: https://github.com/apache/kafka/pull/13111#issuecomment-1384914114 I hate to say this, but I think this should probably be WONTFIX. The rule for admin tools that used the `--zookeeper` flag was always that you needed to match the admin tool version and t