ijuma commented on code in PR #13040:
URL: https://github.com/apache/kafka/pull/13040#discussion_r1071361752
##########
core/src/main/scala/kafka/log/LogLoader.scala:
##########
@@ -191,7 +192,7 @@ class LogLoader(
// Reload all snapshots into the ProducerStateManager cache, the
intermediate ProducerStateManager used
// during log recovery may have deleted some files without the
LogLoader.producerStateManager instance witnessing the
// deletion.
- producerStateManager.removeStraySnapshots(segments.baseOffsets.toSeq)
+ producerStateManager.removeStraySnapshots(segments.baseOffsets.toSeq.map(x
=> Long.box(x)).asJava)
Review Comment:
Seems like we do two collection copies here. Maybe we can tweak things so
that only one of them is needed (and when we convert the segments code, none
are needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
