jeffkbkim commented on code in PR #12902:
URL: https://github.com/apache/kafka/pull/12902#discussion_r1071419097
##########
core/src/main/scala/kafka/coordinator/group/GroupCoordinatorAdapter.scala:
##########
@@ -470,4 +470,45 @@ class GroupCoordinatorAdapter(
expireTimestamp = expireTimestamp
)
}
+
+ override def deleteOffsets(
+ context: RequestContext,
+ request: OffsetDeleteRequestData,
+ bufferSupplier: BufferSupplier
+ ): CompletableFuture[OffsetDeleteResponseData] = {
+ val future = new CompletableFuture[OffsetDeleteResponseData]()
+
+ val partitions = mutable.ArrayBuffer[TopicPartition]()
+ request.topics.forEach { topic =>
+ topic.partitions.forEach { partition =>
+ partitions += new TopicPartition(topic.name, partition.partitionIndex)
+ }
+ }
+
+ val (groupError, topicPartitionResults) = coordinator.handleDeleteOffsets(
+ request.groupId,
+ partitions,
+ RequestLocal(bufferSupplier)
+ )
+
+ if (groupError != Errors.NONE) {
+ future.completeExceptionally(groupError.exception)
+ } else {
+ val response = new OffsetDeleteResponseData()
+ topicPartitionResults.forKeyValue { (topicPartition, error) =>
+ var topic = response.topics.find(topicPartition.topic)
Review Comment:
aha, that makes sense. thanks! i noticed the changes in
OffsetDeleteResponse.java were a bit different than the other APIs as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
