satishd commented on code in PR #13046:
URL: https://github.com/apache/kafka/pull/13046#discussion_r1071702185
##########
server-common/src/main/java/org/apache/kafka/server/common/CheckpointFile.java:
##########
@@ -72,7 +71,7 @@ public CheckpointFile(File file,
tempPath = Paths.get(absolutePath.toString() + ".tmp");
}
- public void write(Collection<T> entries) throws IOException {
+ public void write(List<T> entries) throws IOException {
Review Comment:
Sure, I am fine with the suggestion for now. I updated PR with the changes
to keep it like earlier. But this kind of contract looks fragile, we can take a
relook at whether we can avoid any conversions and keep the APIs consistent.
Filed https://issues.apache.org/jira/browse/KAFKA-14625 to followup later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
