[GitHub] [kafka] jolshan commented on a diff in pull request #13111: KAFKA-14190: Update Zk TopicId from locally stored cache in controller

[GitBox]

jolshan commented on code in PR #13111:
URL: https://github.com/apache/kafka/pull/13111#discussion_r1071406824


##########
core/src/main/scala/kafka/controller/KafkaController.scala:
##########
@@ -1698,7 +1708,7 @@ class KafkaController(val config: KafkaConfig,
   private def processPartitionModifications(topic: String): Unit = {
     def restorePartitionReplicaAssignment(
       topic: String,
-      newPartitionReplicaAssignment: Map[TopicPartition, ReplicaAssignment]
+      newPartitionReplicaAssignment: Set[(TopicPartition, ReplicaAssignment)]

Review Comment:
   Why did we make this a set?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org