[GitHub] [kafka] jolshan commented on a diff in pull request #13111: KAFKA-14190: Update Zk TopicId from locally stored cache in controller

[GitBox]

jolshan commented on code in PR #13111:
URL: https://github.com/apache/kafka/pull/13111#discussion_r1071409739


##########
core/src/main/scala/kafka/zk/KafkaZkClient.scala:
##########
@@ -602,14 +602,13 @@ class KafkaZkClient private[zk] (zooKeeperClient: 
ZooKeeperClient, isSecure: Boo
     val updatedAssignments = topicIdReplicaAssignments.map {
       case TopicIdReplicaAssignment(topic, None, assignments) =>
         TopicIdReplicaAssignment(topic, Some(Uuid.randomUuid()), assignments)
-      case TopicIdReplicaAssignment(topic, Some(_), _) =>
-        throw new IllegalArgumentException("TopicIdReplicaAssignment for " + 
topic + " already contains a topic ID.")
+      case t => t

Review Comment:
   Why did we just remove this check -- does the new code not function without 
it?
   
   EDIT: I see we just pass the controller IDs through.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org