[GitHub] [kafka] dongjinleekr commented on pull request #10678: TRIVIAL: Fix type inconsistencies, unthrown exceptions, etc

dongjinleekr commented on pull request #10678: URL: https://github.com/apache/kafka/pull/10678#issuecomment-864781801 Rebased onto the latest trunk. cc/ @ijuma @cadonna -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [kafka] dongjinleekr commented on pull request #10428: KAFKA-12572: Add import ordering checkstyle rule and configure an automatic formatter

dongjinleekr commented on pull request #10428: URL: https://github.com/apache/kafka/pull/10428#issuecomment-864782996 Rebased onto the latest trunk. cc/ @cadonna -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [kafka] dongjinleekr commented on pull request #10472: KAFKA-12613: Inconsistencies between Kafka Config and Log Config

dongjinleekr commented on pull request #10472: URL: https://github.com/apache/kafka/pull/10472#issuecomment-864783895 Rebased onto the latest trunk. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kafka] dongjinleekr commented on pull request #10827: [WIP] KAFKA-12899: Support --bootstrap-server in ReplicaVerificationTool

dongjinleekr commented on pull request #10827: URL: https://github.com/apache/kafka/pull/10827#issuecomment-864784408 Rebased onto the latest trunk. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kafka] dongjinleekr commented on pull request #10862: KAFKA-12928: Add a check whether the Task's statestore is actually a directory

dongjinleekr commented on pull request #10862: URL: https://github.com/apache/kafka/pull/10862#issuecomment-864785044 Rebased onto the latest trunk cc/ @ableegoldman -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [kafka] skaundinya15 commented on a change in pull request #10743: KIP-699: Update FindCoordinator to resolve multiple Coordinators at a time

skaundinya15 commented on a change in pull request #10743: URL: https://github.com/apache/kafka/pull/10743#discussion_r655133582 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/internals/AlterConsumerGroupOffsetsHandler.java ## @@ -0,0 +1,156 @@ +/* + * Lice

[GitHub] [kafka] skaundinya15 commented on a change in pull request #10743: KIP-699: Update FindCoordinator to resolve multiple Coordinators at a time

skaundinya15 commented on a change in pull request #10743: URL: https://github.com/apache/kafka/pull/10743#discussion_r655134390 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/internals/CoordinatorStrategy.java ## @@ -17,84 +17,153 @@ package org.apache.ka

[GitHub] [kafka] skaundinya15 commented on a change in pull request #10743: KIP-699: Update FindCoordinator to resolve multiple Coordinators at a time

skaundinya15 commented on a change in pull request #10743: URL: https://github.com/apache/kafka/pull/10743#discussion_r655134550 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/internals/DeleteConsumerGroupsHandler.java ## @@ -0,0 +1,131 @@ +/* + * Licensed

[GitHub] [kafka] skaundinya15 commented on a change in pull request #10743: KIP-699: Update FindCoordinator to resolve multiple Coordinators at a time

skaundinya15 commented on a change in pull request #10743: URL: https://github.com/apache/kafka/pull/10743#discussion_r655135901 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/internals/AlterConsumerGroupOffsetsHandler.java ## @@ -0,0 +1,156 @@ +/* + * Lice

[GitHub] [kafka] skaundinya15 commented on a change in pull request #10743: KIP-699: Update FindCoordinator to resolve multiple Coordinators at a time

skaundinya15 commented on a change in pull request #10743: URL: https://github.com/apache/kafka/pull/10743#discussion_r655134390 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/internals/CoordinatorStrategy.java ## @@ -17,84 +17,153 @@ package org.apache.ka

[GitHub] [kafka] skaundinya15 commented on a change in pull request #10743: KIP-699: Update FindCoordinator to resolve multiple Coordinators at a time

skaundinya15 commented on a change in pull request #10743: URL: https://github.com/apache/kafka/pull/10743#discussion_r655138186 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/internals/ListConsumerGroupOffsetsHandler.java ## @@ -0,0 +1,148 @@ +/* + * Licen

[GitHub] [kafka] tombentley commented on a change in pull request #10827: [WIP] KAFKA-12899: Support --bootstrap-server in ReplicaVerificationTool

tombentley commented on a change in pull request #10827: URL: https://github.com/apache/kafka/pull/10827#discussion_r655154960 ## File path: core/src/main/scala/kafka/tools/ReplicaVerificationTool.scala ## @@ -73,53 +74,61 @@ object ReplicaVerificationTool extends Logging {

[GitHub] [kafka] dongjinleekr commented on a change in pull request #10827: [WIP] KAFKA-12899: Support --bootstrap-server in ReplicaVerificationTool

dongjinleekr commented on a change in pull request #10827: URL: https://github.com/apache/kafka/pull/10827#discussion_r655162053 ## File path: core/src/test/scala/kafka/tools/ReplicaVerificationToolTest.scala ## @@ -17,14 +17,40 @@ package kafka.tools +import kafka.tools.R

[GitHub] [kafka] dongjinleekr commented on a change in pull request #10827: [WIP] KAFKA-12899: Support --bootstrap-server in ReplicaVerificationTool

dongjinleekr commented on a change in pull request #10827: URL: https://github.com/apache/kafka/pull/10827#discussion_r655236164 ## File path: core/src/main/scala/kafka/tools/ReplicaVerificationTool.scala ## @@ -73,53 +74,61 @@ object ReplicaVerificationTool extends Logging {

[GitHub] [kafka] dongjinleekr commented on a change in pull request #10827: [WIP] KAFKA-12899: Support --bootstrap-server in ReplicaVerificationTool

dongjinleekr commented on a change in pull request #10827: URL: https://github.com/apache/kafka/pull/10827#discussion_r655241344 ## File path: core/src/main/scala/kafka/tools/ReplicaVerificationTool.scala ## @@ -73,53 +74,61 @@ object ReplicaVerificationTool extends Logging {

[GitHub] [kafka] tombentley commented on a change in pull request #10827: [WIP] KAFKA-12899: Support --bootstrap-server in ReplicaVerificationTool

tombentley commented on a change in pull request #10827: URL: https://github.com/apache/kafka/pull/10827#discussion_r655268742 ## File path: core/src/main/scala/kafka/tools/ReplicaVerificationTool.scala ## @@ -73,53 +74,61 @@ object ReplicaVerificationTool extends Logging {

[GitHub] [kafka] ramesh-muthusamy opened a new pull request #10910: KAFKA-12965 - Graceful clean up of task error metrics

ramesh-muthusamy opened a new pull request #10910: URL: https://github.com/apache/kafka/pull/10910 Issue: We noticed that the Error metrics reported in Kafka Connect worker continues to stay even after the task is re distributed to another worker. As a result you would notice over a pe

[GitHub] [kafka] dongjinleekr commented on pull request #10827: [WIP] KAFKA-12899: Support --bootstrap-server in ReplicaVerificationTool

dongjinleekr commented on pull request #10827: URL: https://github.com/apache/kafka/pull/10827#issuecomment-864950303 Hi @tombentley Here is the update. I added additional tests (`ReplicaVerificationToolTest#{testExitWithMultipleBrokerLists, testExitWithMultipleBootstrapServers`), A

[GitHub] [kafka] rondagostino edited a comment on pull request #10908: MINOR: fix round_trip_fault_test.py - don't assign replicas to nonexi…

rondagostino edited a comment on pull request #10908: URL: https://github.com/apache/kafka/pull/10908#issuecomment-865055596 Sorry to come to this party a bit late. It is likely that the code had a mistake and broker.id=0 should have been broker.id=1. But even with the mistake, I wonder

[GitHub] [kafka] rondagostino commented on pull request #10908: MINOR: fix round_trip_fault_test.py - don't assign replicas to nonexi…

rondagostino commented on pull request #10908: URL: https://github.com/apache/kafka/pull/10908#issuecomment-865055596 Sorry to come to this party a bit late. It is likely that the code had a mistake and broker.id=0 should have been broker.id=1. But even with the mistake, I wonder if this

[GitHub] [kafka] chia7712 commented on pull request #10908: MINOR: fix round_trip_fault_test.py - don't assign replicas to nonexi…

chia7712 commented on pull request #10908: URL: https://github.com/apache/kafka/pull/10908#issuecomment-865056585 > there is a behavior difference between the ZK-based KRaft controllers. Do we explicitly acknowledge and accept this difference? that is a good point. -- This is an a

[GitHub] [kafka] kpatelatwork commented on a change in pull request #10822: KAFKA-4793: Connect API to restart connector and tasks (KIP-745)

kpatelatwork commented on a change in pull request #10822: URL: https://github.com/apache/kafka/pull/10822#discussion_r655408049 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/DistributedHerder.java ## @@ -1063,6 +1076,112 @@ public in

[GitHub] [kafka] cadonna opened a new pull request #10911: MINOR: Remove log warning for RocksDB 6+ upgrade

cadonna opened a new pull request #10911: URL: https://github.com/apache/kafka/pull/10911 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgrade n

[GitHub] [kafka] thomaskwscott commented on a change in pull request #10760: KAFKA-12541 Extend ListOffset to fetch offset with max timestamp

thomaskwscott commented on a change in pull request #10760: URL: https://github.com/apache/kafka/pull/10760#discussion_r655505767 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java ## @@ -4298,6 +4314,18 @@ void handleFailure(Throwable thr

[GitHub] [kafka] niket-goel commented on a change in pull request #10899: KAFKA-12952 Adding Delimeters to Metadata Snapshot File

niket-goel commented on a change in pull request #10899: URL: https://github.com/apache/kafka/pull/10899#discussion_r655511645 ## File path: clients/src/main/java/org/apache/kafka/common/record/MemoryRecords.java ## @@ -664,4 +666,55 @@ private static void writeLeaderChangeMes

[GitHub] [kafka] niket-goel commented on a change in pull request #10899: KAFKA-12952 Adding Delimeters to Metadata Snapshot File

niket-goel commented on a change in pull request #10899: URL: https://github.com/apache/kafka/pull/10899#discussion_r655512248 ## File path: raft/src/main/java/org/apache/kafka/raft/internals/BatchAccumulator.java ## @@ -233,6 +235,68 @@ public void appendLeaderChangeMessage(L

[GitHub] [kafka] junrao commented on a change in pull request #10896: KAFKA-12964: Collect and rename snapshot files prior to async deletion.

junrao commented on a change in pull request #10896: URL: https://github.com/apache/kafka/pull/10896#discussion_r654568852 ## File path: core/src/main/scala/kafka/log/Log.scala ## @@ -2390,16 +2390,23 @@ object Log extends Logging { produc

[GitHub] [kafka] ijuma commented on pull request #10908: MINOR: fix round_trip_fault_test.py - don't assign replicas to nonexi…

ijuma commented on pull request #10908: URL: https://github.com/apache/kafka/pull/10908#issuecomment-865176496 > there is a behavior difference between the ZK-based KRaft controllers. Do we explicitly acknowledge and accept this difference? I think we should, but happy to consider ot

[GitHub] [kafka] dajac commented on a change in pull request #10760: KAFKA-12541 Extend ListOffset to fetch offset with max timestamp

dajac commented on a change in pull request #10760: URL: https://github.com/apache/kafka/pull/10760#discussion_r655535240 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java ## @@ -4298,6 +4296,28 @@ void handleFailure(Throwable throwable)

[GitHub] [kafka] dajac commented on a change in pull request #10760: KAFKA-12541 Extend ListOffset to fetch offset with max timestamp

dajac commented on a change in pull request #10760: URL: https://github.com/apache/kafka/pull/10760#discussion_r655535673 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java ## @@ -4298,6 +4296,28 @@ void handleFailure(Throwable throwable)

[GitHub] [kafka] jsancio commented on a change in pull request #10899: KAFKA-12952 Adding Delimeters to Metadata Snapshot File

jsancio commented on a change in pull request #10899: URL: https://github.com/apache/kafka/pull/10899#discussion_r655536129 ## File path: clients/src/main/java/org/apache/kafka/common/record/MemoryRecords.java ## @@ -664,4 +666,55 @@ private static void writeLeaderChangeMessag

[GitHub] [kafka] niket-goel commented on a change in pull request #10899: KAFKA-12952 Adding Delimeters to Metadata Snapshot File

niket-goel commented on a change in pull request #10899: URL: https://github.com/apache/kafka/pull/10899#discussion_r655537490 ## File path: raft/src/main/java/org/apache/kafka/snapshot/SnapshotWriter.java ## @@ -78,6 +83,76 @@ public SnapshotWriter( ); } +/

[GitHub] [kafka] niket-goel commented on a change in pull request #10899: KAFKA-12952 Adding Delimeters to Metadata Snapshot File

niket-goel commented on a change in pull request #10899: URL: https://github.com/apache/kafka/pull/10899#discussion_r655542184 ## File path: raft/src/main/java/org/apache/kafka/snapshot/SnapshotWriter.java ## @@ -55,7 +60,7 @@ * @param compressionType the compression algo

[GitHub] [kafka] jsancio commented on a change in pull request #10899: KAFKA-12952 Adding Delimeters to Metadata Snapshot File

jsancio commented on a change in pull request #10899: URL: https://github.com/apache/kafka/pull/10899#discussion_r655542285 ## File path: raft/src/main/java/org/apache/kafka/raft/internals/BatchAccumulator.java ## @@ -233,6 +235,68 @@ public void appendLeaderChangeMessage(Lead

[GitHub] [kafka] gardnervickers commented on a change in pull request #10896: KAFKA-12964: Collect and rename snapshot files prior to async deletion.

gardnervickers commented on a change in pull request #10896: URL: https://github.com/apache/kafka/pull/10896#discussion_r655545444 ## File path: core/src/main/scala/kafka/log/ProducerStateManager.scala ## @@ -828,12 +834,41 @@ class ProducerStateManager(val topicPartition: Top

[GitHub] [kafka] niket-goel commented on a change in pull request #10899: KAFKA-12952 Adding Delimeters to Metadata Snapshot File

niket-goel commented on a change in pull request #10899: URL: https://github.com/apache/kafka/pull/10899#discussion_r655546062 ## File path: raft/src/main/java/org/apache/kafka/snapshot/SnapshotWriter.java ## @@ -78,6 +83,76 @@ public SnapshotWriter( ); } +/

[GitHub] [kafka] niket-goel commented on a change in pull request #10899: KAFKA-12952 Adding Delimeters to Metadata Snapshot File

niket-goel commented on a change in pull request #10899: URL: https://github.com/apache/kafka/pull/10899#discussion_r655546225 ## File path: raft/src/main/java/org/apache/kafka/snapshot/SnapshotWriter.java ## @@ -135,9 +210,12 @@ public void append(List records) { /**

[GitHub] [kafka] niket-goel commented on a change in pull request #10899: KAFKA-12952 Adding Delimeters to Metadata Snapshot File

niket-goel commented on a change in pull request #10899: URL: https://github.com/apache/kafka/pull/10899#discussion_r655547991 ## File path: raft/src/main/java/org/apache/kafka/raft/internals/BatchAccumulator.java ## @@ -233,6 +235,68 @@ public void appendLeaderChangeMessage(L

[GitHub] [kafka] jsancio commented on a change in pull request #10899: KAFKA-12952 Adding Delimeters to Metadata Snapshot File

jsancio commented on a change in pull request #10899: URL: https://github.com/apache/kafka/pull/10899#discussion_r60695 ## File path: raft/src/main/java/org/apache/kafka/snapshot/SnapshotWriter.java ## @@ -135,9 +210,12 @@ public void append(List records) { /**

[GitHub] [kafka] niket-goel commented on a change in pull request #10899: KAFKA-12952 Adding Delimeters to Metadata Snapshot File

niket-goel commented on a change in pull request #10899: URL: https://github.com/apache/kafka/pull/10899#discussion_r62347 ## File path: raft/src/main/java/org/apache/kafka/snapshot/SnapshotWriter.java ## @@ -135,9 +210,12 @@ public void append(List records) { /**

[GitHub] [kafka] jsancio commented on a change in pull request #10899: KAFKA-12952 Adding Delimeters to Metadata Snapshot File

jsancio commented on a change in pull request #10899: URL: https://github.com/apache/kafka/pull/10899#discussion_r63349 ## File path: raft/src/main/java/org/apache/kafka/raft/internals/BatchAccumulator.java ## @@ -233,6 +235,68 @@ public void appendLeaderChangeMessage(Lead

[GitHub] [kafka] hachikuji commented on a change in pull request #10900: KAFKA-12967; KRaft broker should forward DescribeQuorum to controller

hachikuji commented on a change in pull request #10900: URL: https://github.com/apache/kafka/pull/10900#discussion_r66345 ## File path: core/src/test/java/kafka/test/annotation/Type.java ## @@ -28,7 +28,7 @@ * The type of cluster config being requested. Used by {@link ka

[jira] [Created] (KAFKA-12973) Update KIP and dev mailing list

Jose Armando Garcia Sancio created KAFKA-12973: -- Summary: Update KIP and dev mailing list Key: KAFKA-12973 URL: https://issues.apache.org/jira/browse/KAFKA-12973 Project: Kafka I

[jira] [Commented] (KAFKA-12972) KStreams - Rebalance not happening after new consumer member joins group

[ https://issues.apache.org/jira/browse/KAFKA-12972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17366745#comment-17366745 ] Matthias J. Sax commented on KAFKA-12972: - Is your application stateful? How lon

[jira] [Created] (KAFKA-12974) Change the default for snapshot generation configuration

Jose Armando Garcia Sancio created KAFKA-12974: -- Summary: Change the default for snapshot generation configuration Key: KAFKA-12974 URL: https://issues.apache.org/jira/browse/KAFKA-12974 P

[jira] [Updated] (KAFKA-12974) Change the default for snapshot generation configuration

[ https://issues.apache.org/jira/browse/KAFKA-12974?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jose Armando Garcia Sancio updated KAFKA-12974: --- Priority: Blocker (was: Major) > Change the default for snapshot ge

[jira] [Updated] (KAFKA-12974) Change the default for snapshot generation configuration

[ https://issues.apache.org/jira/browse/KAFKA-12974?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jose Armando Garcia Sancio updated KAFKA-12974: --- Description: In PR https://github.com/apache/kafka/pull/10812 the de

[jira] [Updated] (KAFKA-12974) Change the default for snapshot generation configuration

[ https://issues.apache.org/jira/browse/KAFKA-12974?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jose Armando Garcia Sancio updated KAFKA-12974: --- Affects Version/s: 3.0.0 > Change the default for snapshot generatio

[GitHub] [kafka] hachikuji commented on a change in pull request #10900: KAFKA-12967; KRaft broker should forward DescribeQuorum to controller

hachikuji commented on a change in pull request #10900: URL: https://github.com/apache/kafka/pull/10900#discussion_r655591961 ## File path: core/src/test/scala/unit/kafka/server/KafkaApisTest.scala ## @@ -462,16 +461,55 @@ class KafkaApisTest { @Test def testAlterConfigsW

[GitHub] [kafka] hachikuji merged pull request #10377: KAFKA-12515 ApiVersionManager should create response based on request version

hachikuji merged pull request #10377: URL: https://github.com/apache/kafka/pull/10377 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, plea

[jira] [Resolved] (KAFKA-12515) ApiVersionManager should create response based on request version

[ https://issues.apache.org/jira/browse/KAFKA-12515?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson resolved KAFKA-12515. - Fix Version/s: 3.0.0 Resolution: Fixed This issue was fixed by making feature sup

[GitHub] [kafka] hachikuji commented on a change in pull request #10900: KAFKA-12967; KRaft broker should forward DescribeQuorum to controller

hachikuji commented on a change in pull request #10900: URL: https://github.com/apache/kafka/pull/10900#discussion_r66345 ## File path: core/src/test/java/kafka/test/annotation/Type.java ## @@ -28,7 +28,7 @@ * The type of cluster config being requested. Used by {@link ka

[GitHub] [kafka] cmccabe commented on a change in pull request #10899: KAFKA-12952 Adding Delimiters to Metadata Snapshot

cmccabe commented on a change in pull request #10899: URL: https://github.com/apache/kafka/pull/10899#discussion_r655616706 ## File path: clients/src/main/java/org/apache/kafka/common/record/MemoryRecords.java ## @@ -664,4 +666,55 @@ private static void writeLeaderChangeMessag

[GitHub] [kafka] cmccabe commented on a change in pull request #10899: KAFKA-12952 Adding Delimiters to Metadata Snapshot

cmccabe commented on a change in pull request #10899: URL: https://github.com/apache/kafka/pull/10899#discussion_r655617424 ## File path: clients/src/main/java/org/apache/kafka/common/record/ControlRecordUtils.java ## @@ -27,6 +29,8 @@ public class ControlRecordUtils {

[GitHub] [kafka] cmccabe commented on a change in pull request #10899: KAFKA-12952 Adding Delimiters to Metadata Snapshot

cmccabe commented on a change in pull request #10899: URL: https://github.com/apache/kafka/pull/10899#discussion_r655617821 ## File path: clients/src/main/java/org/apache/kafka/common/record/ControlRecordUtils.java ## @@ -27,6 +29,8 @@ public class ControlRecordUtils {

[GitHub] [kafka] cmccabe commented on a change in pull request #10899: KAFKA-12952 Adding Delimiters to Metadata Snapshot

cmccabe commented on a change in pull request #10899: URL: https://github.com/apache/kafka/pull/10899#discussion_r655618351 ## File path: clients/src/main/resources/common/message/MetadataSnapshotFooterRecord.json ## @@ -0,0 +1,25 @@ +// Licensed to the Apache Software Foundat

[GitHub] [kafka] cmccabe commented on a change in pull request #10899: KAFKA-12952 Adding Delimiters to Metadata Snapshot

cmccabe commented on a change in pull request #10899: URL: https://github.com/apache/kafka/pull/10899#discussion_r655618509 ## File path: clients/src/main/resources/common/message/MetadataSnapshotHeaderRecord.json ## @@ -0,0 +1,25 @@ +// Licensed to the Apache Software Foundat

[GitHub] [kafka] niket-goel commented on a change in pull request #10899: KAFKA-12952 Adding Delimiters to Metadata Snapshot

niket-goel commented on a change in pull request #10899: URL: https://github.com/apache/kafka/pull/10899#discussion_r655625433 ## File path: clients/src/main/resources/common/message/MetadataSnapshotFooterRecord.json ## @@ -0,0 +1,25 @@ +// Licensed to the Apache Software Foun

[GitHub] [kafka] niket-goel commented on a change in pull request #10899: KAFKA-12952 Adding Delimiters to Metadata Snapshot

niket-goel commented on a change in pull request #10899: URL: https://github.com/apache/kafka/pull/10899#discussion_r655627008 ## File path: clients/src/main/java/org/apache/kafka/common/record/ControlRecordUtils.java ## @@ -27,6 +29,8 @@ public class ControlRecordUtils {

[GitHub] [kafka] cadonna commented on a change in pull request #10740: Kafka 8613 kip 633 drop default grace period streams

cadonna commented on a change in pull request #10740: URL: https://github.com/apache/kafka/pull/10740#discussion_r655626428 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/TimeWindows.java ## @@ -85,14 +87,11 @@ private TimeWindows(final long sizeMs, final

[GitHub] [kafka] hachikuji commented on a change in pull request #10814: KAFKA-12888; Add transaction tool from KIP-664

hachikuji commented on a change in pull request #10814: URL: https://github.com/apache/kafka/pull/10814#discussion_r655631267 ## File path: tools/src/main/java/org/apache/kafka/tools/TransactionsCommand.java ## @@ -0,0 +1,623 @@ +/* + * Licensed to the Apache Software Foundatio

[GitHub] [kafka] junrao commented on a change in pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

junrao commented on a change in pull request #9944: URL: https://github.com/apache/kafka/pull/9944#discussion_r655561404 ## File path: core/src/main/scala/kafka/server/FetchSession.scala ## @@ -471,16 +504,19 @@ class IncrementalFetchContext(private val time: Time, if (s

[GitHub] [kafka] jolshan commented on a change in pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

jolshan commented on a change in pull request #9944: URL: https://github.com/apache/kafka/pull/9944#discussion_r655642933 ## File path: core/src/test/scala/unit/kafka/server/FetchRequestTest.scala ## @@ -116,61 +122,85 @@ class FetchRequestTest extends BaseRequestTest { va

[GitHub] [kafka] jolshan commented on a change in pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

jolshan commented on a change in pull request #9944: URL: https://github.com/apache/kafka/pull/9944#discussion_r655643270 ## File path: core/src/test/scala/integration/kafka/api/AuthorizerIntegrationTest.scala ## @@ -154,17 +154,17 @@ class AuthorizerIntegrationTest extends Ba

[GitHub] [kafka] jolshan commented on a change in pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

jolshan commented on a change in pull request #9944: URL: https://github.com/apache/kafka/pull/9944#discussion_r655647688 ## File path: core/src/main/scala/kafka/server/FetchSession.scala ## @@ -471,16 +504,19 @@ class IncrementalFetchContext(private val time: Time, if (

[GitHub] [kafka] jolshan commented on a change in pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

jolshan commented on a change in pull request #9944: URL: https://github.com/apache/kafka/pull/9944#discussion_r655648541 ## File path: clients/src/main/java/org/apache/kafka/common/protocol/Errors.java ## @@ -362,7 +363,8 @@ BROKER_ID_NOT_REGISTERED(102, "The given broker

[GitHub] [kafka] jolshan commented on a change in pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

jolshan commented on a change in pull request #9944: URL: https://github.com/apache/kafka/pull/9944#discussion_r655649094 ## File path: clients/src/main/java/org/apache/kafka/common/requests/FetchResponse.java ## @@ -71,6 +79,14 @@ public FetchResponseData data() { re

[GitHub] [kafka] jolshan commented on a change in pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

jolshan commented on a change in pull request #9944: URL: https://github.com/apache/kafka/pull/9944#discussion_r655649425 ## File path: core/src/main/scala/kafka/server/metadata/RaftMetadataCache.scala ## @@ -226,6 +226,18 @@ class RaftMetadataCache(val brokerId: Int) extends

[GitHub] [kafka] jolshan commented on a change in pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

jolshan commented on a change in pull request #9944: URL: https://github.com/apache/kafka/pull/9944#discussion_r655649858 ## File path: core/src/main/scala/kafka/server/ReplicaFetcherThread.scala ## @@ -216,12 +217,21 @@ class ReplicaFetcherThread(name: String, try {

[GitHub] [kafka] rhauch commented on a change in pull request #10822: KAFKA-4793: Connect API to restart connector and tasks (KIP-745)

rhauch commented on a change in pull request #10822: URL: https://github.com/apache/kafka/pull/10822#discussion_r655658286 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/DistributedHerder.java ## @@ -1063,6 +1076,112 @@ public int gene

[GitHub] [kafka] izzyacademy commented on a change in pull request #10740: Kafka 8613 kip 633 drop default grace period streams

izzyacademy commented on a change in pull request #10740: URL: https://github.com/apache/kafka/pull/10740#discussion_r655661049 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/SessionWindows.java ## @@ -84,17 +86,14 @@ private SessionWindows(final long gap

[GitHub] [kafka] izzyacademy commented on a change in pull request #10740: Kafka 8613 kip 633 drop default grace period streams

izzyacademy commented on a change in pull request #10740: URL: https://github.com/apache/kafka/pull/10740#discussion_r655661436 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/SessionWindows.java ## @@ -119,6 +120,50 @@ public SessionWindows grace(final Du

[GitHub] [kafka] izzyacademy commented on a change in pull request #10740: Kafka 8613 kip 633 drop default grace period streams

izzyacademy commented on a change in pull request #10740: URL: https://github.com/apache/kafka/pull/10740#discussion_r655661859 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/Windows.java ## @@ -36,11 +36,11 @@ * @see SessionWindows * @see TimestampExt

[GitHub] [kafka] cadonna opened a new pull request #10912: MINOR: Remove obsolete variables for metric sensors

cadonna opened a new pull request #10912: URL: https://github.com/apache/kafka/pull/10912 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgra

[GitHub] [kafka] rhauch commented on a change in pull request #10822: KAFKA-4793: Connect API to restart connector and tasks (KIP-745)

rhauch commented on a change in pull request #10822: URL: https://github.com/apache/kafka/pull/10822#discussion_r655660680 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/RestartRequest.java ## @@ -0,0 +1,144 @@ +/* + * Licensed to the Apache Softw

[GitHub] [kafka] rhauch commented on a change in pull request #10822: KAFKA-4793: Connect API to restart connector and tasks (KIP-745)

rhauch commented on a change in pull request #10822: URL: https://github.com/apache/kafka/pull/10822#discussion_r655678526 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/DistributedHerder.java ## @@ -1063,6 +1076,132 @@ public int gene

[GitHub] [kafka] rhauch commented on a change in pull request #10822: KAFKA-4793: Connect API to restart connector and tasks (KIP-745)

rhauch commented on a change in pull request #10822: URL: https://github.com/apache/kafka/pull/10822#discussion_r655688374 ## File path: connect/runtime/src/test/java/org/apache/kafka/connect/util/clusters/EmbeddedConnectCluster.java ## @@ -559,6 +560,31 @@ public String endpo

[GitHub] [kafka] kowshik commented on pull request #10280: KAFKA-12554: Refactor Log layer

kowshik commented on pull request #10280: URL: https://github.com/apache/kafka/pull/10280#issuecomment-865332690 @junrao @dhruvilshah3 I ran a perf test against a Broker build with and without this PR. The test involved the following: 1. Created a test topic with 1 partition and repl

[GitHub] [kafka] niket-goel commented on a change in pull request #10899: KAFKA-12952 Adding Delimiters to Metadata Snapshot

niket-goel commented on a change in pull request #10899: URL: https://github.com/apache/kafka/pull/10899#discussion_r655696253 ## File path: clients/src/main/java/org/apache/kafka/common/record/MemoryRecords.java ## @@ -664,4 +666,55 @@ private static void writeLeaderChangeMes

[GitHub] [kafka] rhauch commented on a change in pull request #10822: KAFKA-4793: Connect API to restart connector and tasks (KIP-745)

rhauch commented on a change in pull request #10822: URL: https://github.com/apache/kafka/pull/10822#discussion_r655683692 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/DistributedHerder.java ## @@ -1592,6 +1731,28 @@ public void onSe

[GitHub] [kafka] ryannedolan commented on a change in pull request #10652: KAFKA-9726 IdentityReplicationPolicy

ryannedolan commented on a change in pull request #10652: URL: https://github.com/apache/kafka/pull/10652#discussion_r655712378 ## File path: connect/mirror-client/src/main/java/org/apache/kafka/connect/mirror/IdentityReplicationPolicy.java ## @@ -0,0 +1,101 @@ +/* + * License

[GitHub] [kafka] junrao commented on a change in pull request #10896: KAFKA-12964: Collect and rename snapshot files prior to async deletion.

junrao commented on a change in pull request #10896: URL: https://github.com/apache/kafka/pull/10896#discussion_r655714240 ## File path: core/src/main/scala/kafka/log/ProducerStateManager.scala ## @@ -828,12 +834,41 @@ class ProducerStateManager(val topicPartition: TopicPartit

[GitHub] [kafka] junrao commented on a change in pull request #10896: KAFKA-12964: Collect and rename snapshot files prior to async deletion.

junrao commented on a change in pull request #10896: URL: https://github.com/apache/kafka/pull/10896#discussion_r655727698 ## File path: core/src/main/scala/kafka/log/ProducerStateManager.scala ## @@ -828,12 +834,41 @@ class ProducerStateManager(val topicPartition: TopicPartit

[GitHub] [kafka] jsancio commented on a change in pull request #10812: KAFKA-12863: Configure controller snapshot generation

jsancio commented on a change in pull request #10812: URL: https://github.com/apache/kafka/pull/10812#discussion_r655732329 ## File path: core/src/main/scala/kafka/server/KafkaConfig.scala ## @@ -74,6 +74,7 @@ object Defaults { val InitialBrokerRegistrationTimeoutMs = 6

[GitHub] [kafka] gardnervickers commented on a change in pull request #10896: KAFKA-12964: Collect and rename snapshot files prior to async deletion.

gardnervickers commented on a change in pull request #10896: URL: https://github.com/apache/kafka/pull/10896#discussion_r655747538 ## File path: core/src/main/scala/kafka/log/ProducerStateManager.scala ## @@ -828,12 +834,41 @@ class ProducerStateManager(val topicPartition: Top

[GitHub] [kafka] kpatelatwork commented on a change in pull request #10822: KAFKA-4793: Connect API to restart connector and tasks (KIP-745)

kpatelatwork commented on a change in pull request #10822: URL: https://github.com/apache/kafka/pull/10822#discussion_r655749684 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/DistributedHerder.java ## @@ -1063,6 +1076,132 @@ public in

[GitHub] [kafka] skaundinya15 commented on a change in pull request #10743: KIP-699: Update FindCoordinator to resolve multiple Coordinators at a time

skaundinya15 commented on a change in pull request #10743: URL: https://github.com/apache/kafka/pull/10743#discussion_r655751842 ## File path: clients/src/main/resources/common/message/FindCoordinatorRequest.json ## @@ -23,12 +23,16 @@ // Version 2 is the same as version 1.

[GitHub] [kafka] C0urante commented on pull request #10907: KAFKA-10000: Exactly-once support for source connectors

C0urante commented on pull request #10907: URL: https://github.com/apache/kafka/pull/10907#issuecomment-865396213 There was a small misunderstanding of the rebalance logic for distributed workers. It turns out that they already preemptively stop reconfigured tasks before (re)joining the gr

[GitHub] [kafka] kpatelatwork commented on a change in pull request #10822: KAFKA-4793: Connect API to restart connector and tasks (KIP-745)

kpatelatwork commented on a change in pull request #10822: URL: https://github.com/apache/kafka/pull/10822#discussion_r655755572 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/DistributedHerder.java ## @@ -1592,6 +1731,28 @@ public voi

[GitHub] [kafka] kpatelatwork commented on a change in pull request #10822: KAFKA-4793: Connect API to restart connector and tasks (KIP-745)

kpatelatwork commented on a change in pull request #10822: URL: https://github.com/apache/kafka/pull/10822#discussion_r655755798 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/RestartRequest.java ## @@ -0,0 +1,144 @@ +/* + * Licensed to the Apache

[GitHub] [kafka] kpatelatwork commented on a change in pull request #10822: KAFKA-4793: Connect API to restart connector and tasks (KIP-745)

kpatelatwork commented on a change in pull request #10822: URL: https://github.com/apache/kafka/pull/10822#discussion_r655757673 ## File path: connect/runtime/src/test/java/org/apache/kafka/connect/util/clusters/EmbeddedConnectCluster.java ## @@ -559,6 +560,31 @@ public String

[GitHub] [kafka] kpatelatwork commented on a change in pull request #10822: KAFKA-4793: Connect API to restart connector and tasks (KIP-745)

kpatelatwork commented on a change in pull request #10822: URL: https://github.com/apache/kafka/pull/10822#discussion_r655749684 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/DistributedHerder.java ## @@ -1063,6 +1076,132 @@ public in

[GitHub] [kafka] hachikuji opened a new pull request #10913: KAFKA-12631; Implement `resign` API in `KafkaRaftClient`

hachikuji opened a new pull request #10913: URL: https://github.com/apache/kafka/pull/10913 This patch adds an implementation of the `resign()` API which allows the controller to proactively resign leadership in case it encounters an unrecoverable situation. There was not a lot to do here

[GitHub] [kafka] rhauch commented on a change in pull request #10822: KAFKA-4793: Connect API to restart connector and tasks (KIP-745)

rhauch commented on a change in pull request #10822: URL: https://github.com/apache/kafka/pull/10822#discussion_r655776106 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/DistributedHerder.java ## @@ -1063,6 +1076,132 @@ public int gene

[GitHub] [kafka] vitojeng commented on pull request #10825: KAFKA-5876: Add `streams()` method to StateStoreProvider

vitojeng commented on pull request #10825: URL: https://github.com/apache/kafka/pull/10825#issuecomment-865419554 Hey @ableegoldman, just a remind. Please take a look, when you have time. :) -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] rhauch commented on a change in pull request #10822: KAFKA-4793: Connect API to restart connector and tasks (KIP-745)

rhauch commented on a change in pull request #10822: URL: https://github.com/apache/kafka/pull/10822#discussion_r655778416 ## File path: connect/runtime/src/test/java/org/apache/kafka/connect/util/clusters/EmbeddedConnectCluster.java ## @@ -559,6 +560,31 @@ public String endpo

[GitHub] [kafka] rhauch commented on a change in pull request #10822: KAFKA-4793: Connect API to restart connector and tasks (KIP-745)

rhauch commented on a change in pull request #10822: URL: https://github.com/apache/kafka/pull/10822#discussion_r655779197 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/RestartRequest.java ## @@ -0,0 +1,145 @@ +/* + * Licensed to the Apache Softw

[GitHub] [kafka] kowshik commented on a change in pull request #10896: KAFKA-12964: Collect and rename snapshot files prior to async deletion.

kowshik commented on a change in pull request #10896: URL: https://github.com/apache/kafka/pull/10896#discussion_r655768001 ## File path: core/src/main/scala/kafka/log/ProducerStateManager.scala ## @@ -828,15 +834,50 @@ class ProducerStateManager(val topicPartition: TopicParti

[GitHub] [kafka] kowshik commented on a change in pull request #10896: KAFKA-12964: Collect and rename snapshot files prior to async deletion.

kowshik commented on a change in pull request #10896: URL: https://github.com/apache/kafka/pull/10896#discussion_r655788102 ## File path: core/src/test/scala/unit/kafka/log/LogLoaderTest.scala ## @@ -1535,4 +1534,122 @@ class LogLoaderTest { assertTrue(onlySegment.lazyOffs

[jira] [Created] (KAFKA-12975) Consider how Topic IDs can improve consume experience

Justine Olshan created KAFKA-12975: -- Summary: Consider how Topic IDs can improve consume experience Key: KAFKA-12975 URL: https://issues.apache.org/jira/browse/KAFKA-12975 Project: Kafka Iss

  1   2   >