niket-goel commented on a change in pull request #10899:
URL: https://github.com/apache/kafka/pull/10899#discussion_r655627008
##########
File path:
clients/src/main/java/org/apache/kafka/common/record/ControlRecordUtils.java
##########
@@ -27,6 +29,8 @@
public class ControlRecordUtils {
public static final short LEADER_CHANGE_SCHEMA_VERSION = new
LeaderChangeMessage().highestSupportedVersion();
+ public static final short METADATA_SNAPSHOT_HEADER_VERSION = new
MetadataSnapshotHeaderRecord().highestSupportedVersion();
Review comment:
I honestly do not have an opinion here. Was following what was done for
the LEADER_CHANGE message (right above it). I think saying highest supported
version (or maybe even current version) would make sense. I would then change
the leader change message related constants as well to be consistent. Let me do
that in the next version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
