cmccabe commented on a change in pull request #10899:
URL: https://github.com/apache/kafka/pull/10899#discussion_r655617424
##########
File path:
clients/src/main/java/org/apache/kafka/common/record/ControlRecordUtils.java
##########
@@ -27,6 +29,8 @@
public class ControlRecordUtils {
public static final short LEADER_CHANGE_SCHEMA_VERSION = new
LeaderChangeMessage().highestSupportedVersion();
+ public static final short METADATA_SNAPSHOT_HEADER_VERSION = new
MetadataSnapshotHeaderRecord().highestSupportedVersion();
Review comment:
Do we really need this constant? It seems confusing since it implies
there is only one version ever, but there may well be more versions later on.
If you mean highest supported, why not just say highest supported rather than
referring to "the version"?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
