jolshan commented on a change in pull request #9944:
URL: https://github.com/apache/kafka/pull/9944#discussion_r655648541
##########
File path: clients/src/main/java/org/apache/kafka/common/protocol/Errors.java
##########
@@ -362,7 +363,8 @@
BROKER_ID_NOT_REGISTERED(102, "The given broker ID was not registered.",
BrokerIdNotRegisteredException::new),
INCONSISTENT_TOPIC_ID(103, "The log's topic ID did not match the topic ID
in the request", InconsistentTopicIdException::new),
INCONSISTENT_CLUSTER_ID(104, "The clusterId in the request does not match
that found on the server", InconsistentClusterIdException::new),
- TRANSACTIONAL_ID_NOT_FOUND(105, "The transactionalId could not be found",
TransactionalIdNotFoundException::new);
+ TRANSACTIONAL_ID_NOT_FOUND(105, "The transactionalId could not be found",
TransactionalIdNotFoundException::new),
+ FETCH_SESSION_TOPIC_ID_ERROR(106, "The fetch session encountered
inconsistent topic ID usage", FetchSessionTopicIdException::new);
Review comment:
I think the main reason why I made the session ID error was that the
inconsistent topic ID error's message was too specific for this use case. I
suppose we could just make all the errors here session errors. I do like the
inconsistent ID error specifying the log (and being on the partition with the
issue), but we can change this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
