rondagostino edited a comment on pull request #10908:
URL: https://github.com/apache/kafka/pull/10908#issuecomment-865055596


   Sorry to come to this party a bit late.  It is likely that the code had a 
mistake and broker.id=0 should have been broker.id=1.  But even with the 
mistake, I wonder if this test should have passed anyway given that the test 
with the ZK-based controller succeeded.  In other words, the check at 
https://github.com/apache/kafka/blob/trunk/metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java#L950
 means there is a behavior difference between the ZK-based and KRaft 
controllers.  Do we explicitly acknowledge and accept this difference?  cc 
@cmccabe 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to