peterxcli commented on PR #18096:
URL: https://github.com/apache/kafka/pull/18096#issuecomment-2534114883
Thanks for your review! address some of the comments in
https://github.com/apache/kafka/pull/18096/commits/8afdd78b27c977eacd3fe3cd175ed23201d17929,
PTAL. Thanks!
--
This is an autom
dajac commented on code in PR #18127:
URL: https://github.com/apache/kafka/pull/18127#discussion_r1879482075
##
generator/src/main/java/org/apache/kafka/message/MessageDataGenerator.java:
##
@@ -1343,6 +1343,11 @@ private void generateVariableLengthFieldSize(FieldSpec
field,
smjn commented on PR #18014:
URL: https://github.com/apache/kafka/pull/18014#issuecomment-2533973233
> @smjn : Thanks for the updated PR. Just one more comment.
@junrao Thanks for the review, incorporated change
--
This is an automated message from the Apache Git Service.
To respond
[
https://issues.apache.org/jira/browse/KAFKA-18188?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Jacot resolved KAFKA-18188.
-
Resolution: Fixed
> Admin LeaveGroup should allow removing member using consumer protocol by
>
dajac merged PR #18116:
URL: https://github.com/apache/kafka/pull/18116
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or
smjn commented on code in PR #18014:
URL: https://github.com/apache/kafka/pull/18014#discussion_r1879468691
##
share-coordinator/src/main/java/org/apache/kafka/coordinator/share/ShareCoordinatorService.java:
##
@@ -543,6 +629,7 @@ public void onElection(int partitionIndex, int
junrao commented on code in PR #18014:
URL: https://github.com/apache/kafka/pull/18014#discussion_r1879419372
##
share-coordinator/src/main/java/org/apache/kafka/coordinator/share/ShareCoordinatorService.java:
##
@@ -543,6 +629,7 @@ public void onElection(int partitionIndex, int
m1a2st commented on PR #18104:
URL: https://github.com/apache/kafka/pull/18104#issuecomment-2533766685
Hello @ableegoldman,
We should not set java version in the Project Structure > Project Settings >
Modules, when we import the new kafka project, and refresh the gradle build,
You ca
smjn commented on code in PR #18014:
URL: https://github.com/apache/kafka/pull/18014#discussion_r1879319264
##
share-coordinator/src/main/java/org/apache/kafka/coordinator/share/ShareCoordinatorService.java:
##
@@ -240,9 +251,96 @@ public void startup(
log.info("Start
smjn commented on code in PR #18014:
URL: https://github.com/apache/kafka/pull/18014#discussion_r1879319264
##
share-coordinator/src/main/java/org/apache/kafka/coordinator/share/ShareCoordinatorService.java:
##
@@ -240,9 +251,96 @@ public void startup(
log.info("Start
smjn commented on PR #18014:
URL: https://github.com/apache/kafka/pull/18014#issuecomment-2533654614
> @smjn : Thanks for the updated PR. A few more comments.
@junrao Thanks for the review, incorporated few changes. Replied to some
suggestions.
--
This is an automated message from
smjn commented on code in PR #18014:
URL: https://github.com/apache/kafka/pull/18014#discussion_r1879347536
##
share-coordinator/src/main/java/org/apache/kafka/coordinator/share/ShareCoordinatorService.java:
##
@@ -240,9 +251,96 @@ public void startup(
log.info("Start
peterxcli commented on code in PR #18096:
URL: https://github.com/apache/kafka/pull/18096#discussion_r1879331695
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/ShareGroupAutoOffsetResetStrategy.java:
##
@@ -0,0 +1,162 @@
+/*
+ * Licensed to the Apache Soft
smjn commented on code in PR #18014:
URL: https://github.com/apache/kafka/pull/18014#discussion_r1879347536
##
share-coordinator/src/main/java/org/apache/kafka/coordinator/share/ShareCoordinatorService.java:
##
@@ -240,9 +251,96 @@ public void startup(
log.info("Start
smjn commented on code in PR #18014:
URL: https://github.com/apache/kafka/pull/18014#discussion_r1879347536
##
share-coordinator/src/main/java/org/apache/kafka/coordinator/share/ShareCoordinatorService.java:
##
@@ -240,9 +251,96 @@ public void startup(
log.info("Start
[
https://issues.apache.org/jira/browse/KAFKA-18026?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
A. Sophie Blee-Goldman updated KAFKA-18026:
---
Description:
See KIP-1112:
[https://cwiki.apache.org/confluence/display/KAF
ableegoldman commented on code in PR #18111:
URL: https://github.com/apache/kafka/pull/18111#discussion_r1879325001
##
streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamImplJoin.java:
##
@@ -209,19 +209,13 @@ public KStream join(final
KStream lhs,
ableegoldman commented on code in PR #18111:
URL: https://github.com/apache/kafka/pull/18111#discussion_r1879317228
##
streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamKStreamJoin.java:
##
@@ -77,10 +85,21 @@ abstract class KStreamKStreamJoin impleme
ableegoldman commented on code in PR #18111:
URL: https://github.com/apache/kafka/pull/18111#discussion_r1879317228
##
streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamKStreamJoin.java:
##
@@ -77,10 +85,21 @@ abstract class KStreamKStreamJoin impleme
ableegoldman commented on code in PR #18111:
URL: https://github.com/apache/kafka/pull/18111#discussion_r1879319328
##
streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamKStreamJoin.java:
##
@@ -77,10 +85,21 @@ abstract class KStreamKStreamJoin impleme
ableegoldman commented on code in PR #18111:
URL: https://github.com/apache/kafka/pull/18111#discussion_r1879319328
##
streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamKStreamJoin.java:
##
@@ -77,10 +85,21 @@ abstract class KStreamKStreamJoin impleme
smjn commented on code in PR #18014:
URL: https://github.com/apache/kafka/pull/18014#discussion_r1879319264
##
share-coordinator/src/main/java/org/apache/kafka/coordinator/share/ShareCoordinatorService.java:
##
@@ -240,9 +251,96 @@ public void startup(
log.info("Start
smjn commented on code in PR #18014:
URL: https://github.com/apache/kafka/pull/18014#discussion_r1879314223
##
core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala:
##
@@ -6660,6 +6661,61 @@ class ReplicaManagerTest {
}
}
+ @Test
+ def testDeleteRecordsInte
ableegoldman commented on code in PR #18111:
URL: https://github.com/apache/kafka/pull/18111#discussion_r1879317228
##
streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamKStreamJoin.java:
##
@@ -77,10 +85,21 @@ abstract class KStreamKStreamJoin impleme
ableegoldman commented on code in PR #18111:
URL: https://github.com/apache/kafka/pull/18111#discussion_r1879317228
##
streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamKStreamJoin.java:
##
@@ -77,10 +85,21 @@ abstract class KStreamKStreamJoin impleme
smjn commented on code in PR #18014:
URL: https://github.com/apache/kafka/pull/18014#discussion_r1879314223
##
core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala:
##
@@ -6660,6 +6661,61 @@ class ReplicaManagerTest {
}
}
+ @Test
+ def testDeleteRecordsInte
peterxcli commented on code in PR #18096:
URL: https://github.com/apache/kafka/pull/18096#discussion_r1879310504
##
core/src/main/java/kafka/server/share/SharePartition.java:
##
@@ -2125,16 +2128,25 @@ private long startOffsetDuringInitialization(long
partitionDataStartOffset)
peterxcli commented on code in PR #18096:
URL: https://github.com/apache/kafka/pull/18096#discussion_r1879310504
##
core/src/main/java/kafka/server/share/SharePartition.java:
##
@@ -2125,16 +2128,25 @@ private long startOffsetDuringInitialization(long
partitionDataStartOffset)
ableegoldman commented on PR #18104:
URL: https://github.com/apache/kafka/pull/18104#issuecomment-2533596088
I'm trying to test this out by setting the language level for the streams
module under 'Project Structure', but:
1. setting this to 11 does not seem to have any effect (eg I ca
ableegoldman commented on code in PR #18115:
URL: https://github.com/apache/kafka/pull/18115#discussion_r1879300713
##
streams/src/main/java/org/apache/kafka/streams/kstream/internals/OffsetResetStrategy.java:
##
@@ -0,0 +1,23 @@
+/*
+ * Licensed to the Apache Software Foundatio
ableegoldman commented on code in PR #18115:
URL: https://github.com/apache/kafka/pull/18115#discussion_r1879301190
##
streams/src/main/java/org/apache/kafka/streams/AutoOffsetReset.java:
##
@@ -0,0 +1,21 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or m
[
https://issues.apache.org/jira/browse/KAFKA-18196?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
A. Sophie Blee-Goldman reassigned KAFKA-18196:
--
Assignee: Kuan Po Tseng
> Reuse window store for stream-stream self-j
[
https://issues.apache.org/jira/browse/KAFKA-18201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
PoAn Yang reassigned KAFKA-18201:
-
Assignee: PoAn Yang
> testGroupMetadataMessageFormatter fails for new consumer protocol
> -
[
https://issues.apache.org/jira/browse/KAFKA-18196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17904676#comment-17904676
]
A. Sophie Blee-Goldman commented on KAFKA-18196:
[~brandboat] go ahead!
[
https://issues.apache.org/jira/browse/KAFKA-18204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17904675#comment-17904675
]
Suresh Kumar edited comment on KAFKA-18204 at 12/11/24 3:54 AM:
--
ableegoldman commented on code in PR #18048:
URL: https://github.com/apache/kafka/pull/18048#discussion_r1879290561
##
streams/src/main/java/org/apache/kafka/streams/kstream/internals/graph/KTableKTableJoinNode.java:
##
@@ -120,30 +115,13 @@ private void enableVersionedSemantics
Radha Krishna Peteti created KAFKA-18204:
Summary: Upgrade to rocksdb 8.x+ (ideally 9.x)
Key: KAFKA-18204
URL: https://issues.apache.org/jira/browse/KAFKA-18204
Project: Kafka
Issue T
[
https://issues.apache.org/jira/browse/KAFKA-18204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17904675#comment-17904675
]
Suresh Kumar commented on KAFKA-18204:
--
Sure. [~swikarpat]
> Upgrade to rocksdb 8
[
https://issues.apache.org/jira/browse/KAFKA-18204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17904674#comment-17904674
]
Swikar Patel commented on KAFKA-18204:
--
[~neo2308] [~suresh7] May I also work on th
mjsax commented on code in PR #18115:
URL: https://github.com/apache/kafka/pull/18115#discussion_r1879288248
##
streams/src/main/java/org/apache/kafka/streams/AutoOffsetReset.java:
##
@@ -0,0 +1,21 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ *
mjsax commented on code in PR #18115:
URL: https://github.com/apache/kafka/pull/18115#discussion_r1879287234
##
streams/src/main/java/org/apache/kafka/streams/kstream/internals/OffsetResetStrategy.java:
##
@@ -0,0 +1,23 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
ableegoldman commented on code in PR #18048:
URL: https://github.com/apache/kafka/pull/18048#discussion_r1879285311
##
streams/src/test/java/org/apache/kafka/streams/StreamsBuilderTest.java:
##
@@ -1816,6 +1816,102 @@ public void
shouldWrapProcessorsForStreamTableJoinWithGraceP
gharris1727 commented on code in PR #17741:
URL: https://github.com/apache/kafka/pull/17741#discussion_r1879274614
##
.gitignore:
##
@@ -61,3 +61,6 @@ storage/kafka-tiered-storage/
docker/test/report_*.html
kafka.Kafka
__pycache__
+/connect/runtime/src/main/java/org/apache/ka
[
https://issues.apache.org/jira/browse/KAFKA-18204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17904669#comment-17904669
]
Radha Krishna Peteti commented on KAFKA-18204:
--
[~suresh7] Sure!
> Upgrade
[
https://issues.apache.org/jira/browse/KAFKA-18198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17904670#comment-17904670
]
Suresh Kumar edited comment on KAFKA-18198 at 12/11/24 3:25 AM:
--
lianetm commented on code in PR #18089:
URL: https://github.com/apache/kafka/pull/18089#discussion_r1879280407
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractMembershipManager.java:
##
@@ -1175,21 +1175,8 @@ private CompletableFuture assignPartition
[
https://issues.apache.org/jira/browse/KAFKA-18204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17904668#comment-17904668
]
Suresh Kumar commented on KAFKA-18204:
--
[~neo2308] May I take over the ticket?
>
Wuzhengyu97 closed pull request #18118: MINOR: Remove waitUntilTrue from
TestUtils.scala.
URL: https://github.com/apache/kafka/pull/18118
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
lianetm commented on PR #15188:
URL: https://github.com/apache/kafka/pull/15188#issuecomment-2533525332
This is the old PR, so closing it in favour of the other 5 ones attached to
the jira https://issues.apache.org/jira/browse/KAFKA-15561 (all already in
trunk). Starts with https://github.c
mjsax commented on PR #17973:
URL: https://github.com/apache/kafka/pull/17973#issuecomment-2533532798
@KApolinario1120 -- I believe I did push all changes we need. No need to
update this PR from your side.
Please take a look. Happy to answer any questions you might have.
A seco
[
https://issues.apache.org/jira/browse/KAFKA-18198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17904670#comment-17904670
]
Suresh Kumar commented on KAFKA-18198:
--
[~shivsundar] Can I give a try, If you are
ableegoldman commented on code in PR #18115:
URL: https://github.com/apache/kafka/pull/18115#discussion_r1879259411
##
streams/src/main/java/org/apache/kafka/streams/AutoOffsetReset.java:
##
@@ -0,0 +1,21 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or m
gharris1727 commented on PR #17741:
URL: https://github.com/apache/kafka/pull/17741#issuecomment-2533532836
> There is another unrelated issue I came across while testing this PR.
There might be a regression in https://github.com/apache/kafka/pull/16604
Great catch! That regression ha
[
https://issues.apache.org/jira/browse/KAFKA-18204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Suresh Kumar reassigned KAFKA-18204:
Assignee: Suresh Kumar
> Upgrade to rocksdb 8.x+ (ideally 9.x)
>
mjsax commented on PR #17973:
URL: https://github.com/apache/kafka/pull/17973#issuecomment-2533528939
@bbejeck -- needed to rebase this one, to remove `OffsetResetStrategy` enum
in favor of `AutoOffsetResetStrategy.StategyType` as discussed on the other PR.
(No rebasing conflict luckily).
lianetm closed pull request #15188: KAFKA-15561: Client support for new
SubscriptionPattern based subscription
URL: https://github.com/apache/kafka/pull/15188
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
lianetm commented on code in PR #17199:
URL: https://github.com/apache/kafka/pull/17199#discussion_r1879255266
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##
@@ -1893,25 +1901,30 @@ private void subscribeInternal(Collection
topi
ableegoldman commented on code in PR #18087:
URL: https://github.com/apache/kafka/pull/18087#discussion_r1879254935
##
docs/streams/developer-guide/config-streams.html:
##
@@ -231,9 +231,9 @@ num.standby.replicasStreams
javadocs, sorted by level of importance:
[
https://issues.apache.org/jira/browse/KAFKA-18201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17904664#comment-17904664
]
Lianet Magrans commented on KAFKA-18201:
Sure, thanks! For more context, I found
mumrah opened a new pull request, #18133:
URL: https://github.com/apache/kafka/pull/18133
Follow up for #17881, ignores missing "triage" label in the pr-reviewed
workflow
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and us
[
https://issues.apache.org/jira/browse/KAFKA-17836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17904661#comment-17904661
]
Chia-Chuan Yu commented on KAFKA-17836:
---
Hi,[~chia7712]
Since RackAwareTest is r
snehashisp commented on PR #17741:
URL: https://github.com/apache/kafka/pull/17741#issuecomment-2533473455
Hi @gharris1727. Please take another pass. I have made the requested
changes, lmk if I have missed anything. Some tests are failing, will look into
those soon.
There is another
kirktrue commented on code in PR #15188:
URL: https://github.com/apache/kafka/pull/15188#discussion_r1879194394
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/LegacyKafkaConsumer.java:
##
@@ -495,6 +496,16 @@ public void subscribe(Pattern pattern) {
TaiJuWu closed pull request #18082: [DON'T MERGE] test deadlockDection
URL: https://github.com/apache/kafka/pull/18082
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubs
mjsax commented on code in PR #18115:
URL: https://github.com/apache/kafka/pull/18115#discussion_r1879177803
##
streams/src/main/java/org/apache/kafka/streams/kstream/internals/OffsetResetStrategy.java:
##
@@ -0,0 +1,23 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
kirktrue commented on code in PR #15312:
URL: https://github.com/apache/kafka/pull/15312#discussion_r1879175893
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThread.java:
##
@@ -87,8 +92,8 @@ public void run() {
try {
kirktrue commented on PR #15312:
URL: https://github.com/apache/kafka/pull/15312#issuecomment-2533414719
Looks like there are some conflicts to resolve as well. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use t
mjsax commented on code in PR #18115:
URL: https://github.com/apache/kafka/pull/18115#discussion_r1879170317
##
streams/src/main/java/org/apache/kafka/streams/kstream/internals/OffsetResetStrategy.java:
##
@@ -0,0 +1,23 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
kirktrue commented on code in PR #17199:
URL: https://github.com/apache/kafka/pull/17199#discussion_r1879153121
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##
@@ -1893,25 +1901,30 @@ private void subscribeInternal(Collection
top
mjsax commented on code in PR #18115:
URL: https://github.com/apache/kafka/pull/18115#discussion_r1879168017
##
streams/src/main/java/org/apache/kafka/streams/kstream/internals/AutoOffsetResetInternal.java:
##
@@ -0,0 +1,64 @@
+/*
+ * Licensed to the Apache Software Foundation (
m1a2st commented on code in PR #18050:
URL: https://github.com/apache/kafka/pull/18050#discussion_r1879153506
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/CoordinatorRequestManager.java:
##
@@ -188,12 +184,12 @@ private void onFailedResponse(final long cu
m1a2st commented on PR #18104:
URL: https://github.com/apache/kafka/pull/18104#issuecomment-2533343930
Thanks for @ijuma suggestion
> We should probably state in the README that configuring the IntelliJ SDK
to Java 17 is likely to be the best compromise given that most modules have
Java
黃竣陽 created KAFKA-18203:
---
Summary: Add a section for Java version in intellij idea in README
Key: KAFKA-18203
URL: https://issues.apache.org/jira/browse/KAFKA-18203
Project: Kafka
Issue Type: Improveme
brandboat commented on code in PR #18036:
URL: https://github.com/apache/kafka/pull/18036#discussion_r1879128919
##
tests/kafkatest/tests/verifiable_consumer_test.py:
##
@@ -56,7 +55,7 @@ def min_cluster_size(self):
def setup_consumer(self, topic, static_membership=False,
bbejeck commented on code in PR #18115:
URL: https://github.com/apache/kafka/pull/18115#discussion_r1879083489
##
streams/src/main/java/org/apache/kafka/streams/Topology.java:
##
@@ -326,7 +327,7 @@ public synchronized Topology addSource(final
AutoOffsetReset offsetReset,
junrao commented on code in PR #18014:
URL: https://github.com/apache/kafka/pull/18014#discussion_r1879095991
##
share-coordinator/src/main/java/org/apache/kafka/coordinator/share/ShareCoordinatorService.java:
##
@@ -240,9 +251,96 @@ public void startup(
log.info("Sta
mjsax commented on code in PR #17973:
URL: https://github.com/apache/kafka/pull/17973#discussion_r1879107930
##
streams/src/main/java/org/apache/kafka/streams/Topology.java:
##
@@ -252,6 +325,27 @@ public synchronized Topology addSource(final
AutoOffsetReset offsetReset,
frankvicky commented on PR #17404:
URL: https://github.com/apache/kafka/pull/17404#issuecomment-2533267955
@chia7712 Could you please take a look ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
cshannon commented on PR #16754:
URL: https://github.com/apache/kafka/pull/16754#issuecomment-2533261940
@gharris1727 and @chia7712 - I think I addressed all the comments so this
can be merged. The only outstanding
[one](https://github.com/apache/kafka/pull/16754#discussion_r1879098262) was
cshannon commented on code in PR #16754:
URL: https://github.com/apache/kafka/pull/16754#discussion_r1879098262
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/rest/HerderRequestHandler.java:
##
@@ -113,6 +113,7 @@ public T completeOrForwardRequest(FutureCallb
cshannon commented on code in PR #16754:
URL: https://github.com/apache/kafka/pull/16754#discussion_r1879095660
##
connect/mirror/src/test/java/org/apache/kafka/connect/mirror/integration/DedicatedMirrorIntegrationTest.java:
##
@@ -280,7 +280,12 @@ public void testMultiNodeClust
ijuma commented on PR #18104:
URL: https://github.com/apache/kafka/pull/18104#issuecomment-2533247888
Good point @chia7712 - it seems like the internal model for IntelliJ is
actually correct even though the settings screen isn't. One other inconsistency
I noticed is that IntelliJ seems to o
[
https://issues.apache.org/jira/browse/KAFKA-18176?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-18176:
--
Fix Version/s: 4.0.0
> Consumer system tests failure due to unsupported protocol configs
> ---
ahuang98 commented on code in PR #17807:
URL: https://github.com/apache/kafka/pull/17807#discussion_r1879062350
##
raft/src/main/java/org/apache/kafka/raft/QuorumState.java:
##
@@ -44,7 +44,7 @@
*Follower: After discovering a leader with an equal or larger epoch
*
* Un
ahuang98 commented on code in PR #17807:
URL: https://github.com/apache/kafka/pull/17807#discussion_r1879075672
##
raft/src/main/java/org/apache/kafka/raft/FollowerState.java:
##
@@ -202,16 +205,34 @@ public void
setFetchingSnapshot(Optional newSnapshot) {
}
@Overri
junrao commented on code in PR #18014:
URL: https://github.com/apache/kafka/pull/18014#discussion_r1879044017
##
share-coordinator/src/main/java/org/apache/kafka/coordinator/share/ShareCoordinatorService.java:
##
@@ -240,9 +251,96 @@ public void startup(
log.info("Sta
ahuang98 commented on code in PR #17807:
URL: https://github.com/apache/kafka/pull/17807#discussion_r1879049273
##
raft/src/main/java/org/apache/kafka/raft/EpochState.java:
##
@@ -26,16 +26,18 @@ default Optional highWatermark() {
}
/**
- * Decide whether to gran
bbejeck commented on PR #17973:
URL: https://github.com/apache/kafka/pull/17973#issuecomment-2533211105
build failure is related looks a `spotless` error
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
bbejeck commented on code in PR #17973:
URL: https://github.com/apache/kafka/pull/17973#discussion_r1879018744
##
streams/src/main/java/org/apache/kafka/streams/Topology.java:
##
@@ -252,6 +325,27 @@ public synchronized Topology addSource(final
AutoOffsetReset offsetReset,
[
https://issues.apache.org/jira/browse/KAFKA-18176?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-18176:
--
Labels: kip-848-client-support (was: )
> Consumer system tests failure due to unsupported protocol co
gharris1727 commented on PR #17881:
URL: https://github.com/apache/kafka/pull/17881#issuecomment-2533204626
Another quirk: this is causing workflows to fail after reviewing PRs:
https://github.com/apache/kafka/actions/runs/12266421343
It doesn't block anything, it just seems to genera
jolshan opened a new pull request, #18132:
URL: https://github.com/apache/kafka/pull/18132
Added transaction version 2 to some of the system tests. Also marking TV2 as
production ready.
Will share the results of the tests when I get them.
--
This is an automated message from the A
[
https://issues.apache.org/jira/browse/KAFKA-17915?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-17915:
--
Labels: consumer-threading-refactor (was: )
> Convert Kafka Client system tests to use KRaft
> --
[
https://issues.apache.org/jira/browse/KAFKA-18158?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-18158:
--
Fix Version/s: 4.0.0
> Add subscribePattern integration tests for subsequent subscription
> --
gharris1727 commented on code in PR #16754:
URL: https://github.com/apache/kafka/pull/16754#discussion_r1879053818
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/rest/util/SSLUtilsTest.java:
##
@@ -33,6 +36,22 @@
public class SSLUtilsTest {
+private M
[
https://issues.apache.org/jira/browse/KAFKA-18158?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-18158:
--
Component/s: clients
> Add subscribePattern integration tests for subsequent subscription
> --
kirktrue commented on PR #17404:
URL: https://github.com/apache/kafka/pull/17404#issuecomment-2533195153
@frankvicky—where are we on merging this? It appears the build and all tests
pass.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
[
https://issues.apache.org/jira/browse/KAFKA-18158?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-18158:
--
Labels: integration-test kip-848-client-support (was:
kip-848-client-support)
> Add subscribePattern
[
https://issues.apache.org/jira/browse/KAFKA-18117?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-18117:
--
Component/s: clients
> Support topic IDs in consumer SubscriptionState
> -
FrankYang0529 commented on PR #17199:
URL: https://github.com/apache/kafka/pull/17199#issuecomment-2533183424
Resolved almost all comments. Remaining two discussion thread:
1. Add application expired event metric:
https://github.com/apache/kafka/pull/17199#discussion_r1878098712
2.
1 - 100 of 274 matches
Mail list logo
