cshannon commented on code in PR #16754:
URL: https://github.com/apache/kafka/pull/16754#discussion_r1879095660
##########
connect/mirror/src/test/java/org/apache/kafka/connect/mirror/integration/DedicatedMirrorIntegrationTest.java:
##########
@@ -280,7 +280,12 @@ public void testMultiNodeCluster() throws Exception {
// Cluster aliases
final String a = "A";
// Use a convoluted cluster name to ensure URL encoding/decoding
works
- final String b = "B- ._~:/?#[]@!$&'()*+;=\"<>%{}|\\^`618";
+ // TODO: Jetty 12 throws a 400 amiguous error with the previous
test string here
+ // It seems like at least some encoded characters are not allowed
anymore based on
+ //
https://github.com/jetty/jetty.project/issues/11890#issuecomment-2156442947
+ // See https://github.com/jetty/jetty.project/issues/11890
+ //final String b = "B- ._~:/?#[]@!$&'()*+;=\"<>%{}|\\^`618";
+ final String b = "B";
Review Comment:
So there's actually a few characters that are not allowed, control
characters, backslash, etc. I went ahead and removed a few problem characters
so it works now. I also updated the comments for the section. You can see the
exact rules in the `Rejecting Suspicious Sequences` section as part of
https://jakarta.ee/specifications/servlet/6.0/jakarta-servlet-spec-6.0#uri-path-canonicalization
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
