ijuma commented on PR #18104: URL: https://github.com/apache/kafka/pull/18104#issuecomment-2533247888
Good point @chia7712 - it seems like the internal model for IntelliJ is actually correct even though the settings screen isn't. One other inconsistency I noticed is that IntelliJ seems to only have a single Java standard library association, so whichever SDK is picked at the project level will be the one one used when someone follows a definition (even if the actual version used by some modules may be older). So, to summarize: 1. This seems good enough for now, both IntelliJ editor tooltips and compiler output seem to be correct. 2. We should probably state in the README that configuring the IntelliJ SDK to Java 17 is likely to be the best compromise given that most modules have Java 17 as the minimum version (this matters for code navigation). In fact, it makes sense to cover the expected IntelliJ experience in the README too as it's a bit unintuitive. 3. We should probably file an issue with IntelliJ to address the settings inconsistency. 2 and 3 are unrelated to this PR, but I think good to do if people have cycles. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
