cshannon commented on code in PR #16754:
URL: https://github.com/apache/kafka/pull/16754#discussion_r1879098262
##########
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/rest/HerderRequestHandler.java:
##########
@@ -113,6 +113,7 @@ public <T, U> T completeOrForwardRequest(FutureCallback<T>
cb,
}
String forwardUrl = uriBuilder.build().toString();
log.debug("Forwarding request {} {} {}", forwardUrl, method,
body);
+ // TODO, we may need to set the reqest timeout as Idle timeout
on the HttpClient
Review Comment:
If we want to configure the idle timeout I guess the question is the best
way to do so. I think we'd either need to pass it as an argument to the
request() methods or add it to the AbstractConfig for RestClient so it has
access to it when constructing the HttpClient. I guess there's also the
question if it should always match the request timeout or it could be
configured as a separate config. Maybe this could be done as a follow on task
after this is merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
