cshannon commented on PR #16754: URL: https://github.com/apache/kafka/pull/16754#issuecomment-2533261940
@gharris1727 and @chia7712 - I think I addressed all the comments so this can be merged. The only outstanding [one](https://github.com/apache/kafka/pull/16754#discussion_r1879098262) was if we wanted to set the idle timeout on the HttpClient to match the same thing as the request timeout (or even make it configurable separately) but I am still not quite sure if we should and I think that might be better as a follow on discussion and don't think it's a blocker. I can work on a PR for that depending on what we wanted to do (if anything) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
