gharris1727 commented on code in PR #17741:
URL: https://github.com/apache/kafka/pull/17741#discussion_r1879274614
##########
.gitignore:
##########
@@ -61,3 +61,6 @@ storage/kafka-tiered-storage/
docker/test/report_*.html
kafka.Kafka
__pycache__
+/connect/runtime/src/main/java/org/apache/kafka/connect/testing/
+/connect/file/
+/connect/json/
Review Comment:
bump on this
##########
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/ConnectorConfig.java:
##########
@@ -98,6 +118,12 @@ public class ConnectorConfig extends AbstractConfig {
new InstantiableClassValidator()
);
+ public static final String VALUE_CONVERTER_VERSION_CONFIG =
WorkerConfig.VALUE_CONVERTER_VERSION;
+ private static final String VALUE_CONVERTER_VERSION_DEFAULT = null;
+ private static final String VALUE_CONVERTER_VERSION_DOC = "Version of the
value converter.";
+ private static final String VALUE_CONVERTER_VERSION_DISPLAY = "Value
converter version";
+ private static final ConfigDef.Validator VALUE_CONVERTER_VERSION_VALIDATOR
= new PluginVersionValidator();
+
public static final String HEADER_CONVERTER_CLASS_CONFIG =
WorkerConfig.HEADER_CONVERTER_CLASS_CONFIG;
public static final String HEADER_CONVERTER_CLASS_DOC =
WorkerConfig.HEADER_CONVERTER_CLASS_DOC;
public static final String HEADER_CONVERTER_CLASS_DISPLAY = "Header
converter class";
Review Comment:
bump on this
##########
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/isolation/ReflectionScanner.java:
##########
@@ -1,149 +1,149 @@
-/*
Review Comment:
nit: large diff.
How does this happen? I don't see what the change is...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
