bruno-roustant commented on code in PR #106:
URL: https://github.com/apache/solr-sandbox/pull/106#discussion_r1592115657
##
encryption/src/main/java/org/apache/solr/encryption/EncryptionBackupRepository.java:
##
@@ -0,0 +1,98 @@
+/*
+ * Licensed to the Apache Software Foundation
epugh commented on code in PR #2232:
URL: https://github.com/apache/solr/pull/2232#discussion_r1592330465
##
solr/prometheus-exporter/src/java/org/apache/solr/prometheus/exporter/SolrExporter.java:
##
@@ -103,6 +104,13 @@ public class SolrExporter {
private static final Strin
cpoerschke commented on PR #2248:
URL: https://github.com/apache/solr/pull/2248#issuecomment-2098220313
> Merging to main was unexpected to me because of the healthy code review
happening here didn't conclude. ...
I was surprised by this merge too and my initial thought was that it mi
draperunner commented on code in PR #2232:
URL: https://github.com/apache/solr/pull/2232#discussion_r1592370513
##
solr/prometheus-exporter/src/java/org/apache/solr/prometheus/exporter/SolrExporter.java:
##
@@ -103,6 +104,13 @@ public class SolrExporter {
private static final
bruno-roustant opened a new pull request, #2444:
URL: https://github.com/apache/solr/pull/2444
One line PR to make DelegatingBackupRepository extend
AbstractBackupRepository, so it has the config and the shouldVerifyChecksum
field.
--
This is an automated message from the Apache Git Serv
[
https://issues.apache.org/jira/browse/SOLR-17278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17844277#comment-17844277
]
Eric Pugh commented on SOLR-17278:
--
I think this commit broke errorprone? I am seeing:
Rudi Seitz created SOLR-17279:
-
Summary: consolidate security.json constants in test code
Key: SOLR-17279
URL: https://issues.apache.org/jira/browse/SOLR-17279
Project: Solr
Issue Type: Task
[
https://issues.apache.org/jira/browse/SOLR-17279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17844295#comment-17844295
]
Rudi Seitz commented on SOLR-17279:
---
Will open a PR for this shortly.
> consolidate se
dsmiley commented on PR #2405:
URL: https://github.com/apache/solr/pull/2405#issuecomment-2098449310
> There are enough additional dependencies that I feel strongly this should
be another module.
WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the m
[
https://issues.apache.org/jira/browse/SOLR-17278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17844306#comment-17844306
]
Ishan Chattopadhyaya commented on SOLR-17278:
-
Ouch, I didn't check for it. I
[
https://issues.apache.org/jira/browse/SOLR-17278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17844308#comment-17844308
]
Ishan Chattopadhyaya commented on SOLR-17278:
-
Fwiw, it is a useless suggesti
mlbiscoc commented on PR #2405:
URL: https://github.com/apache/solr/pull/2405#issuecomment-2098515667
> > There are enough additional dependencies that I feel strongly this
should be another module.
>
> WDYT?
Sorry, I somehow completely missed this comment. When you say be ano
dsmiley commented on PR #2405:
URL: https://github.com/apache/solr/pull/2405#issuecomment-2098523726
```
io.prometheus:prometheus-metrics-config:1.1.0 (1 constraints: 3e164ed8)
io.prometheus:prometheus-metrics-exposition-formats:1.1.0 (1 constraints:
0405f335)
io.prometheus:promethe
Chris M. Hostetter created SOLR-17280:
-
Summary: SolrRangeQuery can trigger "IllegalStateException:
Recursive update" in CaffeineCache / ConcurrentHashMap
Key: SOLR-17280
URL: https://issues.apache.org/jira/br
[
https://issues.apache.org/jira/browse/SOLR-17280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17844401#comment-17844401
]
Chris M. Hostetter commented on SOLR-17280:
---
This can sometimes be reproduced b
[
https://issues.apache.org/jira/browse/SOLR-17280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17844407#comment-17844407
]
Mike Drob commented on SOLR-17280:
--
Is this the same as SOLR-16707
> SolrRangeQuery can
mlbiscoc commented on PR #2405:
URL: https://github.com/apache/solr/pull/2405#issuecomment-2098969932
> ```
> io.prometheus:prometheus-metrics-config:1.1.0 (1 constraints: 3e164ed8)
> io.prometheus:prometheus-metrics-exposition-formats:1.1.0 (1 constraints:
0405f335)
> io.prometheus
rseitz opened a new pull request, #2445:
URL: https://github.com/apache/solr/pull/2445
https://issues.apache.org/jira/browse/SOLR-17279
# Description
The PR creates a SecurityJson utility class that holds a standard
"security.json" configuration for use by tests that enable sec
rseitz commented on PR #2445:
URL: https://github.com/apache/solr/pull/2445#issuecomment-2098977485
Tagging @epugh
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsub
[
https://issues.apache.org/jira/browse/SOLR-17279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17844410#comment-17844410
]
Rudi Seitz commented on SOLR-17279:
---
PR: https://github.com/apache/solr/pull/2445
> co
[
https://issues.apache.org/jira/browse/SOLR-17280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17844412#comment-17844412
]
Chris M. Hostetter commented on SOLR-17280:
---
Seems alluded to – in particular t
[
https://issues.apache.org/jira/browse/SOLR-17280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17844413#comment-17844413
]
Chris M. Hostetter commented on SOLR-17280:
---
My main question would be: WTF doe
[
https://issues.apache.org/jira/browse/SOLR-17280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17844414#comment-17844414
]
Mike Drob commented on SOLR-17280:
--
Yea, I hear what you're saying.
I suspect that what
[
https://issues.apache.org/jira/browse/SOLR-17280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17844415#comment-17844415
]
Mike Drob commented on SOLR-17280:
--
As far as the cache insertion, that dates all the wa
[
https://issues.apache.org/jira/browse/SOLR-17280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17844424#comment-17844424
]
Michael Gibney commented on SOLR-17280:
---
If the main question on this issue is abou
dsmiley commented on code in PR #2276:
URL: https://github.com/apache/solr/pull/2276#discussion_r1592980298
##
solr/core/src/java/org/apache/solr/update/UpdateShardHandler.java:
##
@@ -133,16 +135,25 @@ public UpdateShardHandler(UpdateShardHandlerConfig cfg) {
Distr
dsmiley commented on code in PR #2276:
URL: https://github.com/apache/solr/pull/2276#discussion_r1592989945
##
solr/core/src/test/org/apache/solr/handler/TestUserManagedReplicationWithAuth.java:
##
@@ -0,0 +1,267 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
dsmiley commented on code in PR #2276:
URL: https://github.com/apache/solr/pull/2276#discussion_r1592994488
##
solr/core/src/test/org/apache/solr/handler/TestUserManagedReplicationWithAuth.java:
##
@@ -0,0 +1,267 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
dsmiley commented on code in PR #2276:
URL: https://github.com/apache/solr/pull/2276#discussion_r1593008731
##
solr/solrj/src/java/org/apache/solr/client/solrj/impl/Http2SolrClient.java:
##
@@ -115,6 +115,11 @@ public class Http2SolrClient extends HttpSolrClientBase {
private
[
https://issues.apache.org/jira/browse/SOLR-17274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1780#comment-1780
]
Calvin Smith commented on SOLR-17274:
-
It would be nice if we didn't have to switch t
[
https://issues.apache.org/jira/browse/SOLR-17274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1787#comment-1787
]
David Smiley commented on SOLR-17274:
-
Ah right, if the schema isn't child doc enable
[
https://issues.apache.org/jira/browse/SOLR-17275?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Smiley updated SOLR-17275:
Fix Version/s: 9.6.1
Ouch! The fix should go in 9.6.1.
Maybe even aliases could be checked firs
github-actions[bot] commented on PR #2304:
URL: https://github.com/apache/solr/pull/2304#issuecomment-2099495565
This PR had no visible activity in the past 60 days, labeling it as stale.
Any new activity will remove the stale label. To attract more reviewers, please
tag someone or notify t
github-actions[bot] commented on PR #2288:
URL: https://github.com/apache/solr/pull/2288#issuecomment-2099495596
This PR had no visible activity in the past 60 days, labeling it as stale.
Any new activity will remove the stale label. To attract more reviewers, please
tag someone or notify t
[
https://issues.apache.org/jira/browse/SOLR-17274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17844479#comment-17844479
]
Calvin Smith commented on SOLR-17274:
-
Sure, I'll make a PR and some tests.
> atomic
guoshipneg created SOLR-17282:
-
Summary: Update basic-authentication-plugin.adoc
Key: SOLR-17282
URL: https://issues.apache.org/jira/browse/SOLR-17282
Project: Solr
Issue Type: Wish
Securit
[
https://issues.apache.org/jira/browse/SOLR-17282?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
guoshipneg updated SOLR-17282:
--
Issue Type: Bug (was: Wish)
> Update basic-authentication-plugin.adoc
> --
[
https://issues.apache.org/jira/browse/SOLR-17282?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
guoshipneg updated SOLR-17282:
--
Issue Type: Improvement (was: Bug)
> Update basic-authentication-plugin.adoc
> ---
gspgsp opened a new pull request, #2446:
URL: https://github.com/apache/solr/pull/2446
https://issues.apache.org/jira/browse/SOLR-17282
# Description
for the pwd encode format, there missed a ')', and this confused me , so i
added this: (Format: base64(sha256(sha256(salt+passwo
[
https://issues.apache.org/jira/browse/SOLR-17282?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
guoshipneg updated SOLR-17282:
--
Description:
As I was reading through this documentation, I noticed a problem with the
encryption sect
[
https://issues.apache.org/jira/browse/SOLR-17282?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
guoshipneg updated SOLR-17282:
--
Description:
As I was reading through this documentation, I noticed a problem with the
encryption sect
iamsanjay commented on PR #2276:
URL: https://github.com/apache/solr/pull/2276#issuecomment-2099713438
Thinking out loud! The new logic, however bit ugly it is because it gives
freedom to manipulate the Http2SolrClient directly instead of creating it
through Builder patter -- _anti-pattern_
42 matches
Mail list logo