mlbiscoc commented on PR #2405: URL: https://github.com/apache/solr/pull/2405#issuecomment-2098515667
> > There are enough additional dependencies that I feel strongly this should be another module. > > WDYT? Sorry, I somehow completely missed this comment. When you say be another module, do you mean move it to `solr/modules` that needs to be enabled? If so, I think that prometheus metrics is valuable enough to be part of core and enabled by default but I also only added 2 additional dependencies. Is that enough to be its own module? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
