[ 
https://issues.apache.org/jira/browse/SOLR-17278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17844277#comment-17844277
 ] 

Eric Pugh commented on SOLR-17278:
----------------------------------

I think this commit broke errorprone?   I am seeing:

 
 Task :solr:core:compileTestJava FAILED 
 
/home/runner/work/solr/solr/solr/core/src/test/org/apache/solr/util/TimeZoneUtilsTest.java:65:
 warning: [OperatorPrecedence] Use grouping parenthesis to make the operator 
precedence explicit 
 
 if (expected.useDaylightTime() && expected.getDSTSavings() == 0 
 
 ^ 
 
 (see [https://errorprone.info/bugpattern/OperatorPrecedence)] 
 
 Did you mean 'if ((expected.useDaylightTime() && expected.getDSTSavings() == 
0)'? 
 
/home/runner/work/solr/solr/solr/core/src/test/org/apache/solr/util/TimeZoneUtilsTest.java:66:
 warning: [OperatorPrecedence] Use grouping parenthesis to make the operator 
precedence explicit 
 
 || actual.useDaylightTime() && actual.getDSTSavings() == 0) { 
 
 ^ 
 
 (see [https://errorprone.info/bugpattern/OperatorPrecedence)] 
 
 Did you mean '|| (actual.useDaylightTime() && actual.getDSTSavings() == 0)) 
{'? 
 
error: warnings found and -Werror specified

> Timezone with DST=true and DST=0 fails test
> -------------------------------------------
>
>                 Key: SOLR-17278
>                 URL: https://issues.apache.org/jira/browse/SOLR-17278
>             Project: Solr
>          Issue Type: Bug
>      Security Level: Public(Default Security Level. Issues are Public) 
>            Reporter: Ishan Chattopadhyaya
>            Priority: Major
>             Fix For: 9.7
>
>         Attachments: SOLR-17278-1.patch, SOLR-17278.patch
>
>
> The TimeZoneUtilsTest#testValidIds() fails with some timezones that have 
> useDaylightTime() as true but getDSTSavings() returns 0. Such timezones can't 
> be converted to String using String.valueOf().
> Here's my JVM:
> {code}
> [ishan@deskmini solr] $ java -version
> openjdk version "11.0.22" 2024-01-16
> OpenJDK Runtime Environment (Red_Hat-11.0.22.0.7-1) (build 11.0.22+7)
> OpenJDK 64-Bit Server VM (Red_Hat-11.0.22.0.7-1) (build 11.0.22+7, mixed 
> mode, sharing)
> {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to