rseitz opened a new pull request, #2445:
URL: https://github.com/apache/solr/pull/2445

   https://issues.apache.org/jira/browse/SOLR-17279
   
   # Description
   
   The PR creates a SecurityJson utility class that holds a standard 
"security.json" configuration for use by tests that enable security. Various 
tests were declaring the same copy/pasted SECURITY_JSON constant, resulting in 
code duplication; this PR updates those tests to use the new 
SecurityJson.SIMPLE constant. This is a refactoring PR that only affects test 
code and does not change any test logic.
   
   # Solution
   
   N/A
   
   # Tests
   
   No new tests added; got a successful `./gradlew check`
   
   # Checklist
   
   Please review the following and check all that apply:
   
   - [x] I have reviewed the guidelines for [How to 
Contribute](https://github.com/apache/solr/blob/main/CONTRIBUTING.md) and my 
code conforms to the standards described there to the best of my ability.
   - [x] I have created a Jira issue and added the issue ID to my pull request 
title.
   - [x] I have given Solr maintainers 
[access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork)
 to contribute to my PR branch. (optional but recommended)
   - [x] I have developed this patch against the `main` branch.
   - [x] I have run `./gradlew check`.
   - [ ] I have added tests for my changes.
   - [ ] I have added documentation for the [Reference 
Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to