draperunner commented on code in PR #2232:
URL: https://github.com/apache/solr/pull/2232#discussion_r1592370513
##########
solr/prometheus-exporter/src/java/org/apache/solr/prometheus/exporter/SolrExporter.java:
##########
@@ -103,6 +104,13 @@ public class SolrExporter {
private static final String ARG_CREDENTIALS_HELP =
"Specify the credentials in the format username:password. Example:
--credentials solr:SolrRocks";
+ private static final String[] ARG_SSL_FLAGS = {"-ssl", "--ssl-enabled"};
+ private static final String ARG_SSL_METAVAR = "SSL_ENABLED";
+ private static final String ARG_SSL_DEST = "ssl_enabled";
+ private static final boolean ARG_SSL_DEFAULT = false;
+ private static final String ARG_SSL_HELP =
+ "Enable tls to Solr. Expects following env varables: SOLR_SSL_KEY_STORE,
SOLR_SSL_KEY_STORE_PASSWORD, SOLR_SSL_TRUST_STORE,
SOLR_SSL_TRUST_STORE_PASSWORD. Example: --ssl-enabled true";
Review Comment:
Good point. I have updated the text with your suggestion and also fixed the
typo in "varables".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
